From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A99C848A44 for ; Fri, 31 Oct 2025 15:36:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1CA940150; Fri, 31 Oct 2025 15:36:17 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 62FDE40150 for ; Fri, 31 Oct 2025 15:36:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3gl5yLPbZ3Dpla0jvcyFktFQgqIfuBC8Upf4l6RWzZg=; b=GcaiBWZN/yWMPs+l4njN4sZc7vGaI0t+dX+YYyrsfSoRF1ytNqCLIfvjt/GnT9m+mlPgnw 99+9pKtdedhS0N6pATzSfGpFHEVLu64mr32Y0q7+a5gnHHnUZTTquU86cJS7LHTbkaGUrH azKjifhWcJ5Z/FWGeMcX3uuMbObgsVU= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-195-4ovPpr66MIS05EJXbpvl0g-1; Fri, 31 Oct 2025 10:36:14 -0400 X-MC-Unique: 4ovPpr66MIS05EJXbpvl0g-1 X-Mimecast-MFC-AGG-ID: 4ovPpr66MIS05EJXbpvl0g_1761921373 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 656C91954B0B; Fri, 31 Oct 2025 14:36:13 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D0E79180044F; Fri, 31 Oct 2025 14:36:11 +0000 (UTC) From: Kevin Traynor To: Joshua Washington Cc: Praveen Kaligineedi , dpdk stable Subject: patch 'net/gve: fix disabling interrupts on DQ' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:28 +0000 Message-ID: <20251031143421.324432-26-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _0CXNLo_GNwUCbCb4z_n3kFRLqBEEIOHjgYrxaSynv8_1761921373 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/d6ef9b8798834764c517e7fccbdca0a0b53b8772 Thanks. Kevin --- >From d6ef9b8798834764c517e7fccbdca0a0b53b8772 Mon Sep 17 00:00:00 2001 From: Joshua Washington Date: Mon, 4 Aug 2025 13:50:24 -0700 Subject: [PATCH] net/gve: fix disabling interrupts on DQ [ upstream commit 8a6418e11a4d9e3554d592b1b3e3957fea8e7cee ] When starting Rx and Tx queues in the DQ queue format, the driver was erroneously writing GVE_IRQ_MASK to the IRQ doorbell. GQ and DQ have different interrupt register layouts, so writing this bit is incorrect. Update the register write to properly enable NO_INT_MODE for DQO. Fixes: b044845bb015 ("net/gve: support queue start/stop") Signed-off-by: Joshua Washington Reviewed-by: Praveen Kaligineedi --- drivers/net/gve/base/gve_desc_dqo.h | 4 ++++ drivers/net/gve/gve_rx_dqo.c | 4 +++- drivers/net/gve/gve_tx_dqo.c | 4 +++- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/gve/base/gve_desc_dqo.h b/drivers/net/gve/base/gve_desc_dqo.h index bb4a18d4d1..71d9d60bb9 100644 --- a/drivers/net/gve/base/gve_desc_dqo.h +++ b/drivers/net/gve/base/gve_desc_dqo.h @@ -249,3 +249,7 @@ GVE_CHECK_STRUCT_LEN(32, gve_rx_compl_desc_dqo); #define GVE_RX_BUF_THRESH_DQO 32 +/* GVE IRQ */ +#define GVE_NO_INT_MODE_DQO BIT(30) +#define GVE_ITR_NO_UPDATE_DQO (3 << 3) + #endif /* _GVE_DESC_DQO_H_ */ diff --git a/drivers/net/gve/gve_rx_dqo.c b/drivers/net/gve/gve_rx_dqo.c index 285c6ddd61..0103add985 100644 --- a/drivers/net/gve/gve_rx_dqo.c +++ b/drivers/net/gve/gve_rx_dqo.c @@ -416,5 +416,7 @@ gve_rx_queue_start_dqo(struct rte_eth_dev *dev, uint16_t rx_queue_id) rxq->qrx_tail = &hw->db_bar2[rte_be_to_cpu_32(rxq->qres->db_index)]; - rte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), rxq->ntfy_addr); + rte_write32(rte_cpu_to_le_32(GVE_NO_INT_MODE_DQO | + GVE_ITR_NO_UPDATE_DQO), + rxq->ntfy_addr); ret = gve_rxq_mbufs_alloc_dqo(rxq); diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c index 169c40d5b0..c36c215b94 100644 --- a/drivers/net/gve/gve_tx_dqo.c +++ b/drivers/net/gve/gve_tx_dqo.c @@ -532,5 +532,7 @@ gve_tx_queue_start_dqo(struct rte_eth_dev *dev, uint16_t tx_queue_id) &hw->cnt_array[rte_be_to_cpu_32(txq->qres->counter_index)]; - rte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), txq->ntfy_addr); + rte_write32(rte_cpu_to_le_32(GVE_NO_INT_MODE_DQO | + GVE_ITR_NO_UPDATE_DQO), + txq->ntfy_addr); dev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED; -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:53.061458556 +0000 +++ 0026-net-gve-fix-disabling-interrupts-on-DQ.patch 2025-10-31 13:53:52.052523418 +0000 @@ -1 +1 @@ -From 8a6418e11a4d9e3554d592b1b3e3957fea8e7cee Mon Sep 17 00:00:00 2001 +From d6ef9b8798834764c517e7fccbdca0a0b53b8772 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8a6418e11a4d9e3554d592b1b3e3957fea8e7cee ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org