From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1588148A44 for ; Fri, 31 Oct 2025 15:35:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F15F40150; Fri, 31 Oct 2025 15:35:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5DC1740150 for ; Fri, 31 Oct 2025 15:35:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1wdhvueks2DsSWMyfXkPHSrRqP3RiEAvGKs5v6pYEZU=; b=Fd3K+wVZlBFnXTs0Ne8ONVoMPrPKwS0DTCQhvCsePNdGyBggouSyqkDcdyHj953VOSkd5G OngMS3tAF7JCe695pYRunA4CUI+IkPsHkdtydgl304sWn8egkLWyqf/kZpsz5R1P7/ulsy nPTxUMZOBAhyi4S0+firydureu0jxt4= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-9DONKQc4NfWZDG1Pzxt_YA-1; Fri, 31 Oct 2025 10:35:21 -0400 X-MC-Unique: 9DONKQc4NfWZDG1Pzxt_YA-1 X-Mimecast-MFC-AGG-ID: 9DONKQc4NfWZDG1Pzxt_YA_1761921320 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8B13418001E8; Fri, 31 Oct 2025 14:35:20 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 953A71800452; Fri, 31 Oct 2025 14:35:18 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Bruce Richardson , Marat Khalili , dpdk stable Subject: patch 'cmdline: fix port list parsing' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:05 +0000 Message-ID: <20251031143421.324432-3-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _NDAQDVla-FBSwfl2K5B9hM8prEwB43GthavUk1LOPo_1761921320 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/2b2f79af59297ea13bccf2fce249d6960c3c607b Thanks. Kevin --- >From 2b2f79af59297ea13bccf2fce249d6960c3c607b Mon Sep 17 00:00:00 2001 From: David Marchand Date: Mon, 3 Feb 2025 13:47:33 +0100 Subject: [PATCH] cmdline: fix port list parsing [ upstream commit 48e03475262798e6758b9c767e87e2f88375072c ] Doing arithmetic with the NULL pointer is undefined. Caught by UBSan: ../lib/cmdline/cmdline_parse_portlist.c:40:19: runtime error: applying non-zero offset 1 to null pointer SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../lib/cmdline/cmdline_parse_portlist.c:40:19 in Fixes: af75078fece3 ("first public release") Signed-off-by: David Marchand Acked-by: Bruce Richardson Acked-by: Marat Khalili --- lib/cmdline/cmdline_parse_portlist.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/cmdline/cmdline_parse_portlist.c b/lib/cmdline/cmdline_parse_portlist.c index 2e2294553a..290e61f211 100644 --- a/lib/cmdline/cmdline_parse_portlist.c +++ b/lib/cmdline/cmdline_parse_portlist.c @@ -32,13 +32,10 @@ static int parse_ports(cmdline_portlist_t *pl, const char *str) { + const char *first = str; size_t ps, pe; - const char *first, *last; char *end; - for (first = str, last = first; - first != NULL && last != NULL; - first = last + 1) { - - last = strchr(first, ','); + while (first != NULL) { + const char *last = strchr(first, ','); errno = 0; @@ -64,4 +61,5 @@ parse_ports(cmdline_portlist_t *pl, const char *str) parse_set_list(pl, ps, pe); + first = (last == NULL ? NULL : last + 1); } -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:52.411615984 +0000 +++ 0003-cmdline-fix-port-list-parsing.patch 2025-10-31 13:53:52.005623420 +0000 @@ -1 +1 @@ -From 48e03475262798e6758b9c767e87e2f88375072c Mon Sep 17 00:00:00 2001 +From 2b2f79af59297ea13bccf2fce249d6960c3c607b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 48e03475262798e6758b9c767e87e2f88375072c ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index ef6ce223b5..549f6d9671 100644 +index 2e2294553a..290e61f211 100644 @@ -29 +30 @@ -@@ -34,13 +34,10 @@ static int +@@ -32,13 +32,10 @@ static int @@ -46 +47 @@ -@@ -66,4 +63,5 @@ parse_ports(cmdline_portlist_t *pl, const char *str) +@@ -64,4 +61,5 @@ parse_ports(cmdline_portlist_t *pl, const char *str)