From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41F3848A44 for ; Fri, 31 Oct 2025 15:36:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AC5140663; Fri, 31 Oct 2025 15:36:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6051C4065F for ; Fri, 31 Oct 2025 15:36:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V19CcmV3xdTFgZLIl20k0Matd1stbhBe7r8H/Fvp+BE=; b=EVpKz2ZdL/CqHMSYg15qjMnSKlp+bTNCt1b514g7YyvY3B6N+U3roXFFf4mQicictgwob5 hqQ6rEbvzSx9u7fB+SU45S24TYACJDMfkWdjBj6TGSJ9ml6c1mzod9eHBV5WmgBxHZgdJ+ TfeqZwEcNpUxxxYCxpO4MoKKXxpBb8Q= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-206-HqZTxn8JMGSPWKjk8iw4rA-1; Fri, 31 Oct 2025 10:36:32 -0400 X-MC-Unique: HqZTxn8JMGSPWKjk8iw4rA-1 X-Mimecast-MFC-AGG-ID: HqZTxn8JMGSPWKjk8iw4rA_1761921389 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D68D51956053; Fri, 31 Oct 2025 14:36:28 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7109D18004D4; Fri, 31 Oct 2025 14:36:21 +0000 (UTC) From: Kevin Traynor To: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Cc: dpdk stable Subject: patch 'app/testpmd: validate DSCP and VLAN for meter creation' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:32 +0000 Message-ID: <20251031143421.324432-30-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6hKQz3zOJCjgQJLw83SoM7d3bZAPf3UETPMDjthM4vQ_1761921389 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/4c3c8dad45bf7f1a745e33d7e1f3b3bb7a94773b Thanks. Kevin --- >From 4c3c8dad45bf7f1a745e33d7e1f3b3bb7a94773b Mon Sep 17 00:00:00 2001 From: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Date: Thu, 28 Aug 2025 01:29:01 -0400 Subject: [PATCH] app/testpmd: validate DSCP and VLAN for meter creation [ upstream commit 00092e969aad2fb2a2017b7eec86f033d4527950 ] Add validation mechanism for meter creation. The maximum possible entries are [ ...] [ ... ]. Currently, testpmd allows any input table entries for DSCP and VLAN tables. This patch validates the maximum possible DSCP and VLAN table entries for meter creation. Fixes: 9f5488e326d3b ("app/testpmd: support different input color method") Signed-off-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> --- app/test-pmd/cmdline_mtr.c | 30 +++++++++++++++++++++++++----- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c index e16c5b268f..0c5897ada8 100644 --- a/app/test-pmd/cmdline_mtr.c +++ b/app/test-pmd/cmdline_mtr.c @@ -86,4 +86,17 @@ parse_uint(uint64_t *value, const char *str) } +static int +validate_input_color_table_entries(char *str) +{ + char *saveptr; + char *token = strtok_r(str, PARSE_DELIMITER, &saveptr); + for (int i = 0; token != NULL; i++) { + if (i > ((MAX_DSCP_TABLE_ENTRIES + MAX_VLAN_TABLE_ENTRIES) - 1)) + return -1; + token = strtok_r(NULL, PARSE_DELIMITER, &saveptr); + } + return 0; +} + static int parse_input_color_table_entries(char *str, enum rte_color **dscp_table, @@ -91,8 +104,15 @@ parse_input_color_table_entries(char *str, enum rte_color **dscp_table, { enum rte_color *vlan, *dscp; - char *token; + char *token, *saveptr; + char *temp_str = strdup(str); int i = 0; - token = strtok_r(str, PARSE_DELIMITER, &str); + if (validate_input_color_table_entries(temp_str)) { + free(temp_str); + return -1; + } + free(temp_str); + + token = strtok_r(str, PARSE_DELIMITER, &saveptr); if (token == NULL) return 0; @@ -118,5 +138,5 @@ parse_input_color_table_entries(char *str, enum rte_color **dscp_table, break; - token = strtok_r(str, PARSE_DELIMITER, &str); + token = strtok_r(NULL, PARSE_DELIMITER, &saveptr); if (token == NULL) { free(dscp); @@ -127,5 +147,5 @@ parse_input_color_table_entries(char *str, enum rte_color **dscp_table, *dscp_table = dscp; - token = strtok_r(str, PARSE_DELIMITER, &str); + token = strtok_r(NULL, PARSE_DELIMITER, &saveptr); if (token == NULL) return 0; @@ -155,5 +175,5 @@ parse_input_color_table_entries(char *str, enum rte_color **dscp_table, break; - token = strtok_r(str, PARSE_DELIMITER, &str); + token = strtok_r(NULL, PARSE_DELIMITER, &saveptr); if (token == NULL) { free(vlan); -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:53.175783592 +0000 +++ 0030-app-testpmd-validate-DSCP-and-VLAN-for-meter-creatio.patch 2025-10-31 13:53:52.058523437 +0000 @@ -1 +1 @@ -From 00092e969aad2fb2a2017b7eec86f033d4527950 Mon Sep 17 00:00:00 2001 +From 4c3c8dad45bf7f1a745e33d7e1f3b3bb7a94773b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 00092e969aad2fb2a2017b7eec86f033d4527950 ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org