From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2429748A44 for ; Fri, 31 Oct 2025 15:36:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1906F40150; Fri, 31 Oct 2025 15:36:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0974640150 for ; Fri, 31 Oct 2025 15:36:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XgtrqgRZBKaoF6hmyoII8XWLQ6SasSB/CQDmpWi1Qyc=; b=g5p/esjpwKxAiSWSR85VEBIuMFdx5lDfhrqGDX83CqQH27ROK8kaRi/JyQI1eVSvXLHzz8 s3E/yUpMk1jI/kjR2X8SYjEkugMnGD9ZNPOFgrg1u7j+mBHUuxWCPX8iwbhgu7nNLYKfbt 5l34ooUjfxRqDiOjx0iflZpRh2pN2E4= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-131-46lXA8JRMRqxfracmAl21w-1; Fri, 31 Oct 2025 10:36:34 -0400 X-MC-Unique: 46lXA8JRMRqxfracmAl21w-1 X-Mimecast-MFC-AGG-ID: 46lXA8JRMRqxfracmAl21w_1761921393 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2BBF219560B0; Fri, 31 Oct 2025 14:36:33 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9296218004D4; Fri, 31 Oct 2025 14:36:31 +0000 (UTC) From: Kevin Traynor To: Maayan Kashani Cc: Bing Zhao , dpdk stable Subject: patch 'net/mlx5: fix default flow rules start' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:34 +0000 Message-ID: <20251031143421.324432-32-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _bj4s7TsOwuT4wqekXoIfX_YBCUYNSkyOp-1RUy4-w4_1761921393 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/8806e824933ba0bdc08498f14310d89f173e2fb0 Thanks. Kevin --- >From 8806e824933ba0bdc08498f14310d89f173e2fb0 Mon Sep 17 00:00:00 2001 From: Maayan Kashani Date: Wed, 30 Jul 2025 14:35:12 +0300 Subject: [PATCH] net/mlx5: fix default flow rules start [ upstream commit 6f4909dfa017aacfca6a3fc89d014d474b1fbc6a ] As part of non-template implementation, new default rule was added in HWS mode (dv_flow_en=2) in case dv_xmeta_en=4 (32bits extended META for HWS mode). In case the proxy port did not start, and it was not configured, it failed to create this rule and failed to start port representors. Added ignore for this failure to align to other default rules creation failure behaviour, and to enable testing port representors w/o starting the proxy port. Fixes: 821a6a5cc495 ("net/mlx5: add metadata split for compatibility") Signed-off-by: Maayan Kashani Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index f83ae1883d..5039a81b14 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -8231,6 +8231,16 @@ mlx5_flow_start_default(struct rte_eth_dev *dev) struct mlx5_priv *priv = dev->data->dev_private; - if (priv->sh->config.dv_flow_en == 2) - return mlx5_flow_nta_add_default_copy_action(dev, &error); + if (priv->sh->config.dv_flow_en == 2) { + /* + * Ignore this failure, if the proxy port is not started, other + * default jump actions are not created and this rule will not + * be hit. + */ + if (mlx5_flow_nta_add_default_copy_action(dev, &error)) { + DRV_LOG(DEBUG, "port %u failed to start default copy action: %s", + dev->data->port_id, strerror(rte_errno)); + return 0; + } + } #endif /* Make sure default copy action (reg_c[0] -> reg_b) is created. */ -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:53.246545457 +0000 +++ 0032-net-mlx5-fix-default-flow-rules-start.patch 2025-10-31 13:53:52.071523477 +0000 @@ -1 +1 @@ -From 6f4909dfa017aacfca6a3fc89d014d474b1fbc6a Mon Sep 17 00:00:00 2001 +From 8806e824933ba0bdc08498f14310d89f173e2fb0 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6f4909dfa017aacfca6a3fc89d014d474b1fbc6a ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index 8db372123c..7c6811b523 100644 +index f83ae1883d..5039a81b14 100644 @@ -29 +30 @@ -@@ -8218,6 +8218,16 @@ mlx5_flow_start_default(struct rte_eth_dev *dev) +@@ -8231,6 +8231,16 @@ mlx5_flow_start_default(struct rte_eth_dev *dev)