From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E9E348A44 for ; Fri, 31 Oct 2025 15:36:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87DFE40669; Fri, 31 Oct 2025 15:36:41 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6EC5340655 for ; Fri, 31 Oct 2025 15:36:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tVtYKQufo/P6ocyfe/XrmLXi+PWzv1YhDySK1szn8iw=; b=SBdXE08V949clKJpJtKnjBk6Gw8GHUKth2hLgPzFyEujXhdITo+bMjq5XWUO7Og1CThS5V 1VOzNpldLouR/SaulYYMX+edc2RxCNqRTw9OQqTZFr14+Rmwz2dD+F/8+mUJh4siMoM+0X Y1BATpEIHAY9UavFEanKyuVWaPlYrtM= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-173-QfoBffXhPa-0IEC7N3vwUQ-1; Fri, 31 Oct 2025 10:36:38 -0400 X-MC-Unique: QfoBffXhPa-0IEC7N3vwUQ-1 X-Mimecast-MFC-AGG-ID: QfoBffXhPa-0IEC7N3vwUQ_1761921397 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 733F81800345; Fri, 31 Oct 2025 14:36:37 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E07D618004D4; Fri, 31 Oct 2025 14:36:35 +0000 (UTC) From: Kevin Traynor To: Maayan Kashani Cc: Dariusz Sosnowski , dpdk stable Subject: patch 'net/mlx5: fix use after scope of RSS configuration' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:36 +0000 Message-ID: <20251031143421.324432-34-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: oZu64nn3W0odcUnDsXRQWy0PVfz-lh5Ge4xXWNI0QqE_1761921397 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/b77323ec4ad783ac997dc630c38c0d175a71f8fc Thanks. Kevin --- >From b77323ec4ad783ac997dc630c38c0d175a71f8fc Mon Sep 17 00:00:00 2001 From: Maayan Kashani Date: Tue, 5 Aug 2025 16:20:57 +0300 Subject: [PATCH] net/mlx5: fix use after scope of RSS configuration [ upstream commit b7dedd019a034331fbc67b1d10d59bf3531b5048 ] This patch addresses AddressSanitizer (ASan) stack-use-after-scope issues occurring during RSS flow creation in the MLX5 driver. The root cause stemmed from the use of compound literals to initialize flow action configurations, which could result in pointers to temporary stack memory being retained in flow structures. When these pointers were later accessed during flow conversion, the underlying stack memory was no longer valid, leading to ASAN-detected errors. Modifications: In mlx5_hw_rss_ptype_create_base_flow(), the struct rte_flow_action_jump is now constructed at the start of the function, rather than within the do statement. This ensures a persistent stack allocation for the structure, preventing use-after-scope situations. This change eliminates the following ASan errors: stack-use-after-scope reported in rte_flow_conv_copy Fixes: ae67e3c43dd5 ("net/mlx5: support RSS expansion in non-template HWS setup") Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_nta_rss.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_nta_rss.c b/drivers/net/mlx5/mlx5_nta_rss.c index 602df301ac..781eaf5e99 100644 --- a/drivers/net/mlx5/mlx5_nta_rss.c +++ b/drivers/net/mlx5/mlx5_nta_rss.c @@ -320,4 +320,7 @@ mlx5_hw_rss_ptype_create_base_flow(struct rte_eth_dev *dev, struct rte_flow_action actions[MLX5_HW_MAX_ACTS]; enum mlx5_indirect_type indirect_type; + const struct rte_flow_action_jump jump_conf = { + .group = ptype_group + }; do { @@ -334,7 +337,5 @@ mlx5_hw_rss_ptype_create_base_flow(struct rte_eth_dev *dev, case RTE_FLOW_ACTION_TYPE_RSS: actions[i].type = RTE_FLOW_ACTION_TYPE_JUMP; - actions[i].conf = &(const struct rte_flow_action_jump) { - .group = ptype_group - }; + actions[i].conf = &jump_conf; break; default: -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:53.310006072 +0000 +++ 0034-net-mlx5-fix-use-after-scope-of-RSS-configuration.patch 2025-10-31 13:53:52.079523502 +0000 @@ -1 +1 @@ -From b7dedd019a034331fbc67b1d10d59bf3531b5048 Mon Sep 17 00:00:00 2001 +From b77323ec4ad783ac997dc630c38c0d175a71f8fc Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b7dedd019a034331fbc67b1d10d59bf3531b5048 ] + @@ -26 +27,0 @@ -Cc: stable@dpdk.org @@ -35 +36 @@ -index 8f00510445..1d2940a370 100644 +index 602df301ac..781eaf5e99 100644 @@ -38 +39 @@ -@@ -321,4 +321,7 @@ mlx5_hw_rss_ptype_create_base_flow(struct rte_eth_dev *dev, +@@ -320,4 +320,7 @@ mlx5_hw_rss_ptype_create_base_flow(struct rte_eth_dev *dev, @@ -46 +47 @@ -@@ -335,7 +338,5 @@ mlx5_hw_rss_ptype_create_base_flow(struct rte_eth_dev *dev, +@@ -334,7 +337,5 @@ mlx5_hw_rss_ptype_create_base_flow(struct rte_eth_dev *dev,