From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACF4D48A44 for ; Fri, 31 Oct 2025 15:36:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A51A940150; Fri, 31 Oct 2025 15:36:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 072A440150 for ; Fri, 31 Oct 2025 15:36:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=98BGQcQQvni86Z2AhpKypm2P4HaqRBmis+xic2d+yYA=; b=NsXo5MkSXiqh8Mj2ekQ3zryDNwVW66PnukJhVIzN/VXCffjwJCawyjT3c9RRaOADIbTti+ mCgMktN7dz255+0O3+Wq3k9DRHL79fud42Dhc/TVCiQ2EbviBIghe2/hvRGhRTsQ2klkt/ PEyVb2iWTk5VzPLiMmvDtUCmWyUvka4= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-220-wsD6sejdMZWNXG7GoV-OrA-1; Fri, 31 Oct 2025 10:36:42 -0400 X-MC-Unique: wsD6sejdMZWNXG7GoV-OrA-1 X-Mimecast-MFC-AGG-ID: wsD6sejdMZWNXG7GoV-OrA_1761921400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 715F11955F24; Fri, 31 Oct 2025 14:36:40 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0BB25180044F; Fri, 31 Oct 2025 14:36:37 +0000 (UTC) From: Kevin Traynor To: Maayan Kashani Cc: Dariusz Sosnowski , Ivan Malov , dpdk stable Subject: patch 'net/mlx5: fix unsupported flow rule port action' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:37 +0000 Message-ID: <20251031143421.324432-35-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: nK5oSG8xBjP7rg1TiWoaDEUPDz4kSLnfK5i208Fc53I_1761921400 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/dd21df00e57a2947fff3a16f3fd07c9befdd218f Thanks. Kevin --- >From dd21df00e57a2947fff3a16f3fd07c9befdd218f Mon Sep 17 00:00:00 2001 From: Maayan Kashani Date: Thu, 7 Aug 2025 12:12:47 +0300 Subject: [PATCH] net/mlx5: fix unsupported flow rule port action [ upstream commit c040e9a85a1fbce46528e9bc15d1ce4bbc911346 ] When dv_flow_en=2, the port ID action is not supported. Although a rule can be created successfully in non-template mode, the specified action will be silently ignored and not applied. To prevent this ambiguous behavior, explicitly return an error when a port ID action is used with dv_flow_en=2, and recommend using a represented port action instead. Fixes: f1fecffa88df ("net/mlx5: support Direct Rules action template API") Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski Acked-by: Ivan Malov --- drivers/net/mlx5/mlx5_flow_hw.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 56d9504cb3..370f0374d6 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -2873,4 +2873,8 @@ __flow_hw_translate_actions_template(struct rte_eth_dev *dev, actions_end = true; break; + case RTE_FLOW_ACTION_TYPE_PORT_ID: + DRV_LOG(ERR, "RTE_FLOW_ACTION_TYPE_PORT_ID action is not supported. " + "Use RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT instead."); + goto err; default: break; @@ -7530,4 +7534,8 @@ flow_hw_parse_flow_actions_to_dr_actions(struct rte_eth_dev *dev, action_types[curr_off++] = MLX5DR_ACTION_TYP_JUMP_TO_MATCHER; break; + case RTE_FLOW_ACTION_TYPE_PORT_ID: + DRV_LOG(ERR, "RTE_FLOW_ACTION_TYPE_PORT_ID action is not supported. " + "Use RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT instead."); + return -EINVAL; default: type = mlx5_hw_dr_action_types[at->actions[i].type]; -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:53.346450018 +0000 +++ 0035-net-mlx5-fix-unsupported-flow-rule-port-action.patch 2025-10-31 13:53:52.087523527 +0000 @@ -1 +1 @@ -From c040e9a85a1fbce46528e9bc15d1ce4bbc911346 Mon Sep 17 00:00:00 2001 +From dd21df00e57a2947fff3a16f3fd07c9befdd218f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c040e9a85a1fbce46528e9bc15d1ce4bbc911346 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -21,2 +22,2 @@ - drivers/net/mlx5/mlx5_flow_hw.c | 10 +++++++++- - 1 file changed, 9 insertions(+), 1 deletion(-) + drivers/net/mlx5/mlx5_flow_hw.c | 8 ++++++++ + 1 file changed, 8 insertions(+) @@ -25 +26 @@ -index 016370f68b..0c3f554479 100644 +index 56d9504cb3..370f0374d6 100644 @@ -28 +29 @@ -@@ -2914,4 +2914,8 @@ __flow_hw_translate_actions_template(struct rte_eth_dev *dev, +@@ -2873,4 +2873,8 @@ __flow_hw_translate_actions_template(struct rte_eth_dev *dev, @@ -37,5 +38,3 @@ -@@ -7649,5 +7653,9 @@ flow_hw_parse_flow_actions_to_dr_actions(struct rte_eth_dev *dev, - at->dr_off[i] = curr_off; - action_types[curr_off++] = MLX5DR_ACTION_TYP_DEST_ARRAY; -- break; -+ break; +@@ -7530,4 +7534,8 @@ flow_hw_parse_flow_actions_to_dr_actions(struct rte_eth_dev *dev, + action_types[curr_off++] = MLX5DR_ACTION_TYP_JUMP_TO_MATCHER; + break;