From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2DE0948A44 for ; Fri, 31 Oct 2025 15:35:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 26BC640655; Fri, 31 Oct 2025 15:35:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 85DAF40652 for ; Fri, 31 Oct 2025 15:35:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sHd/UQRWW59GfRt8ZYnPJ7vsNaWU8NYboBn0WZyPqeE=; b=TzZYS729Die6YadCp0ocuKWs0LuCfUWHbM7Ck3FxHw6fKRKo58zFqvXbBe81b4Fp+K3hZN qv6c8aofgLwAJhHIXq6gpzNB7ncSvLMkRqqhzQoGo9n97gBeCGRG6dE5QxG1tR19RvRo3F 7ETuyzTvEKnwZylJqY7DUvVP4MXZqtk= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-ziQtbojVNPmeat8L2ZBq2w-1; Fri, 31 Oct 2025 10:35:23 -0400 X-MC-Unique: ziQtbojVNPmeat8L2ZBq2w-1 X-Mimecast-MFC-AGG-ID: ziQtbojVNPmeat8L2ZBq2w_1761921322 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CAC291954B06; Fri, 31 Oct 2025 14:35:22 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 20DDA18004D4; Fri, 31 Oct 2025 14:35:20 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Chengwen Feng , dpdk stable Subject: patch 'tailq: fix lookup macro' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:06 +0000 Message-ID: <20251031143421.324432-4-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MgFz9GrthqhyFy3yTxhsRImLZ5KM2z0qPTLqWp1-2io_1761921322 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/87b15f2e91f310e188a79baa64aafb5a64363975 Thanks. Kevin --- >From 87b15f2e91f310e188a79baa64aafb5a64363975 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Mon, 3 Feb 2025 17:09:54 +0100 Subject: [PATCH] tailq: fix lookup macro [ upstream commit 5d2d4033abe5bb17f6e328fad1a615553573abd5 ] Doing arithmetic with the NULL pointer is undefined. Caught by UBSan: ../app/test/test_tailq.c:111:9: runtime error: member access within null pointer of type 'struct rte_tailq_head' Fixes: f6b4f6c9c123 ("tailq: use a single cast macro") Signed-off-by: David Marchand Acked-by: Chengwen Feng --- lib/eal/include/rte_tailq.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/eal/include/rte_tailq.h b/lib/eal/include/rte_tailq.h index 89f7ef2134..e7caed6812 100644 --- a/lib/eal/include/rte_tailq.h +++ b/lib/eal/include/rte_tailq.h @@ -70,9 +70,10 @@ struct rte_tailq_elem { * The return value from rte_eal_tailq_lookup, typecast to the appropriate * structure pointer type. - * NULL on error, since the tailq_head is the first - * element in the rte_tailq_head structure. + * NULL on error. */ -#define RTE_TAILQ_LOOKUP(name, struct_name) \ - RTE_TAILQ_CAST(rte_eal_tailq_lookup(name), struct_name) +#define RTE_TAILQ_LOOKUP(name, struct_name) __extension__ ({ \ + struct rte_tailq_head *head = rte_eal_tailq_lookup(name); \ + head == NULL ? NULL : RTE_TAILQ_CAST(head, struct_name); \ +}) /** -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:52.438635181 +0000 +++ 0004-tailq-fix-lookup-macro.patch 2025-10-31 13:53:52.006239977 +0000 @@ -1 +1 @@ -From 5d2d4033abe5bb17f6e328fad1a615553573abd5 Mon Sep 17 00:00:00 2001 +From 87b15f2e91f310e188a79baa64aafb5a64363975 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 5d2d4033abe5bb17f6e328fad1a615553573abd5 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org