From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56EB748A44 for ; Fri, 31 Oct 2025 15:37:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4EB0440666; Fri, 31 Oct 2025 15:37:00 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5DFF14066E for ; Fri, 31 Oct 2025 15:36:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ooVMsDe/4Gp0Spn5kkDg2HhHtYiHOsiz+Op8/xmFPJ8=; b=M43f5f8Z6XMQMP3uJsVh1V255aoTU60NrXf7W+4/WZxnhdWG5M0Lb5qdSBFDHaznLV1ECx lMmIzEo0abHGfxJo285d9nuxsD3GA089VCkdGiFXXLDwCVrRijvWMleMbjLazqCWifXhDV Mrqlvrhbxbotu0H7YIlN93/jjIuwW0Y= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-9h3fPgDOMTiVkOgv2RxIAA-1; Fri, 31 Oct 2025 10:36:56 -0400 X-MC-Unique: 9h3fPgDOMTiVkOgv2RxIAA-1 X-Mimecast-MFC-AGG-ID: 9h3fPgDOMTiVkOgv2RxIAA_1761921415 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2DEE01801378; Fri, 31 Oct 2025 14:36:55 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 50565180044F; Fri, 31 Oct 2025 14:36:53 +0000 (UTC) From: Kevin Traynor To: Dariusz Sosnowski Cc: Bing Zhao , Raslan Darawsheh , dpdk stable Subject: patch 'net/mlx5: fix indirect flow age action handling' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:43 +0000 Message-ID: <20251031143421.324432-41-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: R8dFAvPmwNbg-r3bMAk2WDQd1tNxx0VGIxeMSWK7Ocs_1761921415 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/970baabf83153ae21c936341cd44068f3ebf9571 Thanks. Kevin --- >From 970baabf83153ae21c936341cd44068f3ebf9571 Mon Sep 17 00:00:00 2001 From: Dariusz Sosnowski Date: Tue, 19 Aug 2025 13:27:42 +0200 Subject: [PATCH] net/mlx5: fix indirect flow age action handling [ upstream commit 8bc72d9f277593f6d8b27278bad3a5bb92e7347f ] Indirect AGE flow actions can be created either through synchronous or asynchronous flow API. mlx5 PMD stores the queue used to create that action to support strict queueing. When action is created through synchronous API invalid queue index is stored instead. Whenever a flow rule is created with indirect AGE and direct COUNT flow actions, PMD allocates a HW counter for ageing that flow rule during rule creation. During allocation of the counter a queue index is needed to select a proper counter pool cache. In case when indirect AGE action created through synchronous API was used in that case, the associated queue index was used to select pool cache. Since queue index was invalid, PMD crashed. Counter can be allocated using the index of currently used queue and it does not have to match the queue used to create AGE action. This patch fixes the crash by using the index of currently used queue for counter allocation. This patch also adds missing validation for synchronous and asynchronous AGE flow action creation: - If strict queueing is disabled, only synchronous creation is allowed. - If strict queueing is enabled, only asynchronous creation is allowed. PMD documentation is updated accordingly. It also updates validation of synchronous query of aged flow rules in regards to strict queueing. When strict queueing is enabled, synchronous query is rejected. This aligns PMD behavior with API description. Fixes: 04a4de756e14 ("net/mlx5: support flow age action with HWS") Signed-off-by: Dariusz Sosnowski Acked-by: Bing Zhao Acked-by: Raslan Darawsheh --- doc/guides/nics/mlx5.rst | 4 ++++ drivers/net/mlx5/mlx5_flow_hw.c | 24 +++++++++++++++++------- 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index a826214e9f..b973617d9a 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -2223,4 +2223,8 @@ applications are allowed to: This option is supported only for Tx hairpin queues. +#. With strict queueing enabled + (``RTE_FLOW_PORT_FLAG_STRICT_QUEUE`` passed to ``rte_flow_configure()``), + indirect age actions can be created only through asynchronous flow API. + Notes for testpmd diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 2beb854a8b..e8a3473241 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -3140,4 +3140,5 @@ flow_hw_shared_action_construct(struct rte_eth_dev *dev, uint32_t queue, uint32_t idx = act_idx & ((1u << MLX5_INDIRECT_ACTION_TYPE_OFFSET) - 1); + uint32_t *cnt_queue; cnt_id_t age_cnt; @@ -3190,7 +3191,6 @@ flow_hw_shared_action_construct(struct rte_eth_dev *dev, uint32_t queue, return -1; if (action_flags & MLX5_FLOW_ACTION_COUNT) { - if (mlx5_hws_cnt_pool_get(priv->hws_cpool, - ¶m->queue_id, &age_cnt, - idx) < 0) + cnt_queue = mlx5_hws_cnt_get_queue(priv, &queue); + if (mlx5_hws_cnt_pool_get(priv->hws_cpool, cnt_queue, &age_cnt, idx) < 0) return -1; flow->flags |= MLX5_FLOW_HW_FLOW_FLAG_CNT_ID; @@ -12897,4 +12897,12 @@ flow_hw_action_create(struct rte_eth_dev *dev, struct rte_flow_error *err) { + struct mlx5_priv *priv = dev->data->dev_private; + + if (action->type == RTE_FLOW_ACTION_TYPE_AGE && priv->hws_strict_queue) { + rte_flow_error_set(err, EINVAL, RTE_FLOW_ERROR_TYPE_STATE, NULL, + "Cannot create age action synchronously with strict queueing"); + return NULL; + } + return flow_hw_action_handle_create(dev, MLX5_HW_INV_QUEUE, NULL, conf, action, NULL, err); @@ -13116,4 +13124,6 @@ flow_hw_get_q_aged_flows(struct rte_eth_dev *dev, uint32_t queue_id, NULL, "No aging initialized"); if (priv->hws_strict_queue) { + /* Queue is invalid in sync query. Sync query and strict queueing is disallowed. */ + MLX5_ASSERT(queue_id != MLX5_HW_INV_QUEUE); if (queue_id >= age_info->hw_q_age->nb_rings) return rte_flow_error_set(error, EINVAL, @@ -13169,8 +13179,8 @@ flow_hw_get_aged_flows(struct rte_eth_dev *dev, void **contexts, if (priv->hws_strict_queue) - DRV_LOG(WARNING, - "port %u get aged flows called in strict queue mode.", - dev->data->port_id); - return flow_hw_get_q_aged_flows(dev, 0, contexts, nb_contexts, error); + return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_STATE, NULL, + "Cannot get aged flows synchronously with strict queueing"); + + return flow_hw_get_q_aged_flows(dev, MLX5_HW_INV_QUEUE, contexts, nb_contexts, error); } /** -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:53.553651403 +0000 +++ 0041-net-mlx5-fix-indirect-flow-age-action-handling.patch 2025-10-31 13:53:52.129523658 +0000 @@ -1 +1 @@ -From 8bc72d9f277593f6d8b27278bad3a5bb92e7347f Mon Sep 17 00:00:00 2001 +From 970baabf83153ae21c936341cd44068f3ebf9571 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8bc72d9f277593f6d8b27278bad3a5bb92e7347f ] + @@ -42 +43,0 @@ -Cc: stable@dpdk.org @@ -53 +54 @@ -index 761dcad542..20056f61d6 100644 +index a826214e9f..b973617d9a 100644 @@ -56,2 +57,2 @@ -@@ -2741,4 +2741,8 @@ With :ref:`HW steering `, - - ``nb_aging_objects`` is the number of flow rules containing age action. +@@ -2223,4 +2223,8 @@ applications are allowed to: + This option is supported only for Tx hairpin queues. @@ -64 +65 @@ - .. _mlx5_quota: + Notes for testpmd @@ -66 +67 @@ -index 84f39c467e..c84ae726a7 100644 +index 2beb854a8b..e8a3473241 100644 @@ -69 +70 @@ -@@ -3181,4 +3181,5 @@ flow_hw_shared_action_construct(struct rte_eth_dev *dev, uint32_t queue, +@@ -3140,4 +3140,5 @@ flow_hw_shared_action_construct(struct rte_eth_dev *dev, uint32_t queue, @@ -75 +76 @@ -@@ -3231,7 +3232,6 @@ flow_hw_shared_action_construct(struct rte_eth_dev *dev, uint32_t queue, +@@ -3190,7 +3191,6 @@ flow_hw_shared_action_construct(struct rte_eth_dev *dev, uint32_t queue, @@ -85 +86 @@ -@@ -13143,4 +13143,12 @@ flow_hw_action_create(struct rte_eth_dev *dev, +@@ -12897,4 +12897,12 @@ flow_hw_action_create(struct rte_eth_dev *dev, @@ -98 +99 @@ -@@ -13362,4 +13370,6 @@ flow_hw_get_q_aged_flows(struct rte_eth_dev *dev, uint32_t queue_id, +@@ -13116,4 +13124,6 @@ flow_hw_get_q_aged_flows(struct rte_eth_dev *dev, uint32_t queue_id, @@ -105 +106 @@ -@@ -13415,8 +13425,8 @@ flow_hw_get_aged_flows(struct rte_eth_dev *dev, void **contexts, +@@ -13169,8 +13179,8 @@ flow_hw_get_aged_flows(struct rte_eth_dev *dev, void **contexts,