From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 781D848A44 for ; Fri, 31 Oct 2025 15:37:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71AAD40666; Fri, 31 Oct 2025 15:37:04 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 2F0A940150 for ; Fri, 31 Oct 2025 15:37:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qMnE1y5RLvU7EJtn6Ku9bUumWdiEqjv+GEN1tvlvTi8=; b=QHz1JFYFn2YPyX1fn+AiLwqcYQVwpMs7453KPJ9OZFvZjKrE1VsfPmgXmmn+2E8lpPZr/D vs5+L5jarYuvfTMmOlW48br+sHEX20sD+4puEhHw8RKVgBljkfJW8EKsz+LRf+FiDSqnfw 0qPPgKq2OVG/13WDEPx/IN/dCS4jB9c= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-37-l5ohbmQuOWGFUA7_fAueQA-1; Fri, 31 Oct 2025 10:36:58 -0400 X-MC-Unique: l5ohbmQuOWGFUA7_fAueQA-1 X-Mimecast-MFC-AGG-ID: l5ohbmQuOWGFUA7_fAueQA_1761921417 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6B637180035A; Fri, 31 Oct 2025 14:36:57 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BFD041800579; Fri, 31 Oct 2025 14:36:55 +0000 (UTC) From: Kevin Traynor To: Dariusz Sosnowski Cc: Andre Muezerie , dpdk stable Subject: patch 'net/mlx5: fix Direct Verbs counter offset detection' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:44 +0000 Message-ID: <20251031143421.324432-42-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LY1QTdDykt0oHhlVeydgNSIaPcO3F2okGK5Qb2EzsmE_1761921417 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/f96746df0877038b3473fbbb36721a7995c7629f Thanks. Kevin --- >From f96746df0877038b3473fbbb36721a7995c7629f Mon Sep 17 00:00:00 2001 From: Dariusz Sosnowski Date: Wed, 20 Aug 2025 10:45:21 +0200 Subject: [PATCH] net/mlx5: fix Direct Verbs counter offset detection [ upstream commit d953431da8e1ece042e33ba71650a3ba6b1e27c1 ] This patch fixes a bug in mlx5_flow_dv_discover_counter_offset_support() uncovered by a warning reported by MSVC: ../drivers/net/mlx5/mlx5_flow_dv.c(19636): warning C5287: operands are different enum types 'ibv_flow_attr_type' and 'ibv_flow_flags'; use an explicit cast to silence this warning IBV_FLOW_ATTR_FLAGS_EGRESS was incorrectly passed in to type field of mlx5dv_flow_matcher_attr struct, instead of flags field. As a result counter offset support discovery returned a false positive result on application with old rdma-core. Bugzilla ID: 1758 Fixes: 4fd5e1484887 ("net/mlx5: fix counter offset detection") Reported-by: Andre Muezerie Signed-off-by: Dariusz Sosnowski Acked-by: Andre Muezerie --- drivers/net/mlx5/mlx5_flow_dv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 74391faf11..b9b1a34dab 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -19644,5 +19644,6 @@ mlx5_flow_dv_discover_counter_offset_support(struct rte_eth_dev *dev) }; struct mlx5dv_flow_matcher_attr dv_attr = { - .type = IBV_FLOW_ATTR_NORMAL | IBV_FLOW_ATTR_FLAGS_EGRESS, + .type = IBV_FLOW_ATTR_NORMAL, + .flags = IBV_FLOW_ATTR_FLAGS_EGRESS, .priority = 0, .match_criteria_enable = 0, -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:53.590901361 +0000 +++ 0042-net-mlx5-fix-Direct-Verbs-counter-offset-detection.patch 2025-10-31 13:53:52.137523684 +0000 @@ -1 +1 @@ -From d953431da8e1ece042e33ba71650a3ba6b1e27c1 Mon Sep 17 00:00:00 2001 +From f96746df0877038b3473fbbb36721a7995c7629f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d953431da8e1ece042e33ba71650a3ba6b1e27c1 ] + @@ -23 +24,0 @@ -Cc: stable@dpdk.org @@ -33 +34 @@ -index f673637e7d..abfd54da1a 100644 +index 74391faf11..b9b1a34dab 100644 @@ -36 +37 @@ -@@ -19658,5 +19658,6 @@ mlx5_flow_dv_discover_counter_offset_support(struct rte_eth_dev *dev) +@@ -19644,5 +19644,6 @@ mlx5_flow_dv_discover_counter_offset_support(struct rte_eth_dev *dev)