From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5E6E48A44 for ; Fri, 31 Oct 2025 15:37:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F6FB4066F; Fri, 31 Oct 2025 15:37:07 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C37B24066F for ; Fri, 31 Oct 2025 15:37:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kvLmgNmgTeSq0vCYdM3wpIIiZwajS6hdgCQc6U4JOuY=; b=ARllwh8mgF1aj3d6qmpnLPTiHkBWgiHoC2OE9obgW2Z3yGvx9H8BGrqRT0wJr2Af8b1Aqg KsUDVu8GSJTwUaoZkH0ZN71JDjEo6Z9Xus+3k5Q3w9H0z1hjJf0XVH20ksUDLrBuiSfvcY 5tawLTSwF6JXGPXMdVCrSMkRvkqhmVA= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-Wn__qEOKNkiNbR-iF_as5w-1; Fri, 31 Oct 2025 10:37:03 -0400 X-MC-Unique: Wn__qEOKNkiNbR-iF_as5w-1 X-Mimecast-MFC-AGG-ID: Wn__qEOKNkiNbR-iF_as5w_1761921422 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E89CA19560A3; Fri, 31 Oct 2025 14:37:01 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6635D18004D4; Fri, 31 Oct 2025 14:36:59 +0000 (UTC) From: Kevin Traynor To: Ciara Loftus Cc: Bruce Richardson , dpdk stable Subject: patch 'net/iavf: fix Tx vector path selection logic' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:46 +0000 Message-ID: <20251031143421.324432-44-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gV-BzGKuHyruPsJW-XyGONjr1k0PqOYUaRLq1cbNEz0_1761921422 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/65960ba2bcfa95c69dd96a921a690cf932617065 Thanks. Kevin --- >From 65960ba2bcfa95c69dd96a921a690cf932617065 Mon Sep 17 00:00:00 2001 From: Ciara Loftus Date: Thu, 19 Jun 2025 13:36:57 +0000 Subject: [PATCH] net/iavf: fix Tx vector path selection logic [ upstream commit ecdccc79cf3296bb3cb6d53d87ad85d13828677b ] Prior to this change, it was possible the scalar path would be selected even if the AVX-512 path was available. This was due to the ordering of the logic in the iavf_set_tx_function function. Support for all three vector paths (sse, AVX2 and AVX-512) was first established and then in that order, the tx_burst_type was set to the appropriate type. If all three paths were supported, then the burst type would be first set to sse, then AVX2 then AVX-512. However, in the AVX2 logic, if an error was encountered then the burst type was set to a fallback option of the scalar path. This is not desired behaviour because the AVX-512 path should be selected over the scalar path when it is available. This commit fixes this issue by only checking for AVX2 support after deeming that AVX-512 is not supported. Fixes: 77b19d1d4b2e ("net/iavf: fix mbuf release path selection") Signed-off-by: Ciara Loftus Acked-by: Bruce Richardson --- drivers/net/iavf/iavf_rxtx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 0ffb9762fe..cce4917a3f 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -4163,8 +4163,4 @@ iavf_set_tx_function(struct rte_eth_dev *dev) use_sse = true; } - if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 || - rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1) && - rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_256) - use_avx2 = true; #ifdef CC_AVX512_SUPPORT if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1 && @@ -4173,4 +4169,8 @@ iavf_set_tx_function(struct rte_eth_dev *dev) use_avx512 = true; #endif + if (!use_avx512 && (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 || + rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1) && + rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_256) + use_avx2 = true; if (!use_sse && !use_avx2 && !use_avx512) -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:53.651769346 +0000 +++ 0044-net-iavf-fix-Tx-vector-path-selection-logic.patch 2025-10-31 13:53:52.142523699 +0000 @@ -1 +1 @@ -From ecdccc79cf3296bb3cb6d53d87ad85d13828677b Mon Sep 17 00:00:00 2001 +From 65960ba2bcfa95c69dd96a921a690cf932617065 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ecdccc79cf3296bb3cb6d53d87ad85d13828677b ] + @@ -21 +22,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ - drivers/net/intel/iavf/iavf_rxtx.c | 8 ++++---- + drivers/net/iavf/iavf_rxtx.c | 8 ++++---- @@ -29,5 +30,5 @@ -diff --git a/drivers/net/intel/iavf/iavf_rxtx.c b/drivers/net/intel/iavf/iavf_rxtx.c -index 740876756b..5f5e3f047a 100644 ---- a/drivers/net/intel/iavf/iavf_rxtx.c -+++ b/drivers/net/intel/iavf/iavf_rxtx.c -@@ -4228,8 +4228,4 @@ iavf_set_tx_function(struct rte_eth_dev *dev) +diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c +index 0ffb9762fe..cce4917a3f 100644 +--- a/drivers/net/iavf/iavf_rxtx.c ++++ b/drivers/net/iavf/iavf_rxtx.c +@@ -4163,8 +4163,4 @@ iavf_set_tx_function(struct rte_eth_dev *dev) @@ -42 +43 @@ -@@ -4238,4 +4234,8 @@ iavf_set_tx_function(struct rte_eth_dev *dev) +@@ -4173,4 +4169,8 @@ iavf_set_tx_function(struct rte_eth_dev *dev)