From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18EF748A44 for ; Fri, 31 Oct 2025 15:37:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1244140150; Fri, 31 Oct 2025 15:37:18 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9D8304066F for ; Fri, 31 Oct 2025 15:37:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nl7ExFFxNm5Vqmpu6fN16K02oQLJVKl+4vsHPZfsbWo=; b=fvlESM7QHPUVIFeRRgVYvqFMWRru2Uel5qiOS377EpwzalsDg7/IGF5dglqmffGSNvETgX wd/SsTmjxCFf/Gv1kTSzWG88RkkjYZfJ5/gdRVrMBvQNfEaB0T0Gcnk0uWs/Nkwf/IKhZ+ Q5bCgxPaTvIgJfpb4pDUzyC4hVI+ro8= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-6DmSh9mdPOO1jfqDGqE7QA-1; Fri, 31 Oct 2025 10:37:14 -0400 X-MC-Unique: 6DmSh9mdPOO1jfqDGqE7QA-1 X-Mimecast-MFC-AGG-ID: 6DmSh9mdPOO1jfqDGqE7QA_1761921433 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CACE4195607F; Fri, 31 Oct 2025 14:37:13 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EBA4F180044F; Fri, 31 Oct 2025 14:37:11 +0000 (UTC) From: Kevin Traynor To: Jacob Keller Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/ice/base: fix memory leak in HW profile handling' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:51 +0000 Message-ID: <20251031143421.324432-49-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wCblUOWagwnA6nZdQcdRTpdcf-xjkUxL5UK7FC2yxG0_1761921433 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/3299f7369aee0798ef289d82bc9fd43288f5b85a Thanks. Kevin --- >From 3299f7369aee0798ef289d82bc9fd43288f5b85a Mon Sep 17 00:00:00 2001 From: Jacob Keller Date: Tue, 2 Sep 2025 18:26:53 +0100 Subject: [PATCH] net/ice/base: fix memory leak in HW profile handling [ upstream commit bce22ae3a0e61134b5fd19498bd849d1693dadb4 ] The ice_flow_set_hw_prof() function allocates a params structure with ice_malloc. It uses this structure to hold some data temporarily while processing the hardware profile to set. Static analysis indicated that this memory is not released. Fix this function to free the memory upon exit. Fixes: 8ebb93942b2c ("net/ice/base: add function to set HW profile for raw flow") Signed-off-by: Jacob Keller Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/ice/base/ice_flow.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c index 0d64a5bb1e..2b0567976b 100644 --- a/drivers/net/ice/base/ice_flow.c +++ b/drivers/net/ice/base/ice_flow.c @@ -2628,8 +2628,4 @@ ice_flow_set_hw_prof(struct ice_hw *hw, u16 dest_vsi_handle, status = ice_flow_assoc_hw_prof(hw, blk, dest_vsi_handle, fdir_vsi_handle, id); - if (status) - goto free_params; - - return 0; free_params: -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:53.804843436 +0000 +++ 0049-net-ice-base-fix-memory-leak-in-HW-profile-handling.patch 2025-10-31 13:53:52.158523749 +0000 @@ -1 +1 @@ -From bce22ae3a0e61134b5fd19498bd849d1693dadb4 Mon Sep 17 00:00:00 2001 +From 3299f7369aee0798ef289d82bc9fd43288f5b85a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit bce22ae3a0e61134b5fd19498bd849d1693dadb4 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ - drivers/net/intel/ice/base/ice_flow.c | 4 ---- + drivers/net/ice/base/ice_flow.c | 4 ---- @@ -23,5 +24,5 @@ -diff --git a/drivers/net/intel/ice/base/ice_flow.c b/drivers/net/intel/ice/base/ice_flow.c -index cdc9ee26c5..7b0ecd54df 100644 ---- a/drivers/net/intel/ice/base/ice_flow.c -+++ b/drivers/net/intel/ice/base/ice_flow.c -@@ -2633,8 +2633,4 @@ ice_flow_set_hw_prof(struct ice_hw *hw, u16 dest_vsi_handle, +diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c +index 0d64a5bb1e..2b0567976b 100644 +--- a/drivers/net/ice/base/ice_flow.c ++++ b/drivers/net/ice/base/ice_flow.c +@@ -2628,8 +2628,4 @@ ice_flow_set_hw_prof(struct ice_hw *hw, u16 dest_vsi_handle,