From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65AC748A44 for ; Fri, 31 Oct 2025 15:35:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5ED7540655; Fri, 31 Oct 2025 15:35:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2088440655 for ; Fri, 31 Oct 2025 15:35:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x0YCspkcCVgsRD7hD2aBOJoTtluy79CugXsMjISZtcA=; b=NRc43fYUWk9Hx6/5USziYDbDZ8gUdEsIe6ttRsbCgHAJmBGmFevvTRUADZl/uDEw7eym4v xr4izw1uzVpmmDvI/WSEqoNmydRzijtjza78V3UB7JK9VoN1VSHwlDAa1cOsyypzV1qFkB kM+GHBnQS7b1n9+RMGpRIGXf4Cok430= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-304-AL1lx_ZVNhCrN_05xe74og-1; Fri, 31 Oct 2025 10:35:27 -0400 X-MC-Unique: AL1lx_ZVNhCrN_05xe74og-1 X-Mimecast-MFC-AGG-ID: AL1lx_ZVNhCrN_05xe74og_1761921326 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 337101954B0C; Fri, 31 Oct 2025 14:35:26 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6724518004D4; Fri, 31 Oct 2025 14:35:23 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Bruce Richardson , Vladimir Medvedkin , Konstantin Ananyev , Chengwen Feng , dpdk stable Subject: patch 'hash: fix unaligned access in predictable RSS' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:07 +0000 Message-ID: <20251031143421.324432-5-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wp2F4Alt1when7EOOdIx1eL4ULBjRB_G_0NRx-InnYs_1761921326 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/57b8004f0c80c54aa6184a9c816c13b269eaaef2 Thanks. Kevin --- >From 57b8004f0c80c54aa6184a9c816c13b269eaaef2 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 18 Jun 2025 17:33:38 +0200 Subject: [PATCH] hash: fix unaligned access in predictable RSS [ upstream commit b70d04d8ac6d47b221500d418df1de2b2c65b50a ] Caught by UBSan: ../lib/hash/rte_thash.c:421:8: runtime error: load of misaligned address 0x0001816c2da3 for type 'uint32_t' (aka 'unsigned int'), which requires 4 byte alignment Fixes: 28ebff11c2dc ("hash: add predictable RSS") Signed-off-by: David Marchand Acked-by: Bruce Richardson Acked-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev Acked-by: Chengwen Feng --- lib/hash/rte_thash.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c index 336c228e64..b8c0910a45 100644 --- a/lib/hash/rte_thash.c +++ b/lib/hash/rte_thash.c @@ -410,8 +410,8 @@ static inline uint32_t get_subvalue(struct rte_thash_ctx *ctx, uint32_t offset) { - uint32_t *tmp, val; + uint32_t tmp, val; - tmp = (uint32_t *)(&ctx->hash_key[offset >> 3]); - val = rte_be_to_cpu_32(*tmp); + tmp = *(unaligned_uint32_t *)&ctx->hash_key[offset >> 3]; + val = rte_be_to_cpu_32(tmp); val >>= (TOEPLITZ_HASH_LEN - ((offset & (CHAR_BIT - 1)) + ctx->reta_sz_log)); -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:52.465633512 +0000 +++ 0005-hash-fix-unaligned-access-in-predictable-RSS.patch 2025-10-31 13:53:52.006523275 +0000 @@ -1 +1 @@ -From b70d04d8ac6d47b221500d418df1de2b2c65b50a Mon Sep 17 00:00:00 2001 +From 57b8004f0c80c54aa6184a9c816c13b269eaaef2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b70d04d8ac6d47b221500d418df1de2b2c65b50a ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 6c662bf14f..0f9ed20d0d 100644 +index 336c228e64..b8c0910a45 100644 @@ -28 +29 @@ -@@ -416,8 +416,8 @@ static inline uint32_t +@@ -410,8 +410,8 @@ static inline uint32_t