From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 513B048A44 for ; Fri, 31 Oct 2025 15:37:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 48A1C40150; Fri, 31 Oct 2025 15:37:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4082A40150 for ; Fri, 31 Oct 2025 15:37:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qg6G5bJLkzP3uzaCyKZkbu//ygzmFpakWkZMcKqx44s=; b=F3ddkjN/MxM8PyzTFgsM8ixzKUPs/unFOBLGCFgdXLZ2adWKl9IYMryEGNNtxECPeJ2/HA Y92sabnPxuXp60hTJrTlyfKq3ZhjI2CrE+9oG+68H1dOLD4miBN4D2CLayQkUjwRjS3+rv J7drtTgRuIt8qDtm9obdnZr/s0Rk4oU= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-352-DidKVBq8N12clMUPMTI6KQ-1; Fri, 31 Oct 2025 10:37:17 -0400 X-MC-Unique: DidKVBq8N12clMUPMTI6KQ-1 X-Mimecast-MFC-AGG-ID: DidKVBq8N12clMUPMTI6KQ_1761921436 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5A114195605C; Fri, 31 Oct 2025 14:37:16 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8044B18004D4; Fri, 31 Oct 2025 14:37:14 +0000 (UTC) From: Kevin Traynor To: Pandi Kumar Maharajan Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/ice/base: fix memory leak in recipe handling' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:52 +0000 Message-ID: <20251031143421.324432-50-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5g--Usmjep8R_aDt-hF90cnz_sgMJbN5pcNpTYDdNLg_1761921436 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/b2843e855325a5f436f89eaada998bc1a3e2bae1 Thanks. Kevin --- >From b2843e855325a5f436f89eaada998bc1a3e2bae1 Mon Sep 17 00:00:00 2001 From: Pandi Kumar Maharajan Date: Tue, 2 Sep 2025 18:26:54 +0100 Subject: [PATCH] net/ice/base: fix memory leak in recipe handling [ upstream commit baf3de23be970346378d5159a81782bfb6eb927b ] Advanced filter operations (apply/remove GENEVE/VXLAN filters) trigger the call chain: ice_add_adv_rule()/ice_rem_adv_rule() -> ice_find_recp() -> ice_get_recp_frm_fw(). Each call to ice_get_recp_frm_fw() creates new linked list entries for SW recipe tracking without cleaning up previous entries for the same recipe ID. The linked list then continuously grows with each filter add/remove operation, leading to excessive heap usage over time. Fix the memory leak by adding logic to remove the duplicate entries before adding new ones for the same recipe ID. Fixes: fed0c5ca5f19 ("net/ice/base: support programming a new switch recipe") Signed-off-by: Pandi Kumar Maharajan Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/ice/base/ice_switch.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c index 65b97f6b11..51e0273a71 100644 --- a/drivers/net/ice/base/ice_switch.c +++ b/drivers/net/ice/base/ice_switch.c @@ -2436,4 +2436,5 @@ ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid, { ice_declare_bitmap(result_bm, ICE_MAX_FV_WORDS); + struct ice_recp_grp_entry *rg, *tmprg_entry; struct ice_aqc_recipe_data_elem *tmp; u16 num_recps = ICE_MAX_NUM_RECIPES; @@ -2482,4 +2483,13 @@ ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid, lkup_exts = &recps[rid].lkup_exts; + /* Remove duplicate entries */ + LIST_FOR_EACH_ENTRY_SAFE(rg, tmprg_entry, &recps[rid].rg_list, + ice_recp_grp_entry, l_entry) { + if (rg->rid == rid) { + LIST_DEL(&rg->l_entry); + ice_free(hw, rg); + } + } + for (sub_recps = 0; sub_recps < num_recps; sub_recps++) { struct ice_aqc_recipe_data_elem root_bufs = tmp[sub_recps]; -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:53.836284606 +0000 +++ 0050-net-ice-base-fix-memory-leak-in-recipe-handling.patch 2025-10-31 13:53:52.161523758 +0000 @@ -1 +1 @@ -From baf3de23be970346378d5159a81782bfb6eb927b Mon Sep 17 00:00:00 2001 +From b2843e855325a5f436f89eaada998bc1a3e2bae1 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit baf3de23be970346378d5159a81782bfb6eb927b ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ - drivers/net/intel/ice/base/ice_switch.c | 10 ++++++++++ + drivers/net/ice/base/ice_switch.c | 10 ++++++++++ @@ -27,4 +28,4 @@ -diff --git a/drivers/net/intel/ice/base/ice_switch.c b/drivers/net/intel/ice/base/ice_switch.c -index f16bec044c..628473f100 100644 ---- a/drivers/net/intel/ice/base/ice_switch.c -+++ b/drivers/net/intel/ice/base/ice_switch.c +diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c +index 65b97f6b11..51e0273a71 100644 +--- a/drivers/net/ice/base/ice_switch.c ++++ b/drivers/net/ice/base/ice_switch.c