From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 991D948A44 for ; Fri, 31 Oct 2025 15:37:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91D4E40150; Fri, 31 Oct 2025 15:37:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 185A140150 for ; Fri, 31 Oct 2025 15:37:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MVvBnelEmjD2PnTkby1J0yZEGwMitDZrDzMiY7NXbFY=; b=ZqSk0ucD39mpOeL+oeAswuHEQ+cHGFYe+79xoqg00A1WZtpjVYcg0bzbBiWal8e4bSFhll ko9trRM68JqK9KVAvhjmdl1y8WXjqXgI80Rx41zPNOADof5DuNV6uf2bBoKGTyNDoHmR71 kYkv0gKN02U3j4slVUhyTQ6FYjs0ONE= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-259-YpevMK-2PgKkqsBgls3z5A-1; Fri, 31 Oct 2025 10:37:21 -0400 X-MC-Unique: YpevMK-2PgKkqsBgls3z5A-1 X-Mimecast-MFC-AGG-ID: YpevMK-2PgKkqsBgls3z5A_1761921440 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BC5451956095; Fri, 31 Oct 2025 14:37:20 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 210CC180044F; Fri, 31 Oct 2025 14:37:18 +0000 (UTC) From: Kevin Traynor To: Shani Peretz Cc: Anatoly Burakov , dpdk stable Subject: patch 'eal: fix DMA mask validation with IOVA mode option' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:54 +0000 Message-ID: <20251031143421.324432-52-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bo_Qxsqa-_pa3r2bAQz5b16IanHyOZU6AcZsaI1i0Q4_1761921440 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/8597047cd39667481454b9d5b0264ad4c9689b3c Thanks. Kevin --- >From 8597047cd39667481454b9d5b0264ad4c9689b3c Mon Sep 17 00:00:00 2001 From: Shani Peretz Date: Thu, 18 Sep 2025 09:47:54 +0300 Subject: [PATCH] eal: fix DMA mask validation with IOVA mode option [ upstream commit e37ff4ef296f33e4c3a0e9306241c4f8fcae5061 ] When --iova-mode is explicitly specified in command line, DMA mask constraints were not being validated, leading to potential runtime failures when device DMA capabilities are exceeded. The issue occurred because rte_bus_get_iommu_class() was only called during IOVA mode auto-detection, but this function has the important side effect of triggering DMA mask detection (e.g., Intel IOMMU address width checking via pci_device_iommu_support_va()). This created an inconsistency, when choosing explicit mode, the DMA checks are bypassed, but when choosing auto-detection mode, the constraints are checked and enforced. The fix moves rte_bus_get_iommu_class() outside the conditional logic to ensure it's always called during EAL initialization. Fixes: 4374ebc24bc1 ("malloc: modify error message for DMA mask check") Signed-off-by: Shani Peretz Acked-by: Anatoly Burakov --- lib/eal/freebsd/eal.c | 6 +++++- lib/eal/linux/eal.c | 5 ++++- lib/eal/windows/eal.c | 5 ++++- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 2cb693a90b..92d0b6be62 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -666,4 +666,8 @@ rte_eal_init(int argc, char **argv) */ has_phys_addr = internal_conf->no_hugetlbfs == 0; + + /* Always call rte_bus_get_iommu_class() to trigger DMA mask detection and validation */ + enum rte_iova_mode bus_iova_mode = rte_bus_get_iommu_class(); + iova_mode = internal_conf->iova_mode; if (iova_mode == RTE_IOVA_DC) { @@ -671,5 +675,5 @@ rte_eal_init(int argc, char **argv) if (has_phys_addr) { EAL_LOG(DEBUG, "Selecting IOVA mode according to bus requests"); - iova_mode = rte_bus_get_iommu_class(); + iova_mode = bus_iova_mode; if (iova_mode == RTE_IOVA_DC) { if (!RTE_IOVA_IN_MBUF) { diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index a13d8f559a..a0111b50b9 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -1032,8 +1032,11 @@ rte_eal_init(int argc, char **argv) phys_addrs = rte_eal_using_phys_addrs() != 0; + /* Always call rte_bus_get_iommu_class() to trigger DMA mask detection and validation */ + enum rte_iova_mode bus_iova_mode = rte_bus_get_iommu_class(); + /* if no EAL option "--iova-mode=", use bus IOVA scheme */ if (internal_conf->iova_mode == RTE_IOVA_DC) { /* autodetect the IOVA mapping mode */ - enum rte_iova_mode iova_mode = rte_bus_get_iommu_class(); + enum rte_iova_mode iova_mode = bus_iova_mode; if (iova_mode == RTE_IOVA_DC) { diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c index 5c7526f922..eb9fc302de 100644 --- a/lib/eal/windows/eal.c +++ b/lib/eal/windows/eal.c @@ -340,4 +340,7 @@ rte_eal_init(int argc, char **argv) } + /* Always call rte_bus_get_iommu_class() to trigger DMA mask detection and validation */ + enum rte_iova_mode bus_iova_mode = rte_bus_get_iommu_class(); + iova_mode = internal_conf->iova_mode; if (iova_mode == RTE_IOVA_DC) { @@ -345,5 +348,5 @@ rte_eal_init(int argc, char **argv) if (has_phys_addr) { EAL_LOG(DEBUG, "Selecting IOVA mode according to bus requests"); - iova_mode = rte_bus_get_iommu_class(); + iova_mode = bus_iova_mode; if (iova_mode == RTE_IOVA_DC) { if (!RTE_IOVA_IN_MBUF) { -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:53.891458715 +0000 +++ 0052-eal-fix-DMA-mask-validation-with-IOVA-mode-option.patch 2025-10-31 13:53:52.162523761 +0000 @@ -1 +1 @@ -From e37ff4ef296f33e4c3a0e9306241c4f8fcae5061 Mon Sep 17 00:00:00 2001 +From 8597047cd39667481454b9d5b0264ad4c9689b3c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit e37ff4ef296f33e4c3a0e9306241c4f8fcae5061 ] + @@ -23 +24,0 @@ -Cc: stable@dpdk.org @@ -34 +35 @@ -index c1ab8d86d2..0f957919d3 100644 +index 2cb693a90b..92d0b6be62 100644 @@ -37 +38 @@ -@@ -671,4 +671,8 @@ rte_eal_init(int argc, char **argv) +@@ -666,4 +666,8 @@ rte_eal_init(int argc, char **argv) @@ -46 +47 @@ -@@ -676,5 +680,5 @@ rte_eal_init(int argc, char **argv) +@@ -671,5 +675,5 @@ rte_eal_init(int argc, char **argv) @@ -54 +55 @@ -index 52efb8626b..3a0c9c9db6 100644 +index a13d8f559a..a0111b50b9 100644 @@ -57 +58 @@ -@@ -1043,8 +1043,11 @@ rte_eal_init(int argc, char **argv) +@@ -1032,8 +1032,11 @@ rte_eal_init(int argc, char **argv) @@ -71 +72 @@ -index 4f0a164d9b..2502ec3c3d 100644 +index 5c7526f922..eb9fc302de 100644 @@ -74 +75 @@ -@@ -349,4 +349,7 @@ rte_eal_init(int argc, char **argv) +@@ -340,4 +340,7 @@ rte_eal_init(int argc, char **argv) @@ -82 +83 @@ -@@ -354,5 +357,5 @@ rte_eal_init(int argc, char **argv) +@@ -345,5 +348,5 @@ rte_eal_init(int argc, char **argv)