From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D198448A44 for ; Fri, 31 Oct 2025 15:37:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C92B540677; Fri, 31 Oct 2025 15:37:30 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B1FBC40677 for ; Fri, 31 Oct 2025 15:37:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gbBqjD3LgBAAa90bHWb75At50Pd+ZHBU+BEXNDvZn3A=; b=H4tDrodgE3zxD5UrPyjHXF8MvzVhZRHd11vd0x0sybMpUokBj2laFvWNQnxe7p2XNKnLBA QRnT5yA+YL+Bv6SmzldGVzA3nbNkFja0fKI5+XvA8gcqJ7p+qO7iDoy7pZoYUVzRyULxoD q83k20KFNSptqFwuRcJeCsyTHqChubA= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-312-l9QZqxkoMSew31BwZdu2wA-1; Fri, 31 Oct 2025 10:37:26 -0400 X-MC-Unique: l9QZqxkoMSew31BwZdu2wA-1 X-Mimecast-MFC-AGG-ID: l9QZqxkoMSew31BwZdu2wA_1761921445 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3016D195606C; Fri, 31 Oct 2025 14:37:25 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 83467180044F; Fri, 31 Oct 2025 14:37:23 +0000 (UTC) From: Kevin Traynor To: Yang Ming Cc: Anatoly Burakov , dpdk stable Subject: patch 'crypto/ipsec_mb: fix QP release in secondary' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:56 +0000 Message-ID: <20251031143421.324432-54-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 47KimWGp8G_6JNz6HbmS9UHyoSq5fEBBgkjGRj5CX54_1761921445 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/ff46fb5d2cbf8aaa5636a1c5c7f1263324fc4cb5 the Thanks. Kevin --- >From ff46fb5d2cbf8aaa5636a1c5c7f1263324fc4cb5 Mon Sep 17 00:00:00 2001 From: Yang Ming Date: Sat, 19 Jul 2025 23:32:26 +0800 Subject: [PATCH] crypto/ipsec_mb: fix QP release in secondary [ upstream commit 0e03ab647d07cd985a7cac36cefff5195cc3a07d ] When a secondary process tries to release a queue pair (QP) that does not belong to it, error logs occur: CRYPTODEV: ipsec_mb_ipc_request() line 373: Unable to release qp_id=0 EAL: Message data is too long EAL: Fail to handle message: ipsec_mb_mp_msg EAL: Fail to recv reply for request /tmp/dpdk/l2hi/mp_socket: ipsec_mb_mp_msg >From the code path, cryptodev->data is allocated in the primary via rte_cryptodev_data_alloc() (inside ipsec_mb_create-->rte_cryptodev_pmd_create -->rte_cryptodev_pmd_allocate-->rte_cryptodev_data_alloc). This memory is placed in a shared memzone (rte_cryptodev_data_%u), so both primary and secondary processes reference the same cryptodev->data, including nb_queue_pairs and queue_pairs[]. As a result, when the secondary process exits, ipsec_mb_remove() is called (inside rte_eal_cleanup-->eal_bus_cleanup-->vdev_cleanup -->rte_vdev_driver-->ipsec_mb_remove-->ipsec_mb_qp_release -->ipsec_mb_secondary_qp_op) and it loops through all queue pairs using: for (qp_id = 0; qp_id < cryptodev->data->nb_queue_pairs; qp_id++) ipsec_mb_qp_release(cryptodev, qp_id); This causes the secondary to attempt releasing queue pairs it doesn't own, triggering the error logs mentioned above. This patch ensures that a secondary process only frees a QP if it actually owns it, preventing conflicts and resolving the issue. Fixes: b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request handler") Signed-off-by: Yang Ming Acked-by: Anatoly Burakov --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c index 910efb1a97..50ee140ccd 100644 --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c @@ -139,4 +139,5 @@ ipsec_mb_qp_release(struct rte_cryptodev *dev, uint16_t qp_id) { struct ipsec_mb_qp *qp = dev->data->queue_pairs[qp_id]; + uint16_t process_id = (uint16_t)getpid(); if (!qp) @@ -153,6 +154,8 @@ ipsec_mb_qp_release(struct rte_cryptodev *dev, uint16_t qp_id) dev->data->queue_pairs[qp_id] = NULL; } else { /* secondary process */ - return ipsec_mb_secondary_qp_op(dev->data->dev_id, qp_id, - NULL, 0, RTE_IPSEC_MB_MP_REQ_QP_FREE); + if (qp->qp_used_by_pid == process_id) + return ipsec_mb_secondary_qp_op(dev->data->dev_id, + qp_id, NULL, 0, + RTE_IPSEC_MB_MP_REQ_QP_FREE); } return 0; -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:53.946230481 +0000 +++ 0054-crypto-ipsec_mb-fix-QP-release-in-secondary.patch 2025-10-31 13:53:52.164523768 +0000 @@ -1 +1 @@ -From 0e03ab647d07cd985a7cac36cefff5195cc3a07d Mon Sep 17 00:00:00 2001 +From ff46fb5d2cbf8aaa5636a1c5c7f1263324fc4cb5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0e03ab647d07cd985a7cac36cefff5195cc3a07d ] + @@ -41 +42,0 @@ -Cc: stable@dpdk.org