From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFEC948A44 for ; Fri, 31 Oct 2025 15:37:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9FF340150; Fri, 31 Oct 2025 15:37:31 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A2A7D4066F for ; Fri, 31 Oct 2025 15:37:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wyANevDjHvAXGQwrqnDoNrz09c45Py5DF2/Ys1/zarg=; b=UkpXO7mZnVFdM4R2BIG3BD+r5nZtEHcn5Hk3V5KBoeO9BVsFC4S9fGSsqtr2saQQM6U+ty qF212nR3y0aDiDgcKoCWFanIdpJY5CWe7fcyZux955Cu8bP7fbLYFFX5GJTcUHT+ZY57Rn pFZxq1NE7wDAWYtAruW7bCx+xTDMqlw= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-380-4kYDrKvkMPC1e7jwCsdPew-1; Fri, 31 Oct 2025 10:37:28 -0400 X-MC-Unique: 4kYDrKvkMPC1e7jwCsdPew-1 X-Mimecast-MFC-AGG-ID: 4kYDrKvkMPC1e7jwCsdPew_1761921447 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9A4C219560A7; Fri, 31 Oct 2025 14:37:27 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 062E2180044F; Fri, 31 Oct 2025 14:37:25 +0000 (UTC) From: Kevin Traynor To: Thomas Monjalon Cc: Bruce Richardson , dpdk stable Subject: patch 'efd: fix AVX2 support' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:57 +0000 Message-ID: <20251031143421.324432-55-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FuZrB-tfi159ClZ4GhI1d3fwrqKb2PMfrDd813gI2dQ_1761921447 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/398ba9f7cc27bd6fe9f9553bc785b9e1a7a4eb89 Thanks. Kevin --- >From 398ba9f7cc27bd6fe9f9553bc785b9e1a7a4eb89 Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Thu, 18 Sep 2025 08:36:14 +0200 Subject: [PATCH] efd: fix AVX2 support [ upstream commit c367b9a07c55025eabe1dd6903f4b0f5c4c5d362 ] When switching to Meson build, the compilation check on CC_SUPPORT_AVX2 became obsolete, thus the case EFD_LOOKUP_AVX2 became dead. The function efd_lookup_internal_avx2() was never called, and its header include rte_efd_x86.h has been removed later. EFD_LOOKUP_AVX2 is chosen at runtime after checking AVX2 availability, so the obsolete build-time check for AVX2 can be simply removed, and the missing include added back. Fixes: 5b9656b157d3 ("lib: build with meson") Fixes: 30a1de105a5f ("lib: remove unneeded header includes") Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson --- lib/efd/rte_efd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c index 3cbb3c2719..3386958afb 100644 --- a/lib/efd/rte_efd.c +++ b/lib/efd/rte_efd.c @@ -26,4 +26,5 @@ #include "rte_efd.h" #if defined(RTE_ARCH_X86) +#include "rte_efd_x86.h" #elif defined(RTE_ARCH_ARM64) #include "rte_efd_arm64.h" @@ -1274,5 +1275,5 @@ efd_lookup_internal(const struct efd_online_group_entry * const group, switch (lookup_fn) { -#if defined(RTE_ARCH_X86) && defined(CC_SUPPORT_AVX2) +#if defined(RTE_ARCH_X86) case EFD_LOOKUP_AVX2: return efd_lookup_internal_avx2(group->hash_idx, -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:53.974513402 +0000 +++ 0055-efd-fix-AVX2-support.patch 2025-10-31 13:53:52.165511074 +0000 @@ -1 +1 @@ -From c367b9a07c55025eabe1dd6903f4b0f5c4c5d362 Mon Sep 17 00:00:00 2001 +From 398ba9f7cc27bd6fe9f9553bc785b9e1a7a4eb89 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c367b9a07c55025eabe1dd6903f4b0f5c4c5d362 ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index b0e44e5c51..ebf1e0655f 100644 +index 3cbb3c2719..3386958afb 100644 @@ -29 +30 @@ -@@ -27,4 +27,5 @@ +@@ -26,4 +26,5 @@ @@ -35 +36 @@ -@@ -1280,5 +1281,5 @@ efd_lookup_internal(const struct efd_online_group_entry * const group, +@@ -1274,5 +1275,5 @@ efd_lookup_internal(const struct efd_online_group_entry * const group,