From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 348B148A44 for ; Fri, 31 Oct 2025 15:37:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DD9740150; Fri, 31 Oct 2025 15:37:58 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A795540150 for ; Fri, 31 Oct 2025 15:37:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TlGtxml43q7SHfHcuUGSo+R9dP2262+nL/CwayF/SXc=; b=iu+DaLLVruFd8iX5+cCPjkXzy5eyyAm76FPMZrn+NDSTckgeFYKP7olM6BUHgjDFj04ncY pWRZR0p4ug2kpulW0H7n/LEVqp/SgSIcPfhe7UqaDIpDeMidUeMjEJcueIXjskfoQxFkfg eheOuzNS1qqk3Ctl4TrPSFzfBo6hcps= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-37-k_bFFWuuMc-Ss51o4fZ9Nw-1; Fri, 31 Oct 2025 10:37:52 -0400 X-MC-Unique: k_bFFWuuMc-Ss51o4fZ9Nw-1 X-Mimecast-MFC-AGG-ID: k_bFFWuuMc-Ss51o4fZ9Nw_1761921470 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 77D701956070; Fri, 31 Oct 2025 14:37:50 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 98ED9180044F; Fri, 31 Oct 2025 14:37:48 +0000 (UTC) From: Kevin Traynor To: Thomas Monjalon Cc: Dariusz Sosnowski , Bruce Richardson , dpdk stable Subject: patch 'net/mlx5: fix build with MinGW 13' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:33:07 +0000 Message-ID: <20251031143421.324432-65-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5ZBFKNcuKPbFAxMpkeauUA0GF3-u9ISrIlEaSyqzQMo_1761921470 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/9e6373b052cb44d5f5064878839a58f3f3135107 Thanks. Kevin --- >From 9e6373b052cb44d5f5064878839a58f3f3135107 Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Fri, 25 Jul 2025 21:28:09 +0200 Subject: [PATCH] net/mlx5: fix build with MinGW 13 [ upstream commit a333afabed3b659ea28a92470565bbd5a98b5b53 ] After an upgrade to MinGW version 13, compilation breaks: drivers/net/mlx5/windows/mlx5_ethdev_os.c:285:69: error: 'dev_link...link_autoneg' may be used uninitialized This is because link_autoneg is never set in mlx5_link_update(). It can be set to the previous value (no change). Also it does not make sense to check this value to return the update status as it does not change. Fixes: 6fbd73709ee4 ("net/mlx5: support link update on Windows") Signed-off-by: Thomas Monjalon Acked-by: Dariusz Sosnowski Acked-by: Bruce Richardson --- drivers/net/mlx5/windows/mlx5_ethdev_os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/windows/mlx5_ethdev_os.c b/drivers/net/mlx5/windows/mlx5_ethdev_os.c index 2e9c9d5b3f..ec08bfef6d 100644 --- a/drivers/net/mlx5/windows/mlx5_ethdev_os.c +++ b/drivers/net/mlx5/windows/mlx5_ethdev_os.c @@ -284,9 +284,9 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete) if (dev->data->dev_link.link_speed != dev_link.link_speed || dev->data->dev_link.link_duplex != dev_link.link_duplex || - dev->data->dev_link.link_autoneg != dev_link.link_autoneg || dev->data->dev_link.link_status != dev_link.link_status) ret = 1; else ret = 0; + dev_link.link_autoneg = dev->data->dev_link.link_autoneg; dev->data->dev_link = dev_link; return ret; -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:54.246313356 +0000 +++ 0065-net-mlx5-fix-build-with-MinGW-13.patch 2025-10-31 13:53:52.170523786 +0000 @@ -1 +1 @@ -From a333afabed3b659ea28a92470565bbd5a98b5b53 Mon Sep 17 00:00:00 2001 +From 9e6373b052cb44d5f5064878839a58f3f3135107 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a333afabed3b659ea28a92470565bbd5a98b5b53 ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index 32a9f599b2..e24ff367af 100644 +index 2e9c9d5b3f..ec08bfef6d 100644 @@ -30 +31 @@ -@@ -312,9 +312,9 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete) +@@ -284,9 +284,9 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete)