From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE1A148A44 for ; Fri, 31 Oct 2025 15:38:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C692E4067B; Fri, 31 Oct 2025 15:38:07 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 79FE04067A for ; Fri, 31 Oct 2025 15:38:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sr89zCqf32mkZ5o8I/7Ak/0+fxJDrGr3jnWEttrixRc=; b=c+x9Ds1g+8/61ENJwoINd0tIPWI9E2MSi3QTfv4UfhhA6lDnC8ZCOXbV6orCs6cMVtalbE Vok6EvG8zkRcjANQas+wcBwzKhSRKY4fpx7+Cb/r3QVlQCN8FLTfT6pKglSwkt7cTFt3Vw LTiSvz/YtDjIrF72GooAZXKhRWey6PA= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-350-xECBQ7eyOP-qELJekz84eA-1; Fri, 31 Oct 2025 10:38:03 -0400 X-MC-Unique: xECBQ7eyOP-qELJekz84eA-1 X-Mimecast-MFC-AGG-ID: xECBQ7eyOP-qELJekz84eA_1761921482 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BE7711801376; Fri, 31 Oct 2025 14:38:01 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A738B18004D4; Fri, 31 Oct 2025 14:37:59 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: David Marchand , Chengwen Feng , dpdk stable Subject: patch 'test/func_reentrancy: fix args to EAL init call' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:33:12 +0000 Message-ID: <20251031143421.324432-70-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1zUoUrK_-xrL5i21bhN4G8E-T2lsZcZrOHWWVHsqVdI_1761921482 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/5f27e5e9f8df35ad145c64e9b5abd86c75d794e8 Thanks. Kevin --- >From 5f27e5e9f8df35ad145c64e9b5abd86c75d794e8 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Thu, 9 Oct 2025 14:00:37 +0100 Subject: [PATCH] test/func_reentrancy: fix args to EAL init call [ upstream commit b74d638ab9a769ed9628d2759029d2d20a081637 ] The unit test for EAL init was passing in a NULL argv[0] value which is invalid. Update to have a valid string for argv[0]. Fixes: 104a92bd026f ("app: add reentrancy tests") Fixes: 978ead0144c1 ("test/func_reentrancy: fix EAL init call") Signed-off-by: Bruce Richardson Reviewed-by: David Marchand Acked-by: Chengwen Feng --- app/test/test_func_reentrancy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test/test_func_reentrancy.c b/app/test/test_func_reentrancy.c index 34d685d493..51e3069611 100644 --- a/app/test/test_func_reentrancy.c +++ b/app/test/test_func_reentrancy.c @@ -69,5 +69,7 @@ static int test_eal_init_once(__rte_unused void *arg) { + char appname[] = __FILE__; unsigned lcore_self = rte_lcore_id(); + char *argv[] = { appname, NULL }; WAIT_SYNCHRO_FOR_WORKERS(); @@ -75,5 +77,5 @@ test_eal_init_once(__rte_unused void *arg) /* silent the check in the caller */ rte_atomic_store_explicit(&obj_count, 1, rte_memory_order_relaxed); - if (rte_eal_init(0, NULL) != -1) + if (rte_eal_init(RTE_DIM(argv) - 1, argv) != -1) return -1; -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:54.382415434 +0000 +++ 0070-test-func_reentrancy-fix-args-to-EAL-init-call.patch 2025-10-31 13:53:52.174121116 +0000 @@ -1 +1 @@ -From b74d638ab9a769ed9628d2759029d2d20a081637 Mon Sep 17 00:00:00 2001 +From 5f27e5e9f8df35ad145c64e9b5abd86c75d794e8 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b74d638ab9a769ed9628d2759029d2d20a081637 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -17,2 +18,2 @@ - app/test/test_func_reentrancy.c | 5 +++-- - 1 file changed, 3 insertions(+), 2 deletions(-) + app/test/test_func_reentrancy.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) @@ -21 +22 @@ -index f4c6cbc548..51e3069611 100644 +index 34d685d493..51e3069611 100644 @@ -24,5 +25,2 @@ -@@ -67,8 +67,9 @@ static RTE_ATOMIC(uint32_t) synchro; - */ - static int --test_eal_init_once(void *arg) -+test_eal_init_once(__rte_unused void *arg) +@@ -69,5 +69,7 @@ static int + test_eal_init_once(__rte_unused void *arg) @@ -32 +29,0 @@ -- char *argv[] = { arg, NULL }; @@ -35,0 +33,7 @@ +@@ -75,5 +77,5 @@ test_eal_init_once(__rte_unused void *arg) + /* silent the check in the caller */ + rte_atomic_store_explicit(&obj_count, 1, rte_memory_order_relaxed); +- if (rte_eal_init(0, NULL) != -1) ++ if (rte_eal_init(RTE_DIM(argv) - 1, argv) != -1) + return -1; +