From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2CB148A44 for ; Fri, 31 Oct 2025 15:38:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB3214067A; Fri, 31 Oct 2025 15:38:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3BF2D40669 for ; Fri, 31 Oct 2025 15:38:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fwNL7Swh3flpYPs7RiZNkKxoXfbSQR9wPZ7pW5Lf6mw=; b=UOjAYNbTdFeCF0q2jTzLp/+VjqYi5Lyd85Oy6YAnU0K6KP5UNRSBlyskyduRj2u3S/6H8w tT+4yUTDe/5CrGXzsDGm54Rfj2eoPvWFIc5KGL8giK+elCsi4vUeDtp/HkT21/FwRLhm5j WnM+94d2dzTSxH09YYj86BMFKoZWDe8= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-498-IjMkYwueOae-DzfAcpqU-g-1; Fri, 31 Oct 2025 10:38:18 -0400 X-MC-Unique: IjMkYwueOae-DzfAcpqU-g-1 X-Mimecast-MFC-AGG-ID: IjMkYwueOae-DzfAcpqU-g_1761921497 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 99E2818002DD; Fri, 31 Oct 2025 14:38:17 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4E8601800579; Fri, 31 Oct 2025 14:38:15 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: dpdk stable Subject: patch 'net/bnxt: fix free of not allocated object' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:33:19 +0000 Message-ID: <20251031143421.324432-77-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1kt9QbIQVzPqMwOHB-A16t_G2UOJf5NN18HErDdx1-g_1761921497 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/d1f013cf64c22a8ff354f79b2ce4ef4875418b3d Thanks. Kevin --- >From d1f013cf64c22a8ff354f79b2ce4ef4875418b3d Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 21 May 2025 12:37:27 -0700 Subject: [PATCH] net/bnxt: fix free of not allocated object [ upstream commit 49b1673ec6693a673b4dc07984023f481cce4d96 ] This was found as error when compiling with LTO. The function allocates new data with rte_zmalloc and then stores pointer in the pointer-to-pointer passed as argument. In the unwind case, it would call rte_free() with wrong one. Fixes: 80317ff6adfd ("net/bnxt/tf_core: support Thor2") Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/tf_core/v3/tfo.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/bnxt/tf_core/v3/tfo.c b/drivers/net/bnxt/tf_core/v3/tfo.c index bee813ebf6..c888dd1e4e 100644 --- a/drivers/net/bnxt/tf_core/v3/tfo.c +++ b/drivers/net/bnxt/tf_core/v3/tfo.c @@ -75,7 +75,5 @@ void tfo_open(void **tfo, bool is_pf) if (rc) { PMD_DRV_LOG_LINE(ERR, "MPC bind failed"); - rte_free(tfco); - *tfo = NULL; - return; + goto cleanup; } if (is_pf) { @@ -105,6 +103,6 @@ void tfo_open(void **tfo, bool is_pf) cleanup: - if (tfco != NULL) - rte_free(tfo); + rte_free(tfco); + *tfo = NULL; } -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:54.573632449 +0000 +++ 0077-net-bnxt-fix-free-of-not-allocated-object.patch 2025-10-31 13:53:52.179400188 +0000 @@ -1 +1 @@ -From 49b1673ec6693a673b4dc07984023f481cce4d96 Mon Sep 17 00:00:00 2001 +From d1f013cf64c22a8ff354f79b2ce4ef4875418b3d Mon Sep 17 00:00:00 2001 @@ -4,0 +5,2 @@ + +[ upstream commit 49b1673ec6693a673b4dc07984023f481cce4d96 ]