From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D28A848A44 for ; Fri, 31 Oct 2025 15:38:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBA9C40150; Fri, 31 Oct 2025 15:38:28 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 449B540150 for ; Fri, 31 Oct 2025 15:38:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8VA1Wokk5D4VMPQbKiEWPi5ljz+uzr/omtJU3KzFEVY=; b=EfZE2XLrfvmQoQATVHUdd50PLEj+ZzkBrmk+MMc+zuzpoQOwihIcbsV0cancFjZXN3pkG6 /DpV7vh1UXzO+aM7ZZ/vRddO3qlO0uhYpvsKjsvKaF7bd4wmD0dA8R78olqWevUCxaX+xn gXJsWP8eZJM/VvEwCnwVQvlRzX+paKE= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-47-fs0Jg4LLN4e8qM76RjBpmw-1; Fri, 31 Oct 2025 10:38:21 -0400 X-MC-Unique: fs0Jg4LLN4e8qM76RjBpmw-1 X-Mimecast-MFC-AGG-ID: fs0Jg4LLN4e8qM76RjBpmw_1761921500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2E111195605F; Fri, 31 Oct 2025 14:38:20 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4EF8A180044F; Fri, 31 Oct 2025 14:38:17 +0000 (UTC) From: Kevin Traynor To: Chinh Cao Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/ice/base: fix integer overflow on NVM init' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:33:20 +0000 Message-ID: <20251031143421.324432-78-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Fg3gnI8led575bPN2O00SrTC7qdM7D6gx_UonZ5XyAI_1761921500 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/b4257f3446071b21428e3edf9052ec7f1582ddad Thanks. Kevin --- >From b4257f3446071b21428e3edf9052ec7f1582ddad Mon Sep 17 00:00:00 2001 From: Chinh Cao Date: Wed, 1 Oct 2025 13:29:04 +0100 Subject: [PATCH] net/ice/base: fix integer overflow on NVM init [ upstream commit 96b1a23f3ea5614e5795307295234c15e0e99a1e ] The shadow RAM size is defined as 16-bit unsigned, which may result in overflows under certain scenarios. Fix the value to be 32-bit. Fixes: a240ff50505b ("net/ice/base: add basic structures") Signed-off-by: Chinh Cao Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/ice/base/ice_type.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/base/ice_type.h b/drivers/net/ice/base/ice_type.h index 69cc91fd95..bb31ba9864 100644 --- a/drivers/net/ice/base/ice_type.h +++ b/drivers/net/ice/base/ice_type.h @@ -983,5 +983,5 @@ struct ice_flash_info { struct ice_nvm_info nvm; /* NVM version information */ struct ice_bank_info banks; /* Flash Bank information */ - u16 sr_words; /* Shadow RAM size in words */ + u32 sr_words; /* Shadow RAM size in words */ u32 flash_size; /* Size of available flash in bytes */ u8 blank_nvm_mode; /* is NVM empty (no FW present) */ -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:54.601002395 +0000 +++ 0078-net-ice-base-fix-integer-overflow-on-NVM-init.patch 2025-10-31 13:53:52.179523815 +0000 @@ -1 +1 @@ -From 96b1a23f3ea5614e5795307295234c15e0e99a1e Mon Sep 17 00:00:00 2001 +From b4257f3446071b21428e3edf9052ec7f1582ddad Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 96b1a23f3ea5614e5795307295234c15e0e99a1e ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -16 +17 @@ - drivers/net/intel/ice/base/ice_type.h | 2 +- + drivers/net/ice/base/ice_type.h | 2 +- @@ -19,4 +20,4 @@ -diff --git a/drivers/net/intel/ice/base/ice_type.h b/drivers/net/intel/ice/base/ice_type.h -index ae3b944d6e..5f1f1a2f13 100644 ---- a/drivers/net/intel/ice/base/ice_type.h -+++ b/drivers/net/intel/ice/base/ice_type.h +diff --git a/drivers/net/ice/base/ice_type.h b/drivers/net/ice/base/ice_type.h +index 69cc91fd95..bb31ba9864 100644 +--- a/drivers/net/ice/base/ice_type.h ++++ b/drivers/net/ice/base/ice_type.h