From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A40CF48A44 for ; Fri, 31 Oct 2025 15:35:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BFA140150; Fri, 31 Oct 2025 15:35:41 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 115EC40150 for ; Fri, 31 Oct 2025 15:35:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CbHicvDZiwbvOBLsSZrkzibnlyzUPx1hCrnFoEihmPc=; b=Tr6wU78hwlWtUeOZ1lkRnyHk398c3lnbmRC05o3Z7zb5r+1Gj4PhdYmUzOzDzcDzHfeSeJ y7EngoPQD3Maj+2WhDzBEgIkYCp4387w01kZBAm/YoRA2ghZB/l2WCBiruRl9xTkTJAvV2 oXbmUS9K/3f6h+cTMAQ6kRsxlzAUxCU= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-163-wgrwGKnPM_iN778H8ps4YA-1; Fri, 31 Oct 2025 10:35:34 -0400 X-MC-Unique: wgrwGKnPM_iN778H8ps4YA-1 X-Mimecast-MFC-AGG-ID: wgrwGKnPM_iN778H8ps4YA_1761921333 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 107A51956094; Fri, 31 Oct 2025 14:35:33 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7D00A18004D4; Fri, 31 Oct 2025 14:35:31 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Chengwen Feng , dpdk stable Subject: patch 'eventdev: fix listing timer adapters with telemetry' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:10 +0000 Message-ID: <20251031143421.324432-8-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AjUK5GocoGg-Q_R7ArWMkWpBfmQ8fTNbnRu7TuOPMpk_1761921333 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/01b4b91026847a733bbd795da14cba787580519d Thanks. Kevin --- >From 01b4b91026847a733bbd795da14cba787580519d Mon Sep 17 00:00:00 2001 From: David Marchand Date: Fri, 4 Jul 2025 14:58:25 +0200 Subject: [PATCH] eventdev: fix listing timer adapters with telemetry [ upstream commit 94b2ff7ee1976f80dd4822dab090bbbf693d12ca ] If no timer adapter is created, listing with telemetry can lead to crash and is reported by UBSan as an undefined behavior: ../lib/eventdev/rte_event_timer_adapter.c:1418:13: runtime error: applying zero offset to null pointer ../lib/eventdev/rte_event_timer_adapter.c:1464:13: runtime error: applying zero offset to null pointer Fixes: 791dfec24d00 ("eventdev/timer: add telemetry") Signed-off-by: David Marchand Acked-by: Chengwen Feng --- lib/eventdev/rte_event_timer_adapter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c index 5886965d14..4132f71f2d 100644 --- a/lib/eventdev/rte_event_timer_adapter.c +++ b/lib/eventdev/rte_event_timer_adapter.c @@ -1399,5 +1399,5 @@ handle_ta_info(const char *cmd __rte_unused, const char *params, adapter_id = atoi(params); - if (adapter_id >= RTE_EVENT_TIMER_ADAPTER_NUM_MAX) { + if (adapters == NULL || adapter_id >= RTE_EVENT_TIMER_ADAPTER_NUM_MAX) { EVTIM_LOG_ERR("Invalid timer adapter id %u", adapter_id); return -EINVAL; @@ -1445,5 +1445,5 @@ handle_ta_stats(const char *cmd __rte_unused, const char *params, adapter_id = atoi(params); - if (adapter_id >= RTE_EVENT_TIMER_ADAPTER_NUM_MAX) { + if (adapters == NULL || adapter_id >= RTE_EVENT_TIMER_ADAPTER_NUM_MAX) { EVTIM_LOG_ERR("Invalid timer adapter id %u", adapter_id); return -EINVAL; -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:52.547397175 +0000 +++ 0008-eventdev-fix-listing-timer-adapters-with-telemetry.patch 2025-10-31 13:53:52.010523287 +0000 @@ -1 +1 @@ -From 94b2ff7ee1976f80dd4822dab090bbbf693d12ca Mon Sep 17 00:00:00 2001 +From 01b4b91026847a733bbd795da14cba787580519d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 94b2ff7ee1976f80dd4822dab090bbbf693d12ca ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 06ce478d90..af98b1d9f6 100644 +index 5886965d14..4132f71f2d 100644 @@ -28 +29 @@ -@@ -1411,5 +1411,5 @@ handle_ta_info(const char *cmd __rte_unused, const char *params, +@@ -1399,5 +1399,5 @@ handle_ta_info(const char *cmd __rte_unused, const char *params, @@ -35 +36 @@ -@@ -1457,5 +1457,5 @@ handle_ta_stats(const char *cmd __rte_unused, const char *params, +@@ -1445,5 +1445,5 @@ handle_ta_stats(const char *cmd __rte_unused, const char *params,