From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B97248A44 for ; Fri, 31 Oct 2025 15:38:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53F0940150; Fri, 31 Oct 2025 15:38:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 58C2440150 for ; Fri, 31 Oct 2025 15:38:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UAyxsy8sEL0eyETyMNVOZi+p1qHoWKpmcpXaeXS8AW4=; b=ZtJKT05DWcYkPUvAIgc2uCngD0eLQg8htpeDXUFxt5T+BaI+UcJWoZWr20mbvAEVyBhHGZ Mes9PrNi5zo7CWc4F3rGPHnnUTthmPZs0YK5q8SuDWkN7Zwd8gPRwp5rfz1+0gqtgFhU9u RbB7So8/kKHmXI2LAEFmqH1aMSUMrQY= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-qyzeJxhuMk-HlgvcTAaDPQ-1; Fri, 31 Oct 2025 10:38:33 -0400 X-MC-Unique: qyzeJxhuMk-HlgvcTAaDPQ-1 X-Mimecast-MFC-AGG-ID: qyzeJxhuMk-HlgvcTAaDPQ_1761921512 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3C0A11834519; Fri, 31 Oct 2025 14:38:31 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 90088180058D; Fri, 31 Oct 2025 14:38:29 +0000 (UTC) From: Kevin Traynor To: Anurag Mandal Cc: Bruce Richardson , dpdk stable Subject: patch 'net/i40e: fix symmetric Toeplitz hashing for SCTP' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:33:25 +0000 Message-ID: <20251031143421.324432-83-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 183Z0k0uQrKL-FhSSxdfAM9F3ucA2tz6MqI5a8gdP64_1761921512 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/1644c280dd1e398c0c5c96f6d7a3045446cfcdcf Thanks. Kevin --- >From 1644c280dd1e398c0c5c96f6d7a3045446cfcdcf Mon Sep 17 00:00:00 2001 From: Anurag Mandal Date: Wed, 15 Oct 2025 23:41:50 +0530 Subject: [PATCH] net/i40e: fix symmetric Toeplitz hashing for SCTP [ upstream commit 09937a3646f83ffe9d0d27896066c3f3f6e4ee0c ] When symmetric toeplitz is configured for SCTP, packets belonging to the same SCTP session are getting distributed to multiple queues due to improper hash computation. Removed SCTP Verification Tag from hash computation of symmetric toeplitz as it changes for same SCTP session. Tested the following with the fix & enabling symmetric toeplitz for SCTP: 1. Packets belonging to the same SCTP session getting into the same queue. 2. Packets belonging to the different SCTP sessions getting distributed to multiple queues. Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow") Signed-off-by: Anurag Mandal Acked-by: Bruce Richardson --- .mailmap | 1 + drivers/net/i40e/i40e_hash.c | 16 ++++++++++++++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index bab1bcf3db..b0c4217927 100644 --- a/.mailmap +++ b/.mailmap @@ -135,4 +135,5 @@ Antonio Fischetti Anup Prabhu Anupam Kapoor +Anurag Mandal Apeksha Gupta Archana Muniganti diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c index 02e1457d80..3149682197 100644 --- a/drivers/net/i40e/i40e_hash.c +++ b/drivers/net/i40e/i40e_hash.c @@ -562,5 +562,5 @@ i40e_hash_get_pattern_pctypes(const struct rte_eth_dev *dev, static uint64_t -i40e_hash_get_inset(uint64_t rss_types) +i40e_hash_get_inset(uint64_t rss_types, bool symmetric_enable) { uint64_t mask, inset = 0; @@ -609,4 +609,15 @@ i40e_hash_get_inset(uint64_t rss_types) } + /* SCTP Verification Tag is not required in hash computation for SYMMETRIC_TOEPLITZ */ + if (symmetric_enable) { + mask = rss_types & RTE_ETH_RSS_NONFRAG_IPV4_SCTP; + if (mask == RTE_ETH_RSS_NONFRAG_IPV4_SCTP) + inset &= ~I40E_INSET_SCTP_VT; + + mask = rss_types & RTE_ETH_RSS_NONFRAG_IPV6_SCTP; + if (mask == RTE_ETH_RSS_NONFRAG_IPV6_SCTP) + inset &= ~I40E_INSET_SCTP_VT; + } + return inset; } @@ -1114,4 +1125,5 @@ i40e_hash_parse_pattern_act(const struct rte_eth_dev *dev, NULL, "RSS Queues not supported when pattern specified"); + rss_conf->symmetric_enable = false; /* by default, symmetric is disabled */ switch (rss_act->func) { @@ -1141,5 +1153,5 @@ i40e_hash_parse_pattern_act(const struct rte_eth_dev *dev, rss_conf->conf.func = rss_act->func; rss_conf->conf.types = rss_act->types; - rss_conf->inset = i40e_hash_get_inset(rss_act->types); + rss_conf->inset = i40e_hash_get_inset(rss_act->types, rss_conf->symmetric_enable); return i40e_hash_get_pattern_pctypes(dev, pattern, rss_act, -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:54.740258367 +0000 +++ 0083-net-i40e-fix-symmetric-Toeplitz-hashing-for-SCTP.patch 2025-10-31 13:53:52.185523833 +0000 @@ -1 +1 @@ -From 09937a3646f83ffe9d0d27896066c3f3f6e4ee0c Mon Sep 17 00:00:00 2001 +From 1644c280dd1e398c0c5c96f6d7a3045446cfcdcf Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 09937a3646f83ffe9d0d27896066c3f3f6e4ee0c ] + @@ -21 +22,0 @@ -Cc: stable@dpdk.org @@ -26,2 +27,2 @@ - .mailmap | 1 + - drivers/net/intel/i40e/i40e_hash.c | 16 ++++++++++++++-- + .mailmap | 1 + + drivers/net/i40e/i40e_hash.c | 16 ++++++++++++++-- @@ -31 +32 @@ -index c14288e1c7..adce7ee286 100644 +index bab1bcf3db..b0c4217927 100644 @@ -34 +35 @@ -@@ -137,4 +137,5 @@ Antonio Fischetti +@@ -135,4 +135,5 @@ Antonio Fischetti @@ -40 +41 @@ -diff --git a/drivers/net/intel/i40e/i40e_hash.c b/drivers/net/intel/i40e/i40e_hash.c +diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c @@ -42,2 +43,2 @@ ---- a/drivers/net/intel/i40e/i40e_hash.c -+++ b/drivers/net/intel/i40e/i40e_hash.c +--- a/drivers/net/i40e/i40e_hash.c ++++ b/drivers/net/i40e/i40e_hash.c