From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4E4B48A44 for ; Fri, 31 Oct 2025 15:38:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD55C40150; Fri, 31 Oct 2025 15:38:46 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9CFAA40685 for ; Fri, 31 Oct 2025 15:38:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F++3Htb8F7SIpNDQ30Mn6S94TZcf0zg4PWFMhCdS4sI=; b=SAY2VrQ4awzdHhf09m32Wza+LSILorj53jcraqZYt1lYO2g6kXZjhnyR4BNwsmN5vFVQb9 Ducu7J2uHndqqM7ycm8m4gOvMYv+RUk8cUYJYf/KhZLVoAjFyAzA2TSpY3jYhEcnUkPdtw SabSjxCDCxptajJ8PEzTBRP5m1pwXjs= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-_5ASpYwzPF6kpxSSf-jdng-1; Fri, 31 Oct 2025 10:38:43 -0400 X-MC-Unique: _5ASpYwzPF6kpxSSf-jdng-1 X-Mimecast-MFC-AGG-ID: _5ASpYwzPF6kpxSSf-jdng_1761921523 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D7FB7195DE6D; Fri, 31 Oct 2025 14:38:37 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5391C180044F; Fri, 31 Oct 2025 14:38:36 +0000 (UTC) From: Kevin Traynor To: Gavin Li Cc: Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: fix multicast' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:33:28 +0000 Message-ID: <20251031143421.324432-86-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CXmsi14UhfMTuAepVb6oQI2B2etqZh64Ibp_zkov09A_1761921523 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/ddcaa1671f84a3662842df7bb8763fe8ffa6081b Thanks. Kevin --- >From ddcaa1671f84a3662842df7bb8763fe8ffa6081b Mon Sep 17 00:00:00 2001 From: Gavin Li Date: Fri, 29 Aug 2025 12:08:30 +0300 Subject: [PATCH] net/mlx5: fix multicast [ upstream commit 8c06434cd9e44ef8a4db2eb7e3300c7791c4e7b4 ] Device multicast MAC addresses are managed using the mac_addr_add and mac_addr_remove APIs. In the mlx5_dev_spawn function, devices such as PF, VFs, and SFs obtain the MAC addresses configured in netdev via netlink and store them in the PMD device data, which also includes multicast MAC addresses. Default rules are created for each MAC address to filter traffic accordingly. Previously, multicast MAC address flows were mistakenly disabled, which caused mac_addr_add to stop functioning for multicast MAC addresses, resulting in missed multicast traffic. To address this, default rules for multicast MAC addresses created by PMD should now be set up within mlx5_traffic_enable to properly update and manage multicast MAC address rules. Fixes: 2d0665a7f771 ("net/mlx5: align PF and VF/SF MAC address handling") Signed-off-by: Gavin Li Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_trigger.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index 485984f9b0..e2a94ca14c 100644 --- a/drivers/net/mlx5/mlx5_trigger.c +++ b/drivers/net/mlx5/mlx5_trigger.c @@ -1715,5 +1715,8 @@ mlx5_traffic_enable(struct rte_eth_dev *dev) struct rte_ether_addr *mac = &dev->data->mac_addrs[i]; - if (!memcmp(mac, &cmp, sizeof(*mac)) || rte_is_multicast_ether_addr(mac)) + /* Add flows for unicast and multicast mac addresses added by API. */ + if (!memcmp(mac, &cmp, sizeof(*mac)) || + !BITFIELD_ISSET(priv->mac_own, i) || + (dev->data->all_multicast && rte_is_multicast_ether_addr(mac))) continue; memcpy(&unicast.hdr.dst_addr.addr_bytes, -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:54.854257811 +0000 +++ 0086-net-mlx5-fix-multicast.patch 2025-10-31 13:53:52.219523939 +0000 @@ -1 +1 @@ -From 8c06434cd9e44ef8a4db2eb7e3300c7791c4e7b4 Mon Sep 17 00:00:00 2001 +From ddcaa1671f84a3662842df7bb8763fe8ffa6081b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8c06434cd9e44ef8a4db2eb7e3300c7791c4e7b4 ] + @@ -23 +24,0 @@ -Cc: stable@dpdk.org @@ -32 +33 @@ -index b104ca9f52..916ac03c16 100644 +index 485984f9b0..e2a94ca14c 100644 @@ -35 +36 @@ -@@ -1836,5 +1836,8 @@ mlx5_traffic_enable(struct rte_eth_dev *dev) +@@ -1715,5 +1715,8 @@ mlx5_traffic_enable(struct rte_eth_dev *dev)