From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9810248A44 for ; Fri, 31 Oct 2025 15:38:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6ED6740696; Fri, 31 Oct 2025 15:38:52 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3DEBD40696 for ; Fri, 31 Oct 2025 15:38:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ovRwSH07rQf1WP9Z9tOaCf9Lc7ogxHZuvB41A0U8pQ0=; b=EYNUz1uOWTDt5pHgtT/x+qUEHo4SeeerqzlYsOD9mOGPIAPiB/qC2/qbAc4fGHVVHcnEE3 bQxid/DUfSu9g1zcoDyE2xzB5RrcowCs7dmj4TRitM7S/adYfAPsRTUoBg0NOEmkQJi6EP AjkWEJ/PPn3a75lDSMnb5fsjnQQggS8= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-jPv3YN79MDiXbaGu9sIItQ-1; Fri, 31 Oct 2025 10:38:47 -0400 X-MC-Unique: jPv3YN79MDiXbaGu9sIItQ-1 X-Mimecast-MFC-AGG-ID: jPv3YN79MDiXbaGu9sIItQ_1761921526 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 961A51956058; Fri, 31 Oct 2025 14:38:46 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0C1E9180057E; Fri, 31 Oct 2025 14:38:44 +0000 (UTC) From: Kevin Traynor To: Roi Dayan Cc: Bing Zhao , dpdk stable Subject: patch 'net/mlx5: fix leak of flow indexed pools' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:33:32 +0000 Message-ID: <20251031143421.324432-90-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jyx38kNw1NLf4rdSrjApQ36i-LF3NZFzrt1JHK8ODlw_1761921526 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/76f38fb1bba87bf15169ec4c16f1d86f5b89188c Thanks. Kevin --- >From 76f38fb1bba87bf15169ec4c16f1d86f5b89188c Mon Sep 17 00:00:00 2001 From: Roi Dayan Date: Sun, 5 Oct 2025 10:23:45 +0300 Subject: [PATCH] net/mlx5: fix leak of flow indexed pools [ upstream commit eefec46eeb89672815afd6c2497d21b928d77c54 ] The cited commit allocated indexed pools but those pools were never released. Fix it. Fixes: b4edeaf3efd5 ("net/mlx5: replace flow list with indexed pool") Signed-off-by: Roi Dayan Acked-by: Bing Zhao --- .mailmap | 1 + drivers/net/mlx5/mlx5.c | 13 +++++++++++++ 2 files changed, 14 insertions(+) diff --git a/.mailmap b/.mailmap index b0c4217927..5e3d447103 100644 --- a/.mailmap +++ b/.mailmap @@ -1315,4 +1315,5 @@ Rogelio Domínguez Hernández Roger Melton Rohit Raj +Roi Dayan Roland Qi Rolf Neugebauer diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 96269d4e8e..0580e5d030 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -2307,4 +2307,16 @@ mlx5_proc_priv_uninit(struct rte_eth_dev *dev) } +static void +mlx5_flow_pools_destroy(struct mlx5_priv *priv) +{ + int i; + + for (i = 0; i < MLX5_FLOW_TYPE_MAXI; i++) { + if (!priv->flows[i]) + continue; + mlx5_ipool_destroy(priv->flows[i]); + } +} + /** * DPDK callback to close the device. @@ -2502,4 +2514,5 @@ mlx5_dev_close(struct rte_eth_dev *dev) claim_zero(rte_eth_switch_domain_free(priv->domain_id)); } + mlx5_flow_pools_destroy(priv); memset(priv, 0, sizeof(*priv)); priv->domain_id = RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID; -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:54.985486559 +0000 +++ 0090-net-mlx5-fix-leak-of-flow-indexed-pools.patch 2025-10-31 13:53:52.253524046 +0000 @@ -1 +1 @@ -From eefec46eeb89672815afd6c2497d21b928d77c54 Mon Sep 17 00:00:00 2001 +From 76f38fb1bba87bf15169ec4c16f1d86f5b89188c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit eefec46eeb89672815afd6c2497d21b928d77c54 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index aef57a4c32..ff13bf09fb 100644 +index b0c4217927..5e3d447103 100644 @@ -23 +24 @@ -@@ -1362,4 +1362,5 @@ Rogelio Domínguez Hernández +@@ -1315,4 +1315,5 @@ Rogelio Domínguez Hernández @@ -30 +31 @@ -index ece29fb216..b018a4f0e2 100644 +index 96269d4e8e..0580e5d030 100644 @@ -33 +34 @@ -@@ -2319,4 +2319,16 @@ mlx5_proc_priv_uninit(struct rte_eth_dev *dev) +@@ -2307,4 +2307,16 @@ mlx5_proc_priv_uninit(struct rte_eth_dev *dev) @@ -50 +51 @@ -@@ -2508,4 +2520,5 @@ mlx5_dev_close(struct rte_eth_dev *dev) +@@ -2502,4 +2514,5 @@ mlx5_dev_close(struct rte_eth_dev *dev)