From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2B3448A44 for ; Fri, 31 Oct 2025 15:39:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC5AB40150; Fri, 31 Oct 2025 15:39:00 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C8DA440150 for ; Fri, 31 Oct 2025 15:38:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z9OP1kSNFWpe4zYDGDCboeGaq/CbPeS+OKf8HDNKxAE=; b=ga4+4Kavc8M50SMdl9LrH8GUxW2XpOA6fguIAc/VJljskRT4PB1EYwpBITh1xpZo5A7zcJ HdPibjcmyNhX+CBxKqXwzJM5E4xFPNHtM0fjl5rgJ8NYxXC//pQE8poZ2H4A3vRtC1neEK ZvxQ6tGdRCKNUySHY6EZanBA6Ld7x0w= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-nW6gzFbxNjKSSYC7GofcxQ-1; Fri, 31 Oct 2025 10:38:55 -0400 X-MC-Unique: nW6gzFbxNjKSSYC7GofcxQ-1 X-Mimecast-MFC-AGG-ID: nW6gzFbxNjKSSYC7GofcxQ_1761921534 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C8C701956053; Fri, 31 Oct 2025 14:38:54 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3A490180044F; Fri, 31 Oct 2025 14:38:52 +0000 (UTC) From: Kevin Traynor To: Chengwen Feng Cc: Dengdui Huang , dpdk stable Subject: patch 'net/hns3: fix overwrite mbuf in vector path' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:33:36 +0000 Message-ID: <20251031143421.324432-94-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Y8oOPyc9ShM7jPXKuoVFWuOQsWWBPtAbevkOSVOfJRQ_1761921534 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/fe744304a87b4a3f2de377b17f292dee20016f06 Thanks. Kevin --- >From fe744304a87b4a3f2de377b17f292dee20016f06 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Fri, 22 Aug 2025 14:04:29 +0800 Subject: [PATCH] net/hns3: fix overwrite mbuf in vector path [ upstream commit 06b296a2264fcd1fe2d167f2d90a58607f5e81f5 ] The vector path processes multiple descriptors at a time and modifies the corresponding mbufs accordingly. When the mbufs cannot be applied for, the previous patch [1] only clears the first descriptor's valid bit, which is not enough. In this patch, the mbufs points to the fake_mbuf to prevent overwrite. [1] commit 01843ab2f2fc ("net/hns3: fix crash for NEON and SVE") Fixes: a3d4f4d291d7 ("net/hns3: support NEON Rx") Fixes: 01843ab2f2fc ("net/hns3: fix crash for NEON and SVE") Signed-off-by: Chengwen Feng Signed-off-by: Dengdui Huang --- drivers/net/hns3/hns3_rxtx_vec.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/hns3/hns3_rxtx_vec.h b/drivers/net/hns3/hns3_rxtx_vec.h index 9018e79c2f..6afa2fb814 100644 --- a/drivers/net/hns3/hns3_rxtx_vec.h +++ b/drivers/net/hns3/hns3_rxtx_vec.h @@ -110,6 +110,10 @@ hns3_rxq_rearm_mbuf(struct hns3_rx_queue *rxq) * Clear VLD bit for the first descriptor rearmed in case * of going to receive packets later. + * And also point mbufs to fake_mbuf to prevent modification + * of the mbuf field during vector packet receiving. */ rxdp[0].rx.bd_base_info = 0; + for (i = 0; i < HNS3_VECTOR_RX_OFFSET_TABLE_LEN; i++) + rxep[i].mbuf = &rxq->fake_mbuf; rte_eth_devices[rxq->port_id].data->rx_mbuf_alloc_failed++; return; -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:55.108198759 +0000 +++ 0094-net-hns3-fix-overwrite-mbuf-in-vector-path.patch 2025-10-31 13:53:52.270300371 +0000 @@ -1 +1 @@ -From 06b296a2264fcd1fe2d167f2d90a58607f5e81f5 Mon Sep 17 00:00:00 2001 +From fe744304a87b4a3f2de377b17f292dee20016f06 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 06b296a2264fcd1fe2d167f2d90a58607f5e81f5 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org