From: Dean Marx <dmarx@iol.unh.edu>
To: probb@iol.unh.edu, ktraynor@redhat.com
Cc: stable@dpdk.org, Dean Marx <dmarx@iol.unh.edu>,
Luca Vizzarro <luca.vizzarro@arm.com>
Subject: [PATCH 24.11] dts: add reception check to checksum suite
Date: Fri, 31 Oct 2025 13:44:14 -0400 [thread overview]
Message-ID: <20251031174414.85492-1-dmarx@iol.unh.edu> (raw)
[ upstream commit 89b634c9cf001570a7a1b1992ea6992c4181b8d7 ]
In the current implementation of Checksum Offload, the variables
is_L4 and is_IP are not initialized outside of the loop that
checks the received packet, so if the packet is dropped these
variables cause a NameError in the verification steps.
Add a line that sets these variables to None prior to the check,
then verifies they are not None directly after.
Fixes: 8c9a7471a0e6 ("dts: add checksum offload test suite")
Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
Reviewed-by: Patrick Robb <probb@iol.unh.edu>
Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
---
dts/tests/TestSuite_checksum_offload.py | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/dts/tests/TestSuite_checksum_offload.py b/dts/tests/TestSuite_checksum_offload.py
index 1a933563b6..f94d12232b 100644
--- a/dts/tests/TestSuite_checksum_offload.py
+++ b/dts/tests/TestSuite_checksum_offload.py
@@ -86,12 +86,17 @@ def send_packet_and_verify_checksum(
testpmd.start()
self.send_packet_and_capture(packet=packet)
verbose_output = testpmd.extract_verbose_output(testpmd.stop())
+ is_IP = is_L4 = None
for packet in verbose_output:
if packet.dst_mac == id:
- isIP = PacketOffloadFlag.RTE_MBUF_F_RX_IP_CKSUM_GOOD in packet.ol_flags
- isL4 = PacketOffloadFlag.RTE_MBUF_F_RX_L4_CKSUM_GOOD in packet.ol_flags
- self.verify(isL4 == goodL4, "Layer 4 checksum flag did not match expected checksum flag.")
- self.verify(isIP == goodIP, "IP checksum flag did not match expected checksum flag.")
+ is_IP = PacketOffloadFlag.RTE_MBUF_F_RX_IP_CKSUM_GOOD in packet.ol_flags
+ is_L4 = PacketOffloadFlag.RTE_MBUF_F_RX_L4_CKSUM_GOOD in packet.ol_flags
+ self.verify(
+ is_IP is not None and is_L4 is not None,
+ "Test packet was dropped when it should have been received.",
+ )
+ self.verify(is_L4 == goodL4, "Layer 4 checksum flag did not match expected checksum flag.")
+ self.verify(is_IP == goodIP, "IP checksum flag did not match expected checksum flag.")
def setup_hw_offload(self, testpmd: TestPmdShell) -> None:
"""Sets IP, UDP, and TCP layers to hardware offload.
--
2.51.0
next reply other threads:[~2025-10-31 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 17:44 Dean Marx [this message]
2025-10-31 18:02 ` Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251031174414.85492-1-dmarx@iol.unh.edu \
--to=dmarx@iol.unh.edu \
--cc=ktraynor@redhat.com \
--cc=luca.vizzarro@arm.com \
--cc=probb@iol.unh.edu \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).