From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCBFC48A8D for ; Mon, 3 Nov 2025 17:49:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D43D40A76; Mon, 3 Nov 2025 17:49:47 +0100 (CET) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 0EFAB406B8 for ; Mon, 3 Nov 2025 17:49:42 +0100 (CET) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-34029cee97fso4744928a91.1 for ; Mon, 03 Nov 2025 08:49:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1762188581; x=1762793381; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LtIJhvZSt6OEgeupU0v41SB41BjNEfctS2VXm0jxgVw=; b=wIFtY9VCa7ie6XuplxCPU2tqCLLqV1+7uUkKoy2CydovyA7wjz/mglZOZx9Bd5Secu VcHG+3bqEcCcTXn3GajoFwS66lZpycb5gYI6rCMyYl8/p8E8I6DtzHyYlrp1u4s4qpXr NFtPZQZtOSkbpMqFOYM1A0/dtc8tfwZn0xNSTgNxgWa67RzfStcIn2tH4bjxULj9nMp9 H9+f1LX2fFXtPmkCe1AcDxQCPgfxMEHXzPvRy3qoOlA/ArcDKR6oDQNJihFPOCs6A+uV nxtzhlVgxAurKB+4ZgO/VxZeOUi6FS1en5cJP1+pUWElq/tOIRDcLAJdkEFVp+als9Y+ nwfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762188581; x=1762793381; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LtIJhvZSt6OEgeupU0v41SB41BjNEfctS2VXm0jxgVw=; b=VxK6VcBDniwwPu21OiYUuYHU0McJt0WlPdq/pY1kVAk1Y0w7gdOKqGTJ8laGma3gAT dtRfvZRIT9w9TNjYGy6cWTrQ2RgpIMK4db1Ze62WBxWvodBxbFvKY+N+FRbQZ3l/nQDs MEF33M+hL/H5+CxaUxCsPRDz8+dOS0JoLR4wQXi6xZEnOWwCavIaRvekUAyHpXOj90Di Km2F/j1o4dV28HtnQvc3C0FhSzP4MzTsl+MIUJDtcGiAT4iKEBewyvy4rV2s1Q9qCJQo v34RNZPoJGMyNlUDmDm4hdYkXeoeFz7cEmYs+iTmMwS1fbgVl2qIaP5KFMIbLpzJJbeI wJrg== X-Forwarded-Encrypted: i=1; AJvYcCXiA4dJMr758nsacUTFNwX1yKs4Ie7L2/YSBAw2T09BBhbqnzqNM6qRHWOyQ/o/g5pTDGOi7R8=@dpdk.org X-Gm-Message-State: AOJu0YzIyG/33+JvrADQibloNplIaDlKr2l4zRC6pk6v059rUwZ83Yoq TAY3+DsQaTcRSnrCGmAKb/JShndexoJqiJ35NDsggJ0lDOiEd+4MSsIH3GzLFi6bEO/K74G8mfK NCQL2 X-Gm-Gg: ASbGncsxG8hG1SrAbK6HN20Ilq2aQB+QXyRHcv7aGxrxiKuVQ+vNhp8GNUsBHPGy2hg sg6Wbqou6dOXYSXAGiQegURBrb2xBQNpS3rqLjEyvULGIt9XRcPcF9sHyN85j7UtfqXZkeLpPbN wJBenYZKC2oNe5przktR1uEzMfB79a0xfaHApDDVzhyFNavrcbHSmNE2PD6DGZnapo32yluPNcp PL/fkuHh1doJhe99tGUO4iFloBS+it3o70qH7RG9JyJQClA5p/wE4rrt1WPaJETwduIJWb7J/bu alDlK4i6P5ZTZ+4muO6MM1KSo3k4sO8qSyhGidR/YfkUR/u9hrNbMbndgiZw+rl05Ms8okciHiT ORaZGD7Q5vWagWC9JvOeU4+LBw2PRDn6paFh3QOEyhjbtqCgsNny4rtS4H3zagIBcdo7/q8HCfL 0i4smtJ1efo/s5WK0GxDzrCDc5hduiu1K7+0E7Yi8vBfYUEvPRuA== X-Google-Smtp-Source: AGHT+IE7HpGxXCxFz6c7CV6kwSsw0DGm0SpNV/KYsx+mvHDD/sB0a2HOKfUiex8myjDY6+3ZndLlnw== X-Received: by 2002:a17:90b:5550:b0:32d:f352:f764 with SMTP id 98e67ed59e1d1-34082fcc5eamr14240117a91.2.1762188581279; Mon, 03 Nov 2025 08:49:41 -0800 (PST) Received: from phoenix.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3407f26e0a6sm6779040a91.5.2025.11.03.08.49.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Nov 2025 08:49:40 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , ajit.khaparde@broadcom.com, stable@dpdk.org, Somnath Kotur , Kalesh AP Subject: [PATCH v3 15/44] net/bnxt: remove use of sys/queue.h Date: Mon, 3 Nov 2025 08:47:20 -0800 Message-ID: <20251103164915.101713-16-stephen@networkplumber.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251103164915.101713-1-stephen@networkplumber.org> References: <20250818233102.180207-1-stephen@networkplumber.org> <20251103164915.101713-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Fix unsafe use after free by using STAILQ_FOREACH_SAFE. Fixes: e8fe0e067b68 ("net/bnxt: fix allocation of PF info struct") Cc: ajit.khaparde@broadcom.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt.h | 1 - drivers/net/bnxt/bnxt_filter.c | 7 +++---- drivers/net/bnxt/bnxt_flow.c | 1 - drivers/net/bnxt/bnxt_vnic.h | 1 - drivers/net/bnxt/tf_ulp/bnxt_ulp.h | 1 - drivers/net/bnxt/tf_ulp/bnxt_ulp_meter.c | 1 - 6 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index c9fdd36d3e..e9099a3ff2 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -9,7 +9,6 @@ #include #include #include -#include #include #include diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c index 7b90ba651f..0176b9f7cf 100644 --- a/drivers/net/bnxt/bnxt_filter.c +++ b/drivers/net/bnxt/bnxt_filter.c @@ -3,8 +3,7 @@ * All rights reserved. */ -#include - +#include #include #include #include @@ -110,7 +109,7 @@ void bnxt_free_all_filters(struct bnxt *bp) void bnxt_free_filter_mem(struct bnxt *bp) { - struct bnxt_filter_info *filter; + struct bnxt_filter_info *filter, *tmp; uint16_t max_filters, i; int rc = 0; @@ -151,7 +150,7 @@ void bnxt_free_filter_mem(struct bnxt *bp) bp->filter_info = NULL; for (i = 0; i < bp->pf->max_vfs; i++) { - STAILQ_FOREACH(filter, &bp->pf->vf_info[i].filter, next) { + STAILQ_FOREACH_SAFE(filter, &bp->pf->vf_info[i].filter, next, tmp) { rte_free(filter); STAILQ_REMOVE(&bp->pf->vf_info[i].filter, filter, bnxt_filter_info, next); diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c index a2e590540b..d3da309254 100644 --- a/drivers/net/bnxt/bnxt_flow.c +++ b/drivers/net/bnxt/bnxt_flow.c @@ -3,7 +3,6 @@ * All rights reserved. */ -#include #include #include diff --git a/drivers/net/bnxt/bnxt_vnic.h b/drivers/net/bnxt/bnxt_vnic.h index 5a4fd4ecb7..be232df2e7 100644 --- a/drivers/net/bnxt/bnxt_vnic.h +++ b/drivers/net/bnxt/bnxt_vnic.h @@ -6,7 +6,6 @@ #ifndef _BNXT_VNIC_H_ #define _BNXT_VNIC_H_ -#include #include #include diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp.h b/drivers/net/bnxt/tf_ulp/bnxt_ulp.h index e0e31532fd..f8c46186fe 100644 --- a/drivers/net/bnxt/tf_ulp/bnxt_ulp.h +++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp.h @@ -8,7 +8,6 @@ #include #include -#include #include "rte_version.h" #include "rte_ethdev.h" diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_meter.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp_meter.c index 591bde96e8..cd97bc6635 100644 --- a/drivers/net/bnxt/tf_ulp/bnxt_ulp_meter.c +++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp_meter.c @@ -4,7 +4,6 @@ */ #include -#include #include #include -- 2.51.0