From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1CF048AB2 for ; Tue, 4 Nov 2025 19:09:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0A7D4067D; Tue, 4 Nov 2025 19:09:34 +0100 (CET) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id 832CB4065A for ; Tue, 4 Nov 2025 19:09:33 +0100 (CET) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7a435a3fc57so5678812b3a.1 for ; Tue, 04 Nov 2025 10:09:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1762279773; x=1762884573; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DCYjS8lCU4ey/Xq/QimMFCgJnsxEn9LlKb03adqG16o=; b=o7I7/YuTTfpotZNgQUQRMDU40iOuGRKyR5z1oNzU81L8I+ucaDYP+l62lIU9mglBpO tmSgU/jX95mFwDxRvoqoL2AJtGEPgtyf3qYayF4r2AsqXvfCjKUxUGYGBlbzkyYBjoU7 MM+r0gO72uEnCjf7iTBFTxVu8hK0b/EmuK93q5h8arL1oEEkj1Ha5H/LbmJOxEcyDDCR 5Tt4L3vuFpW8okFNFOZ16VBkvyGWv2D0fs/gvSREWKnN4DOJp63NcOH0HnLXxRHycD2h zEB0ge9IvgdhB+uhx4lco97yN8iI65VV1aHcwWZr3Y+hE5OWqGJ8jJNxMtHX68U5qxH1 BGmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762279773; x=1762884573; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DCYjS8lCU4ey/Xq/QimMFCgJnsxEn9LlKb03adqG16o=; b=X6lLPb902dvCnpuu8vJDTS0f7LWb9vvkxZgpyeHmJ0fZqEaFdw3eQvQrTAmlbSHCOF n9tVTlEScACxqb+4vOswTPpBMKreqEf21Bxyht6YU0T47ZoOUVURYQqVCLHmP4XjqwFx Rfy3r6kFnDsl0tXAufznC3bai/0xpcGHgPyruOCM3Wfp5nOXfCCvjA4mGgC1KWzDKU3c t92FeA6O2YYR24eIMN+wWCCexUYVOnqI/FjOhhrn3XL+o4HCzc8SItkaJsuKBrWn1okj 58LcohRFe34ZeeL2p7ia6GLR0QRHZFbsRxoJVESR576pARPUuOkeb7iqe9G8OVEfQ6B9 DnLw== X-Forwarded-Encrypted: i=1; AJvYcCWvtrBT2a3Y3qf5Qiu0EI7T5tCUn14jBV4zzNO058hD8oD1F96N1a4FmCYgIXmcThs76zJ/mZc=@dpdk.org X-Gm-Message-State: AOJu0YyvyVr2o/snBhDknmWkm8xV/L0itQm9WoWGAb6SP1JLIa3+E2M+ 5d5v7zG84boSJpWfvbKkHNt89PD+oW7SGTe90QUJ2K1gbusC223vzWucMGdA306oke0= X-Gm-Gg: ASbGnctzzDS581H416QQGshbNStNX/XXTi0kLXuCYfofwvfl67+Ip2KJ90ssgBzpG5W FBpkydK7N6979wCXLDJ71ef8Q25jrQSsYVv6/Hj/XBoiJeeGmDQh1aGjsEYBmDIz/vlmoy06a9W OG1DH6LjI4IDNZfQpaov0jqiozxpNN7WaFcmq2DlP0kODFTRiJZWKvJKBgpSxRkGF1pnTVSt7+g ew7xGeqHVaJyiahcm9R/3+GaVkU+Ix8TAiKscviTCje5UzNErmQ6ifINniswc8vMGli5ZxBfLii LNPPNawiUJADxsiy6NytAQnkut3PLdv+ZzFkG/d91B4c76+2tmtpSV1m3YWo9FEkS7PTuzgq+aa vgBVj7SQpNiwsTxRIuKw4YriaXyksl+QqyeoeLfg1T59Z7RZgRhxgXnlBFC3AlqQyjUiQi+YqGe W+yuUYZVG4oN0Hs75KDxw5dbGAFvzg940jJJXYUms= X-Google-Smtp-Source: AGHT+IEYlTuDbKeh5HNkZQt+84UbVONdsd/IRueYhp1NbhC/XGdWShReIpDhBQPvg/4XqWwgzdAwWg== X-Received: by 2002:a05:6a20:958f:b0:2d8:ce9e:87a2 with SMTP id adf61e73a8af0-34f869e8df5mr191272637.57.1762279772717; Tue, 04 Nov 2025 10:09:32 -0800 (PST) Received: from phoenix.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ba1f86b0688sm3035988a12.28.2025.11.04.10.09.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Nov 2025 10:09:32 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Bruce Richardson , Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk>, Reshma Pattan , Anatoly Burakov , Suanming Mou Subject: [PATCH v6 2/8] pdump: handle primary process exit Date: Tue, 4 Nov 2025 10:07:06 -0800 Message-ID: <20251104180927.403355-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251104180927.403355-1-stephen@networkplumber.org> References: <20250811213632.16023-1-stephen@networkplumber.org> <20251104180927.403355-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org If primary process exits, then it is not possible (or needed) to cleanup resources. Instead just exit after closing the capture file. Bugzilla ID: 1760 Fixes: a99a311ba101 ("app/pdump: exit with primary process") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> --- app/pdump/main.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index fa85859703..1741d7e709 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -1028,13 +1028,15 @@ main(int argc, char **argv) dump_packets(); disable_primary_monitor(); - cleanup_pdump_resources(); + /* dump debug stats */ print_pdump_stats(); - ret = rte_eal_cleanup(); - if (ret) - printf("Error from rte_eal_cleanup(), %d\n", ret); + /* If primary has exited, do not try and communicate with it */ + if (!rte_eal_primary_proc_alive(NULL)) + return 0; - return 0; + cleanup_pdump_resources(); + + return rte_eal_cleanup() ? EXIT_FAILURE : 0; } -- 2.51.0