From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 315EE48A88 for ; Thu, 6 Nov 2025 20:37:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2484640395; Thu, 6 Nov 2025 20:37:24 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 22F744021F for ; Thu, 6 Nov 2025 20:37:21 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2964d616df7so19848545ad.3 for ; Thu, 06 Nov 2025 11:37:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1762457840; x=1763062640; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=5hwBAQceBGXMknbH69+c5HpZ8fEg8aGJ/0HE5ldnGXg=; b=IVcdW1NmaXvlB9bbDHneTi0b5JBl4uDVqGRgrvcYxrdGQXjj2cO/nEcu7K23UTxKHs JGddGx8uXnF7V2tfEgILW2mEOhym7JSIoKyAV2F1MEduiPNi98vCMvHUJrVRSQxxMZvA cO4lzkfhzZvNshoxzSy+vcPPmGeZBRGWvH3ucKxqFy7dhAKEYL9mABpId2eSuojfA620 R3c7q6A4qI+7CIFebecZWjwUrgRLNOxBy1I6bDfa37zH6IOwZ/u1hl5ySVlICMVh2FA7 5mN6UMWN21tuBv0PPbox/lIW3+dGrPMKQdP0o0WCGrUXsNVwTA83Ay/YTXI9wGPAiJtM SlEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762457840; x=1763062640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5hwBAQceBGXMknbH69+c5HpZ8fEg8aGJ/0HE5ldnGXg=; b=I5XdAtCoF/A66w9i7F65zOcnO18QU5pTU/JE/mu1cz20Qd84jYnJrPrUiWIvtklnyJ 5AZwlrocIN+4dxjqFZ0Vi/svCA7vMywFfOvTBpdGfgvZ7ee7ib/7WTzcCw84qRpkAdzl Dyq93svE+zz35UdbKM/tO7Aj4DoNe5OmgB99QKUQRFR9acJ6R+K7GaWRZSeJurQXD+jB MTdmNMpANedSNKWJsBDd56nPZt0633iLthJfm4r6mzFj4ftNG3n5QjuagpH6w6P3bIHL +MxF4oWeBl8iCw8BLAVR65f4PyL+gHF4ER1GTnqnknmUc+5CBGjJFRwfDsvoBquMDuWT ZCeQ== X-Forwarded-Encrypted: i=1; AJvYcCWDjhnikIdFo0HbQ7cuCj1q3/EZi2qOxWdo92hWQ0foTUq71dxY7q8UQplYMKh8uYK8Q1bOX6U=@dpdk.org X-Gm-Message-State: AOJu0YwJz+LkID3wtEZpoHzW7Nju8nlexztu6epbjEQ4U5MxmXlPMOgb sx9tXc5BDv44zX79snvLxHDN/yw3SYiS4ic5AscM8klMNXA2QrT8y0CzqKRk3qQICmQ= X-Gm-Gg: ASbGncuV/exRpIj/RlCtCehYxWXlO/o6Oft470oOnM/gtuKS/fasAS3Quorv3Zg9jdk tuzyi3ICOyP56UF8qnkTMqQVhqFKAX7LeGeFGBgGtSy6545MPDdWBEMYOxfe8eWJVXbeOx8w+BV CQVjBrWlg8D4iLUkLSOzkvIgYCrslepX+AgXhPulZBzcOLj9RpEKKGMjkVqBa49zVvrvFgHqh95 uf0ydqJyDO1VdKerk6mD+/zgf8IA0TFWhOy7T9moyCqPSWYPvIT3702OHmxjfDnP3Ct2BX+5S9z I2/CdHco7eQhRRpTBKLU7QyopMNIcdk45tg9pIzg4t1f5gFdM7J1XLKPi+s6i0v44AqQ8bQEHNk v8NA6Tt7240kMMxs4rqJU1CIEMWYAUojPDAxeSNntI2eTh9d0/goiesLlZGHlj4RTTs8Rc/zIoF oeTWzHdRusFY3PQE7oW86Omnavq9KZcMg3Pw== X-Google-Smtp-Source: AGHT+IGsq4gb0lRBYcrNaVFKN5BXJxBBc1RELvGss/CRd9ngEdzBxpVs1DeVAf8M5xiR0vPk0/juzg== X-Received: by 2002:a17:902:e784:b0:295:557e:7465 with SMTP id d9443c01a7336-297c038cc94mr8947385ad.11.1762457839413; Thu, 06 Nov 2025 11:37:19 -0800 (PST) Received: from phoenix (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29650c5f94fsm36582145ad.40.2025.11.06.11.37.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Nov 2025 11:37:19 -0800 (PST) Date: Thu, 6 Nov 2025 11:37:16 -0800 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org Subject: Re: [RFC PATCH 07/19] table: fix issues with variable shadowing Message-ID: <20251106113716.232408f4@phoenix> In-Reply-To: <20251106140948.2894678-8-bruce.richardson@intel.com> References: <20251106140948.2894678-1-bruce.richardson@intel.com> <20251106140948.2894678-8-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, 6 Nov 2025 14:09:36 +0000 Bruce Richardson wrote: > diff --git a/lib/table/rte_lru.h b/lib/table/rte_lru.h > index 28aab12923..1436425e16 100644 > --- a/lib/table/rte_lru.h > +++ b/lib/table/rte_lru.h > @@ -41,33 +41,33 @@ while (0) > > #define lru_update(bucket, mru_val) \ > do { \ > - uint64_t x, pos, x0, x1, x2, mask; \ Why is this a macro? Prefer inline functions where there is checking on types etc.