From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C37B48B0B for ; Fri, 14 Nov 2025 17:08:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25566410DC; Fri, 14 Nov 2025 17:08:10 +0100 (CET) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id 7DC5E410DC for ; Fri, 14 Nov 2025 17:08:08 +0100 (CET) Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-b996c8db896so1972207a12.3 for ; Fri, 14 Nov 2025 08:08:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1763136487; x=1763741287; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=y/qTLL1Grmo48RzrByycuvYarHH2/gYc1laxaFgLwJU=; b=MeLDsRF0Z35PmB9AaKJBLD+2zroh3JaTjyUI9ezpdp3aoMiWVz5VH2L8/y/vAJ/n7u d4Oql3c/eFeG/c9q+mvUAdemqGcIafk9TTuJYsTHIXY/WCbqoOTcfvTL3dbo21m2pkLY xHHGNqybBjbs2CEcs21boUTzWolOxGxoWFf93MS/g4Xk4AWlTMqNXDkbONjkPImzP1fP s8fXtbCqQAIF/aVCBWqgkHzfSEdcaqytE0yHyyw3RL5ZmkdVxOGdhBN67ne+EfB2WLne qw/nmEj2WNdHrn7NCWmoVKmVGNZKIHy2cFZ8Ve0h4Kfz2/lLo6/3Ez9EHbKHlsRc5hlX uEpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763136487; x=1763741287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=y/qTLL1Grmo48RzrByycuvYarHH2/gYc1laxaFgLwJU=; b=PXGxDqjE3fd5Uvi/mFfVcOJZTBIVlkW2EeURS6Ra/PH6rhSqTghckfwmzlyjMTGy3S MevOW3SMWk0Tjq4EdZaDLbKXCZxxZTZhSCumm5TDfGvUOBmmvB3O9hMu1UEAymUTaoxR sJe96zfRXHsl7RJpRVVOeVXsr9As3ns+DH43LABSmFwdAWhdvZ1xS0bm7WWcpijDWVnZ pXJ238XyXqVWk5lKESxlqFnt3oUeFOZ4PSs2bhv4qUq5IYrq/Iog4M5AAA7M3zrY37zo flZ2UUzmY21t9v/fPdop1odOJB6jocuTAoXmjiY496HS8lm+Eb9C6Afpl8NFsqYZQrlu Cfww== X-Forwarded-Encrypted: i=1; AJvYcCX5YVELsScS99RUIUI33SW3uStZwC2tQr3RPBEcNaXoRGMU4OiRVX+e93c6VRrYjLaRZfZI6vA=@dpdk.org X-Gm-Message-State: AOJu0Yz5/A839/tVvtrZfcMJc/4HkrW5XiwwPu3wxhKfVmYoNE24HVTv AHNp6z9wAbzQzJesp3tCc7DybKMFG2AU0vopQKDd06Wtl7emzI7srYOmqEUMVmFiFBs= X-Gm-Gg: ASbGncvg8Oth15it/tdJKv+JWhR98yv7kOcQ5STTk5/ELrchUB45V2l0wFH4/ah+xiI F9fFIr+ny8SBTZFLblu/jBLH56dzdlqXAhnnd1vEb1WuYCnWHCMuw1H3avEKyWb0i6iTo+ni5Ja Ng8ZlXxW0fiEWYSP9GXmLlQ/ZCCvbW0SzAT1E45KVEAKustUndlds6AWyYuioJ+5gLtWr4yU1Ul wgPpfj+FI2YwUXeR/E8DgTWB5ltaK9ZmcZGYNficdsyxwD5XtdVuoUtfEP0b27UEJihsEanwq7H fMPryiD/BMQ0ZICdIjAMqW0t6wDnYnY9P0bfkAwd3HSwjT1UCzXZCQJ4gIQKQEHBdRI+VSOQT6c ifF2stu0GLLEyXfyMp8h4UG/Do+vXIxiy1gvVwLMeTGhJ7vyAKo5FG5y/VXeTpS3jR64DrTkNsG /3kEUxj4w7IpHbp6NoHhJBll1wrqoDNRXRk0VJsKpYx8Lw X-Google-Smtp-Source: AGHT+IFxWD2ka7ozkgpe7aNXMmEjjjWBgaB4cdlQ1xoOObRU5oM8c/NoPHQOFhG01qg24/CS9/KoDQ== X-Received: by 2002:a05:7022:69aa:b0:11b:3742:1257 with SMTP id a92af1059eb24-11b4120ca2amr1949590c88.34.1763136487280; Fri, 14 Nov 2025 08:08:07 -0800 (PST) Received: from phoenix (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11b060885eesm11258932c88.1.2025.11.14.08.08.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 08:08:07 -0800 (PST) Date: Fri, 14 Nov 2025 08:08:04 -0800 From: Stephen Hemminger To: Robin Jarry Cc: dev@dpdk.org, Christophe Fontaine , stable@dpdk.org Subject: Re: [PATCH dpdk] net: ipv6 link local compliance with rfc 4291 Message-ID: <20251114080804.7636e240@phoenix> In-Reply-To: <20251114105751.54802-3-rjarry@redhat.com> References: <20251114105751.54802-3-rjarry@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, 14 Nov 2025 11:57:53 +0100 Robin Jarry wrote: > @@ -406,7 +406,7 @@ rte_ipv6_llocal_from_ethernet(struct rte_ipv6_addr *ip, const struct rte_ether_a > ip->a[0] = 0xfe; > ip->a[1] = 0x80; > memset(&ip->a[2], 0, 6); > - ip->a[8] = mac->addr_bytes[0]; > + ip->a[8] = mac->addr_bytes[0] ^ 0x02; Could use RTE_ETHER_LOCAL_ADMIN_ADDR instead of magic constant 2, but seems a little wordy to do that.