From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4DD548B35 for ; Mon, 17 Nov 2025 19:20:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C47AD402CA; Mon, 17 Nov 2025 19:20:10 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 41893402A0 for ; Mon, 17 Nov 2025 19:20:08 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-299d40b0845so28781755ad.3 for ; Mon, 17 Nov 2025 10:20:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1763403607; x=1764008407; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Yw0XnLjIQoCioWFHgfCgkSXXouKZEaifFN9MdNja4J0=; b=r5gOQM1MBaLlQys5tvcilgVAOXU3oyG42Ta7Mit+6tqhXwyT2Y5/AbgPUBH2kbJXJ+ 9Xk+kbecCfeQSEJHnop/5Povv6NMQ41eshTHWdpUnJO9zo8TX8gY0r8oBrvHJgc+/Ukh 7OVq2gQ81jkGVwd/wgAiN05Z/bgZiIx1QXuWDJDZRjzbeXQmsu4yA9X3KFpEbfhbRdRJ /sdZKT+rXnEZfTvcvQP4i2ssr2vyo4P0daLXjqZxcT4eooZu+N7G7Sw6rk/YP7ZupNyZ X1kLV10MkU0lVltw/qECusqqw44eHc1k7uZmHnFg7PQG/tAnJziLMz54+erVyN2Sw6r/ Hfuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763403607; x=1764008407; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Yw0XnLjIQoCioWFHgfCgkSXXouKZEaifFN9MdNja4J0=; b=DIw+H+6GTTWJVdoTWacr4DQaN20n53SygqczVKvJlJ4yTb0dILs7XJmKCtqTBU1tz6 cvV0+7bgePdefMiz9Jt/6TnUTMYmfjmYASXCWiEUqS8I5h9ndkplFoMqCm75XM72xaJP VwysbBbaQd9vVxXw4EwdGMHxHULODuy0r4UY9lJZFjnaL6EBKLP3e6B78WFgv9LNfGnD 2dyQDsrDd36pp3FdkNd6fMpTn/iSKxPRY7b8Ru02xch41odSiefRt/QQcOOWGX77N5jL k+PrAm1eOTliBZJsSJISIQSs/tbGFG/3tdDNkbc3UNhnQuBQ7q4eo8ag43iavMPQAvAe tOxQ== X-Forwarded-Encrypted: i=1; AJvYcCXQtJkR6r0u4HBP0737yOoR3beCNRHFpE1aODNzBFQlSHHcGVRqRhG0FqDCdImN27w8oSrfrRk=@dpdk.org X-Gm-Message-State: AOJu0YwcoNjyWiV0MMC3BDUWQ6gGZbbv/GYbzU3jNGKedWpkThrZpe60 XKaqxJSJvcQ/53NTEyF6I/xisEG1A/h+fInESTvFLjKgYF1uE6obbtazsoxkJYszLMM= X-Gm-Gg: ASbGnctXhPdqM4MAeHFR42pu8M0ArkFhPe6mBfGpfqxSf4lU5QdKdqw/kozthrmEmYH 3Y4wPo20VDOfKyS8CE5EEwo8/GoAofzSR4i2/vC9/bnRNtFSPn1MQi7HtJ1AKKMYXmFBoTQMp0L +fbm+63uDszHBs9AhVxdFRmE65o1Geh+QtWaJILh/rNZ64Kfkm/ylEQ+ioDpPxeGFt37Bwr4qh4 ZKYMeFC7ZQljri/yfuqs+R+UUOX3fFwjknO8y8KUawvJsDfEtMmjXarqDeU+DOkwImkValozDsq FCMbmJn7NmyXw/lLyF213bOJtj71KEY2pHr6yRIu6K0ohKcpvCitWrI6HWBX6nHTBhKxpvH3IkI zn1A75xONAo7XASLAoMI1V271o6oOAUJRnyVWSrb9OPIfKoBM/ltIGpVVceSXYHGWAbZgfnGYc4 yVtTsRxHTPw0xxGu+2qwsLkz3r803lW7dMucfrULZKoG8qIoZsgzfPJ8U= X-Google-Smtp-Source: AGHT+IH4/7VwL94/7NCqkNYPc5QAj0AwRTUKcNz0i+WpuOL/rZ5UwCe6PXIX3B3HnAcsZ+CDc2FoUw== X-Received: by 2002:a05:7022:3a06:b0:11b:af12:b9f5 with SMTP id a92af1059eb24-11baf12bd97mr3188502c88.5.1763403607162; Mon, 17 Nov 2025 10:20:07 -0800 (PST) Received: from phoenix (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11b060885eesm51684677c88.1.2025.11.17.10.20.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 10:20:06 -0800 (PST) Date: Mon, 17 Nov 2025 10:20:04 -0800 From: Stephen Hemminger To: Maayan Kashani Cc: , , , , Aman Singh , "Viacheslav Ovsiienko" , Gregory Etelson Subject: Re: [PATCH v2] app/testpmd: fix flex item link parsing Message-ID: <20251117102004.713f1622@phoenix> In-Reply-To: <20251116121437.159702-1-mkashani@nvidia.com> References: <20251113201726.10597-1-mkashani@nvidia.com> <20251116121437.159702-1-mkashani@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Sun, 16 Nov 2025 14:14:37 +0200 Maayan Kashani wrote: > The flex_link_item_parse function was using FLEX_MAX_FLOW_PATTERN_LENGTH > for all memcpy operations regardless of the actual flow item type. This > could lead to copying incorrect amounts of data. > > This patch adds a switch statement to determine the correct size based > on the actual flow item type (IPv4, IPv6, UDP, TCP) and uses that size > for the memcpy operations on spec, mask, and last fields. > > Also adds validation to reject unsupported item types. > > Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands") > Cc: stable@dpdk.org > > Signed-off-by: Maayan Kashani Queued to next-net