From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA84E48B58 for ; Thu, 20 Nov 2025 11:48:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DACF640262; Thu, 20 Nov 2025 11:48:46 +0100 (CET) Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010025.outbound.protection.outlook.com [52.101.85.25]) by mails.dpdk.org (Postfix) with ESMTP id 0BE9740262 for ; Thu, 20 Nov 2025 11:48:46 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FUFf1C0IXlSKrrSiOXD0+RDsH1MZgIvsIQGK74hkQtaJjMJxuv6Fjb4BwMpb6IXp4L3vLNAdarIn/u/fRCAUtLqpliJtpxCuatwpnD1b5yjbP3cC+dqxacXAj6Pc3xxNw9/sCKLLEHdd7KOPOnUC0Qmtb7JpCr3Pad3sBIKlRniuE5+2IvRanpDOf6XQmfLYcDz4VXCCFzxIztc4iVPHiBiIzk2q8CHrL/TPDguF6YBHXQiLM1BM2Cw7v/awGtUqcm3Gm+78VLosWsELRaMbrim1mqWi3aR/r730lPyPne8k1lB0uAM/duYId4RomWmo+Q0XHWcNzahTkGPoZhlMUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WOJWjzTzS7x2aj3lHIK7QLwvqclRWjvYXaantlyPHN0=; b=my9KXkSH3wAu3X/fxIJsZCePq8jQPVa4tLCYCduF7CEpEEpyAi7k0/9szrBumYy/+XyMqiEi4J85x8yaNRcEBKX/liuvEH/ezVcO14v11ey2SCH5+xu5Ym4wRuxJgUJ54JGOZh5CcUPtrIokK/LS+5I88xMR+bzgFZQMcC0OfvuaM3eXYEt6W57T64E+EOZcqzpZJWWJuLsd8vgRNYdmvqgxFXqxMn0b9e65G8QM7kNpHcNWGfTKYk5F7bsx/UELvHpUVXAgKCmZFB4QQHCCVyW4fKOA7vIYYGdx/7YvoHiCIuK5nFjgmny2+73aF5sD8nG0XU+n1AMWkJfq/kTd6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WOJWjzTzS7x2aj3lHIK7QLwvqclRWjvYXaantlyPHN0=; b=T1nDINz3epulW4WcuhQoWL1I2tZ6/42KoYPDvXifL8F+LuKITZRtM5sUxTRMwabnVRqqvLNWWWPOYgom4U5mEPwL3sC8l7cwCwGWyOaUpEL/mUnsdIwByzvDzYlXYvMTY6ionvTpX/oEjfnj/bafCjVYUf6FWdy9/6yRyf711uugmAxfb0sSnx4D9P8awsudROV5K4sNYb/wI/KTYaLstGPiBALmPAnihRgiD/nsa4gT8XPpkDq+khCzvWHi0jYAVP4W44j5n5leJlBqCHw5dLOTuRS+/+X08iWs4A8PowrBDQBY+Fo0Mmcns14cBHsqPVjwP/YK2sFGiZnnsEvoYA== Received: from SN7PR04CA0099.namprd04.prod.outlook.com (2603:10b6:806:122::14) by BL1PR12MB5755.namprd12.prod.outlook.com (2603:10b6:208:392::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.16; Thu, 20 Nov 2025 10:48:41 +0000 Received: from SN1PEPF0002BA4E.namprd03.prod.outlook.com (2603:10b6:806:122:cafe::8e) by SN7PR04CA0099.outlook.office365.com (2603:10b6:806:122::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.10 via Frontend Transport; Thu, 20 Nov 2025 10:48:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SN1PEPF0002BA4E.mail.protection.outlook.com (10.167.242.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Thu, 20 Nov 2025 10:48:40 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 02:48:30 -0800 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 02:48:29 -0800 Received: from nvidia.com (10.127.8.14) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 20 Nov 2025 02:48:27 -0800 From: Shani Peretz To: CC: Shani Peretz , Dariusz Sosnowski , Viacheslav Ovsiienko , "Bing Zhao" , Ori Kam , Suanming Mou , Matan Azrad , Michael Baum Subject: [PATCH 22.11] net/mlx5: fix Tx metadata pattern template mismatch Date: Thu, 20 Nov 2025 12:48:23 +0200 Message-ID: <20251120104823.50618-1-shperetz@nvidia.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA4E:EE_|BL1PR12MB5755:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f52ae70-9cef-431e-18f6-08de28225e3a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ORDw9mtHs9TEK1kmwDRgRsP6IHdX/i5zeSocik/l1DzcymNY5PyqYxLi8gL6?= =?us-ascii?Q?yvAw0w/jiU7p5i12nmtLafX0+T/V1zvtdHtsvJRkfVaoW5912E01rnj0ihGK?= =?us-ascii?Q?pUMmHXhrtrRU5ge/gil2RBmw2W9xPn5OPf2yMQ36xc7+qwDez/TThtLWy0kl?= =?us-ascii?Q?YIeW5H0CNMKZG5Qd/2hRV9wJzcBKYu/eQxgyWg5tA7FBfWXMfXTuy0wuCxob?= =?us-ascii?Q?o616z+rEncQ+FzSwSMtRsND+PuK7WVzlx8Lr25iColo5xHkxwwpeymkfd62Q?= =?us-ascii?Q?crbTGWKHg03hr79aZ9hHroj0csNwy12GMcpGHXOkcAaIWPHW33B9mC2bwXFr?= =?us-ascii?Q?1u72CmN84WhDxfdwBBwUCsBs+DNrNyuts31Rayj50MV51qq5JYe3m9RWkuX3?= =?us-ascii?Q?dOdxwqbgoAZxpyeKZflbnN6BeB+nYDsY9aDlxoCNIrNcgw5DVwWpewipGwth?= =?us-ascii?Q?0QwQz8yAFiq/fZrILeefQhfhY6Z9OONjdt7i2SepdNkhPUkjGHtZ0IUR9Qyo?= =?us-ascii?Q?d/Z+jLz17ekBF4k9pg57VKYy7/P3N5hrSHfPR758YY1gFtEzE5h0lfnC8FF0?= =?us-ascii?Q?c5v8csqRDU8Whu/K9Tx+DKwtNDm3/78ZdSOqE0xVKfNaY6fumYVHjH1bVBqG?= =?us-ascii?Q?tLA20FcuizKbpk6iKkQv8N+hRjl4W5okcZVY1c6mxzw6I0HgSgnL+7H8M+vo?= =?us-ascii?Q?AkaJn+nevQn94PFA0Rs1GTRO/2Jr4xI2EWAlnuXoXzIe8OgS0OTd+ii3NiZz?= =?us-ascii?Q?ej+wI2lNSQFlDObU9k3S7CtzRLgMWPBh9BTPCDQLd/WfxLvwp0mQY53tTPcH?= =?us-ascii?Q?cP/wNTzURj5ERLc1CYHr2RwEaecG2KTzsln4O0MXS95Gz3vwJJ1rizrvJBhR?= =?us-ascii?Q?wY16izX1+Vm1u5f49h03Q0XYw+gG8mAE8TafZ/n7NIgFPYLu+zCXD2sm1fP5?= =?us-ascii?Q?F2cge+MqgtzAZoY357FE9hmL8N5dop6KvNMP+UCtuB82z2KgKSNpKLDro7wh?= =?us-ascii?Q?wNm9jaTvapjCuM5zz3zdglygGFxDcEFVe3gH/0ABRGrl5gR4I+PExiBFDlnp?= =?us-ascii?Q?y8iXdCtJlHLgUvfI8Cg+jrLtEgwqLJQadqwnVYZ1WYTXGHeiO7y/ECFN0zxN?= =?us-ascii?Q?Zjvk9sq7wA+6d80iY66AaEl9fB9Nezt5rMco23uRk/dOAV9OrH2HfYjqRyjE?= =?us-ascii?Q?gjVUgfhDGYSnwy/RUfIfs3ttudxtFh/jOCKy3L6LZDDzn2gBKUvNN/IU0Yfo?= =?us-ascii?Q?Wf0vRWrbyAwIiNwqGkTsHE9b9NBpfTSe/I76j0+A/FSG04iAxjAg/BhADFiQ?= =?us-ascii?Q?BFMxPq8qQWp4I3gtq/zEBVTlWlKZqPg7dB7oGhE6GrN5eqZzW5dR3PsPCv9r?= =?us-ascii?Q?waCk7xGjw7utdtGLP6D0mufG06JwsmadjGNEfXUrd8P2aCwDIsPaaimJru7p?= =?us-ascii?Q?nUri1HoX86Ih6tK36IGw2YjJ4SNJgCzCHN9SPJQRIWh4UdZhR8IRnTgDwT83?= =?us-ascii?Q?P18fNK4ue6J9+BM3q5xHpuGO6Nd48VoPAfEOUlUavwoU2ANgR9xYzrg03X/2?= =?us-ascii?Q?lMMBlDDVlc/aZAqyp7A=3D?= X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2025 10:48:40.7032 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3f52ae70-9cef-431e-18f6-08de28225e3a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002BA4E.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5755 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org When representor matching is disabled with dv_xmeta_en=4, the Tx metadata copy flows use SQ (send queue) pattern matching, but the pattern template was still configured to use ETH match-all pattern. This mismatch causes hardware to reject the flows with error CQEs during port configuration. This patch fixes the issue by using SQ-based pattern template (flow_hw_create_tx_repr_sq_pattern_tmpl) instead of the ETH match-all template (flow_hw_create_tx_default_mreg_copy_pattern_template). Fixes: 593fb3fdfa10 ("net/mlx5: fix multi process Tx default rules") Signed-off-by: Shani Peretz Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 42 +-------------------------------- 1 file changed, 1 insertion(+), 41 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 208f50fbfd..b64ba9b46b 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -10185,46 +10185,6 @@ flow_hw_create_ctrl_port_pattern_template(struct rte_eth_dev *dev, return flow_hw_pattern_template_create(dev, &attr, items, error); } -/* - * Creating a flow pattern template with all ETH packets matching. - * This template is used to set up a table for default Tx copy (Tx metadata - * to REG_C_1) flow rule usage. - * - * @param dev - * Pointer to Ethernet device. - * @param error - * Pointer to error structure. - * - * @return - * Pointer to flow pattern template on success, NULL otherwise. - */ -static struct rte_flow_pattern_template * -flow_hw_create_tx_default_mreg_copy_pattern_template(struct rte_eth_dev *dev, - struct rte_flow_error *error) -{ - struct rte_flow_pattern_template_attr tx_pa_attr = { - .relaxed_matching = 0, - .egress = 1, - }; - struct rte_flow_item_eth promisc = { - .hdr.dst_addr.addr_bytes = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }, - .hdr.src_addr.addr_bytes = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }, - .hdr.ether_type = 0, - }; - struct rte_flow_item eth_all[] = { - [0] = { - .type = RTE_FLOW_ITEM_TYPE_ETH, - .spec = &promisc, - .mask = &promisc, - }, - [1] = { - .type = RTE_FLOW_ITEM_TYPE_END, - }, - }; - - return flow_hw_pattern_template_create(dev, &tx_pa_attr, eth_all, error); -} - /* * Creating a flow pattern template with all LACP packets matching, only for NIC * ingress domain. @@ -10930,7 +10890,7 @@ flow_hw_create_fdb_ctrl_tables(struct rte_eth_dev *dev, struct rte_flow_error *e /* Create templates and table for default Tx metadata copy flow rule. */ if (!repr_matching && xmeta == MLX5_XMETA_MODE_META32_HWS) { hw_ctrl_fdb->tx_meta_items_tmpl = - flow_hw_create_tx_default_mreg_copy_pattern_template(dev, error); + flow_hw_create_tx_repr_sq_pattern_tmpl(dev, error); if (!hw_ctrl_fdb->tx_meta_items_tmpl) { DRV_LOG(ERR, "port %u failed to Tx metadata copy pattern" " template for control flows", dev->data->port_id); -- 2.34.1