From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B66D48B58 for ; Thu, 20 Nov 2025 11:50:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2379240262; Thu, 20 Nov 2025 11:50:01 +0100 (CET) Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012010.outbound.protection.outlook.com [40.107.200.10]) by mails.dpdk.org (Postfix) with ESMTP id B97D140262 for ; Thu, 20 Nov 2025 11:49:59 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KQdYjb4yJ7Lh5w2abmdC/RZZ8gjPvy0ceskM7qwscrJ4fSkxWJwHcJj1w4difYazNV8omEwNvTIT7oZzjA4rcWjwq+qjXM+UK1eV6ip1hNfiufbbcueQYEOLQ0h/AmJv0W2Cy8i6IlKC/BtrU5v51zQbzfEqm1fvVXbehy8tFrqfIi61WLR5MQL5xN2RY8WGV/mKGfgcxMvTbzKk714HnCn0I5YoONEzoNU5kQPW/GDjmiMhH0jAgCX5HFuxxwC4tHcHn8M2LkZrNY2dnjy8vxFHD3cOanuH35oJlzsrymjyF4rgcYVQ2Q8tObMYSFlegAuhQcyz7Ry9RMiorSQe3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WOJWjzTzS7x2aj3lHIK7QLwvqclRWjvYXaantlyPHN0=; b=fKQ7LTMX5ffhs/BhhpGKWUsh/yzjNnZ1nzq4HTs7cgk3YBhQ04aWkm986skvyHI2Z+s2bt3YxJJPKdzQ7n2sDOAuIilR0oT666+0AWfFzZZS93zFLgRtoXFXeNLjyUOXmeYzWUfmvPUEvJIBQCpDF+GyhDqrbRjfm0LTAz+mZv807ftLwAcA3U5mm3l2+q45R+dC6jtsTd2fzeGXjYD0bRdMwpc5v/UivB+WvfMyzEpDJGqFfceuP4ZU2iWhzEPDqWYGYikzVCtHvpkX3TZh1zhsp+agmXM9AG+btHk3CKOpI8xkTByz7b7WSy/e9eGtggsGvgoMtScXXMfzIRFaIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WOJWjzTzS7x2aj3lHIK7QLwvqclRWjvYXaantlyPHN0=; b=BB8DncUeMxAiP0IWziuRD17JaZGAxMto3t3BheD9p6uZfd384aCFZIzWs8RomzWaBFERFfMnwzlLVE7MwpWViHY/omoc5T+D6WuIMQ66P36xmavDke62BRoM55Tj5cjxKrptdKrNqXVw1Zmn3hjGYrEybD++kJW2OiRenIk2vDjDnY1uz0xjJ1vpj9E+pxtx8CF11xk38YNFmuzqrORys4yhUjTytEtjUi2QQsT+JFalGOkJGRMH1hh2SAEhrmYW5cbc+Kyp+I4fKPpyrhdYgT4hYokxZx6ZjxBcVduK/zjjkB2UTVWHZLJBkKSa0vJSghcPpoKrY7dgEEUsJAXimQ== Received: from DS7PR05CA0070.namprd05.prod.outlook.com (2603:10b6:8:57::28) by IA0PR12MB9045.namprd12.prod.outlook.com (2603:10b6:208:406::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Thu, 20 Nov 2025 10:49:56 +0000 Received: from DS2PEPF00003439.namprd02.prod.outlook.com (2603:10b6:8:57:cafe::50) by DS7PR05CA0070.outlook.office365.com (2603:10b6:8:57::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9366.5 via Frontend Transport; Thu, 20 Nov 2025 10:49:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS2PEPF00003439.mail.protection.outlook.com (10.167.18.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Thu, 20 Nov 2025 10:49:55 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 02:49:43 -0800 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 02:49:42 -0800 Received: from nvidia.com (10.127.8.14) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 20 Nov 2025 02:49:40 -0800 From: Shani Peretz To: CC: Shani Peretz , Dariusz Sosnowski , Viacheslav Ovsiienko , "Bing Zhao" , Ori Kam , Suanming Mou , Matan Azrad , Michael Baum Subject: [PATCH 23.11] net/mlx5: fix Tx metadata pattern template mismatch Date: Thu, 20 Nov 2025 12:49:36 +0200 Message-ID: <20251120104936.50670-1-shperetz@nvidia.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003439:EE_|IA0PR12MB9045:EE_ X-MS-Office365-Filtering-Correlation-Id: 12248135-6264-42ef-ae65-08de28228ad8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?RU9dlzoq7Rw98zmAkg+HalDOkhMHjUBjOU+PV+ANBOiiSqW8wfnPZwwjM7wT?= =?us-ascii?Q?/5JDwm/jIipljVvZLnwKfqDaInxDgEtMxCnuRLBoUqHx9T0dyZNzb84X0Dij?= =?us-ascii?Q?D2X5V/Jw7+i3qWM5T62zEVkB2h3ZRwkn9z2KAdY02JmbfLV2QTqLe6/X8GEx?= =?us-ascii?Q?yVVS/RCt5oNkCOZE+NtqUScety44UNJZ4TbKh9rfvPt0IifbM6qu/yEe8K4i?= =?us-ascii?Q?2PhNwOeo5XnO/QNHtoENx70yGTvev8XBWoj/IrHA2eToOrJIG2OgDS3Czwri?= =?us-ascii?Q?ueRKEeXTekHV/RgO6+BAE04AA492BU7ZXAqts0EF39yQD8YNWZ0zaKC0VlKV?= =?us-ascii?Q?bE4ujgGOFSN5/JrEg0LT9NLHpfyrOWcDkvC/qMo8gamlW+E9QtrRbmJ0Jg2w?= =?us-ascii?Q?Q7bYcufZ8WrX2cdEejdIuO4APsjFOGtNwNMj28xQF3eeDJCjicnuYoJo2cBK?= =?us-ascii?Q?R09q8cdRFBMB6LPDEtRChOTv1AE2H5QulHnpY11i98GYipeJuPrK3nD3qh7k?= =?us-ascii?Q?hhERTACB4mhL/8FqmnmlxTZiiWzAU/Kk4qrFPXWyLuSqCEw5O0LlCU8UeyPu?= =?us-ascii?Q?yjl/JkePjz6UXAeuQpvwH/amcbBNbHcQlA9x5prZ33xoJHD+vIIUesxzcsEL?= =?us-ascii?Q?0rrnzXqaxHvzNzd78Rnj1o+UH3GNkW9rWv/eIs22o+k7gvUcNKpDeg2fAkZE?= =?us-ascii?Q?SYYWQ0qBW0yQC+9icJM5RI6ieqcf2LN5DS1pFWpaKM2C2cQVzqbRtRLECcJY?= =?us-ascii?Q?J6Wp0uWNmOKMeHHazRdRamNgXWJ3Cjm4E2x5/RJoHvdEpONA/CAX1uzohxAH?= =?us-ascii?Q?2lU81BRMmPC71aFApi7gtGmwZzsF61IWVKBvjeUgyqi6xlPpsAyqjAak8w07?= =?us-ascii?Q?9HkmDU5QVlmMI5VbV5iY1zjj2JygtCN7zkqC4l2fsw5goLtnaP6rDkGnPdQq?= =?us-ascii?Q?qHxphZAECLsEQ64eAg4/hAM+jaQTLdZ+ETfZVPZYAq9yfsUDBdLw27dNpTkn?= =?us-ascii?Q?mqK7yoIQpVhs7UGQY9rEVxZILA1U/crPAj5B1WRuHgpeiI+7Lcw/MEeLryST?= =?us-ascii?Q?dLynQdRtuA316P5dy6PwLlmncGdqMr/si8BekUAcR6GfJg3P7TGz4nU2f2J1?= =?us-ascii?Q?y325nPMVE4PQ2cTrgoICbMmTlReGRr3S9J5Uh5VPxzSbnurMfAInQQ3jWu1D?= =?us-ascii?Q?N+emZ/DVvJGD4cDoFO+Dhthlk2suayPKgjgaCppgZdW5he/IhBZfmEPGbu4m?= =?us-ascii?Q?eeVL01gAi0tYwYXDsisUF7f5DgdseclHrNRAKx0FHTlwxJHK4Du6d8/NJgKg?= =?us-ascii?Q?ErsjsCU5OmxJAqck1BQF9YrIf8waMwMNXzq3JmszYlX5IOiow3VtTe+yrEiD?= =?us-ascii?Q?xe+b4c60etWqZWLfd17K3hKMLp91t/Pv9eZMLBGLLcEuNN8+aLfZq4T/2DNl?= =?us-ascii?Q?XhO8WRbxQBdoF3jQg7GYZl/zflUP+fPJxyCTke4PeQx++stU+7YWgNPmoOe9?= =?us-ascii?Q?+Cp6bPfuzyEa3sVlXrtWJrr5meaIfn2e7OEDLjRiB+n4Yx5kcj5wM4gcYuMd?= =?us-ascii?Q?1irtR2esoni04MEILGk=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2025 10:49:55.5093 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 12248135-6264-42ef-ae65-08de28228ad8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003439.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB9045 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org When representor matching is disabled with dv_xmeta_en=4, the Tx metadata copy flows use SQ (send queue) pattern matching, but the pattern template was still configured to use ETH match-all pattern. This mismatch causes hardware to reject the flows with error CQEs during port configuration. This patch fixes the issue by using SQ-based pattern template (flow_hw_create_tx_repr_sq_pattern_tmpl) instead of the ETH match-all template (flow_hw_create_tx_default_mreg_copy_pattern_template). Fixes: 593fb3fdfa10 ("net/mlx5: fix multi process Tx default rules") Signed-off-by: Shani Peretz Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 42 +-------------------------------- 1 file changed, 1 insertion(+), 41 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 208f50fbfd..b64ba9b46b 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -10185,46 +10185,6 @@ flow_hw_create_ctrl_port_pattern_template(struct rte_eth_dev *dev, return flow_hw_pattern_template_create(dev, &attr, items, error); } -/* - * Creating a flow pattern template with all ETH packets matching. - * This template is used to set up a table for default Tx copy (Tx metadata - * to REG_C_1) flow rule usage. - * - * @param dev - * Pointer to Ethernet device. - * @param error - * Pointer to error structure. - * - * @return - * Pointer to flow pattern template on success, NULL otherwise. - */ -static struct rte_flow_pattern_template * -flow_hw_create_tx_default_mreg_copy_pattern_template(struct rte_eth_dev *dev, - struct rte_flow_error *error) -{ - struct rte_flow_pattern_template_attr tx_pa_attr = { - .relaxed_matching = 0, - .egress = 1, - }; - struct rte_flow_item_eth promisc = { - .hdr.dst_addr.addr_bytes = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }, - .hdr.src_addr.addr_bytes = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }, - .hdr.ether_type = 0, - }; - struct rte_flow_item eth_all[] = { - [0] = { - .type = RTE_FLOW_ITEM_TYPE_ETH, - .spec = &promisc, - .mask = &promisc, - }, - [1] = { - .type = RTE_FLOW_ITEM_TYPE_END, - }, - }; - - return flow_hw_pattern_template_create(dev, &tx_pa_attr, eth_all, error); -} - /* * Creating a flow pattern template with all LACP packets matching, only for NIC * ingress domain. @@ -10930,7 +10890,7 @@ flow_hw_create_fdb_ctrl_tables(struct rte_eth_dev *dev, struct rte_flow_error *e /* Create templates and table for default Tx metadata copy flow rule. */ if (!repr_matching && xmeta == MLX5_XMETA_MODE_META32_HWS) { hw_ctrl_fdb->tx_meta_items_tmpl = - flow_hw_create_tx_default_mreg_copy_pattern_template(dev, error); + flow_hw_create_tx_repr_sq_pattern_tmpl(dev, error); if (!hw_ctrl_fdb->tx_meta_items_tmpl) { DRV_LOG(ERR, "port %u failed to Tx metadata copy pattern" " template for control flows", dev->data->port_id); -- 2.34.1