From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E06448B59 for ; Thu, 20 Nov 2025 13:46:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08E0140262; Thu, 20 Nov 2025 13:46:07 +0100 (CET) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mails.dpdk.org (Postfix) with ESMTP id 169DB40262 for ; Thu, 20 Nov 2025 13:46:06 +0100 (CET) Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-429c48e05aeso535123f8f.1 for ; Thu, 20 Nov 2025 04:46:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763642766; x=1764247566; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OYWbQjPl7zrsZL0C74SA+tpNIUAi6EXT8jKuUfKUV+E=; b=kHCwXZAqppbCD8XEvXadgQkBsLZ4cGHi4v+DvYGhFiek9A+/1Lio+AQiP9jmxiMdyo 3xlxqtt6fEepqq0DfoeKIsEForUJCvGT/SmOLGe2FCAY8sZFMa+BuY/0HH3fA3WQ43SE syX1Er4FUj46oS5brY2gyue6+sIltJzhIeAeH8m3OTVEbcB5ofAwSOqDWiJlb7adWdkt B9XF2nbR/vJlz3OedmxNa6Uit1qdk3My2g+f/IlM8lV5uEeX6vRUPNJoRCbLtScZsMGZ mY4FXAGFXBP3SaBhk+YmmzwoYLBKcneh9NJ6SD/QqyMdNRnA2JLVpbjVJ0zwlgUpLDJV SwwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763642766; x=1764247566; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OYWbQjPl7zrsZL0C74SA+tpNIUAi6EXT8jKuUfKUV+E=; b=Q5fVVG1wwiez2Zd3YtgfAITas+8jwqXN3lGmiRcE2CVH6EcmMRYQQ5xx7v+ZhbK2yK WTwJKk8saIsNF3ZBEVVIBur+mhw4ip5vwpxs/dXky/QRWUOphpfqxNv+jPS79esjbW5R 0ubu+/EWdWZpe0RZvhIsDRf/vU1e1u5Vn8K+1wmhSkc+L2VPW5L+Yu4+ZPFbXvCSMp2k Hr3tdVmOZTRzehwFMmZmlr9uATwK68nMAjyTUL33T1GAZrr9pQmaOlYiL07jt8f6ECmm Aeh6kJmAvM3dCJ48NYEjdjShNlbYiitu5AoeIdI8p5R6Vk/tVTSYSnOOUwNnI3Uqx20L DiBA== X-Forwarded-Encrypted: i=1; AJvYcCUoQykbSVAczpHzzff7fsZ3sz4lSMt91jBypkPtkt9rq/+/7klt4p3YPyZKe41Mn1oz94i2Y/k=@dpdk.org X-Gm-Message-State: AOJu0YwUA/S3Smxc1XSyZW6hAVbpUtHIvGMp7DiW6Hu6y7mX74OE399S YoDhH9b/w4OYNhK1n4rb9GDDhbFb1zK24lojT7XTAytXDhUEuBKaJhdN X-Gm-Gg: ASbGncvDoIcxH5eTDXV5rI013QD7MlYAXb2CNmLOsdSwtSy57QFVWs/QMRvt2c3owQk SqQGsEQIUSyQgg9ERmeAxaXRZ1rGoq5WLpw45vtO7vRa+SCON9cz3YIOkSD1PQscFBX5zb7D9vi Q91cNAnBwxhgJ+ZckZmrGvA6n/1NC/AFYjgXI+UxcZmu9tGSiRPBQDvqePOHj9VDUyY/OaCQLlA 8Etm9YIZ6bBBrbKDIDMlR6WRd7AVKg8q2R05SzzoFeYqwQ0Q3ZQqAzZQbtJvF+blNCIDzX0KZkE ZjMUrjQR3yBIAc8f8J9mCMkpgmukhg/44GyC/3ouA+f13xNta0z0oULhrB/ChYJulCRS4nLIDDY iCmuX+W/Cb8auCVJ5d6IZOA05caTQ1qPDhu6Ncsb2/sRY35lQ6a2ySpFFSseKyt4Qq99F7Jn0p7 uZuJArIEwMtuRyB/vy X-Google-Smtp-Source: AGHT+IEr2ft6UlPAZENgqqO9txpxcFc6GkflPIuqusIBm2QEwaAeXjuwb0d1f8GOl0IiJwtosIqBSA== X-Received: by 2002:a05:6000:2911:b0:429:cfa3:5fde with SMTP id ffacd0b85a97d-42cba652baamr3026611f8f.11.1763642765508; Thu, 20 Nov 2025 04:46:05 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:f372:8d1a:399f:e8a2]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42cb7f3635bsm5420541f8f.17.2025.11.20.04.46.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 04:46:05 -0800 (PST) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Raslan Darawsheh , dpdk stable Subject: patch 'net/mlx5: fix uninitialized variable' has been queued to stable release 22.11.11 Date: Thu, 20 Nov 2025 12:44:48 +0000 Message-ID: <20251120124514.757933-16-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251120124514.757933-1-luca.boccassi@gmail.com> References: <20251112165308.1618107-49-luca.boccassi@gmail.com> <20251120124514.757933-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/22/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/69e05c73713e2eaf771b8c908364dabb8b71d4e8 Thanks. Luca Boccassi --- >From 69e05c73713e2eaf771b8c908364dabb8b71d4e8 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 14 Nov 2025 09:49:12 -0800 Subject: [PATCH] net/mlx5: fix uninitialized variable [ upstream commit 7429374afba9827a43cf2efabce14e27ccc4bdef ] Gcc-16 detects use of uninitialized variable. If the retry loop exits the code would do memcmp against uninitialized stack value. Resolve by initializing to zero. Bugzilla ID: 1823 Fixes: 1256805dd54d ("net/mlx5: move Linux-specific functions") Fixes: cfee94752b8f ("net/mlx5: fix link status to use wait to complete") Signed-off-by: Stephen Hemminger Acked-by: Raslan Darawsheh --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c index ea89ce8e05..a9a12c87dc 100644 --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c @@ -647,7 +647,7 @@ int mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete) { int ret; - struct rte_eth_link dev_link; + struct rte_eth_link dev_link = { 0 }; time_t start_time = time(NULL); int retry = MLX5_GET_LINK_STATUS_RETRY_COUNT; @@ -2010,4 +2010,3 @@ int mlx5_txpp_map_hca_bar(struct rte_eth_dev *dev) rte_mem_unmap(base, MLX5_ST_SZ_BYTES(initial_seg)); return 0; } - -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-20 12:44:13.359024489 +0000 +++ 0016-net-mlx5-fix-uninitialized-variable.patch 2025-11-20 12:44:12.790088272 +0000 @@ -1 +1 @@ -From 7429374afba9827a43cf2efabce14e27ccc4bdef Mon Sep 17 00:00:00 2001 +From 69e05c73713e2eaf771b8c908364dabb8b71d4e8 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7429374afba9827a43cf2efabce14e27ccc4bdef ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 4d8fbed188..50997c187c 100644 +index ea89ce8e05..a9a12c87dc 100644 @@ -25 +26 @@ -@@ -512,7 +512,7 @@ int +@@ -647,7 +647,7 @@ int @@ -34 +35 @@ -@@ -2073,4 +2073,3 @@ int mlx5_txpp_map_hca_bar(struct rte_eth_dev *dev) +@@ -2010,4 +2010,3 @@ int mlx5_txpp_map_hca_bar(struct rte_eth_dev *dev)