From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AADAE48B59 for ; Thu, 20 Nov 2025 13:45:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3B9E402DC; Thu, 20 Nov 2025 13:45:23 +0100 (CET) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mails.dpdk.org (Postfix) with ESMTP id 9F707402E6 for ; Thu, 20 Nov 2025 13:45:22 +0100 (CET) Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-42b39d51dcfso524245f8f.2 for ; Thu, 20 Nov 2025 04:45:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763642722; x=1764247522; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TvJXG6kwgYFOE/OME9cmC3spftT7oOi5+6mrHihr0KA=; b=j5c3jTjfmN9bDrJVylPqB39GQZrOA7SqrCsCDxsHb6g2DmDbaZNwphHBq75+9ZF/Gh 9Ht+Vz0/dSm5OKs8q4zAGZJpxerxKA4Cszb29XsksKQ2VbYmnNrOJ05PJLYjUtOq7JwF ywu6fKR3Q9Jd2lagAsxHv1868mmnlgauVy60nUv+rAt7THQaZw+lbaaxrfBm1CJ74n6h Icdff2NYNaFDVFaATTlBENDlNqUsaFP0ib1u9h0OVHvF4yH7dQC1ucW2VbZoCh/MuGA9 A60+IpmqL+YhZYc4vbEq9kxngWagEIcfnBPyNy1HIjRtXpQBQnDvkSa4rXyXBwDakJd6 tHSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763642722; x=1764247522; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TvJXG6kwgYFOE/OME9cmC3spftT7oOi5+6mrHihr0KA=; b=H8anUVpfPSbUp20B6XJwDYrGifvYWlBHHp1TD10HPyDh+EJlBNtVx/ioScPfnx5PBj SztWcRLklbxL/cwVba362IJduoYAGLFaCuIQ4iUheeWFV3eWjV8kiKm92GzuVr98DIaJ MySWDMFrxwaHJ+oBLqsWCH0TZdnyX5IDKj6NPgGYzWOOnZ4DJ0bZs9Dy5CobterCXpXK qFxT5ef44Ek5tt9iU99Zeki2lF3RBI4vJfVvQXEogns4DN5fN4D581DK/J3jVdnF1x7M AZEbhEDHBc/fLjtAtCjSH+LjKhmzf0CAcgN3WM4qC08XQApbYBrUF7T2X8bbTCy3gDL+ b2tg== X-Gm-Message-State: AOJu0Yy2uwNLFB8qDpQt1/O0M/uPvCw2bV9YdwsKCDw/qOtM8ORs/ET2 fvh4VI8UGpntEybzviLEX/NUh4qaz0A7I+gSz7CLYETBmbFZQ4Hlj5VrlttgLad7 X-Gm-Gg: ASbGncs0abPXCgPPunsoYp9R1rX+cyAKY7xm5SRPCnzkHlYrgdQhRIJzHIvs7d0+afu 8zw6KmfgxKK3XhgTv/vWNaukVkDEQakwhYhUghzr0I11Es6FxIzQbsiPj5uBgoVnBnEMN4tNIwo abjnvaynYT3XBxSEPKnVF/Tdq5SVrFY5UDipbYc0Y79B8Jwa01/c2/0/PDeqj3LOamBwYzTJwsL 0xrD1nMBMBp310kaitqnqtjJcK5ORjWsfzDomLBV2wi88zO/od2UThqToyZUB2G6GMCuNAmqwYZ UItbuGDlCrf3Dcv9orGEjzBWpKlJULFwc2jp1huWnaRcjl/GhXNda0Z4SMpiqFBzZedgiI+nEsL YOFp5Ko5xUTPyxaJ+lgpoRO93hd3RX4QXd+H/pPG2wWstMquc3af96K//bE7/W2Ot5x0D7sL7BM w8ux+07XZJ5Uwb69bgQp+oO7ek2gQ= X-Google-Smtp-Source: AGHT+IFSww+ERut1uf/Oe8pCjjNDVjAM/GZRicBL53so1blGEekNrd7dp7VxVytFFaxwSF4c3m2bwQ== X-Received: by 2002:a05:6000:22c7:b0:427:580:998c with SMTP id ffacd0b85a97d-42cb9a4a134mr2810270f8f.43.1763642721921; Thu, 20 Nov 2025 04:45:21 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:f372:8d1a:399f:e8a2]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42cb7f3635bsm5417136f8f.17.2025.11.20.04.45.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 04:45:21 -0800 (PST) From: luca.boccassi@gmail.com To: Jacob Keller Cc: dpdk stable Subject: patch 'net/iavf: fix check for PF Rx timestamp support' has been queued to stable release 22.11.11 Date: Thu, 20 Nov 2025 12:44:37 +0000 Message-ID: <20251120124514.757933-5-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251120124514.757933-1-luca.boccassi@gmail.com> References: <20251112165308.1618107-49-luca.boccassi@gmail.com> <20251120124514.757933-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/22/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/67011def404022c502846ff358ee35a4e2c85f08 Thanks. Luca Boccassi --- >From 67011def404022c502846ff358ee35a4e2c85f08 Mon Sep 17 00:00:00 2001 From: Jacob Keller Date: Thu, 13 Nov 2025 13:33:44 -0800 Subject: [PATCH] net/iavf: fix check for PF Rx timestamp support [ upstream commit d21c2fe6e5a1ef1e7cc9490f54f359db1cfd5283 ] The iavf driver has support for hardware Rx timestamps since commit b5cd735132f6 ("net/iavf: enable Rx timestamp on flex descriptor"). To enable this, the VF must first negotiate PTP capabilities with the PF by sending the VIRTCHNL_OP_1588_PTP_GET_CAPS command, with the requested capabilities. The PF will respond with the actually supported subset of capabilities. The PF may not actually enable Rx timestamping, even if it reports the overall PTP capability support. If this happens, the iavf driver logic will incorrectly report that Rx timestamps can be enabled despite being rejected by the PF. This is unlikely in practice, as most PFs which support the VIRTCHNL_VF_CAP_PTP will support Rx timestamping. However, there are some cases where this may not be true. Check that the PF actually reports the Rx timestamping capability instead of assuming it is enabled. Doing so prevents the DPDK application from attempting to enable Rx timestamps when they won't actually be enabled. Fixes: b5cd735132f6 ("net/iavf: enable Rx timestamp on flex descriptor") Signed-off-by: Jacob Keller --- drivers/net/iavf/iavf_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 7371d2a805..6056ab961b 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -1146,7 +1146,8 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_CRC) dev_info->rx_offload_capa |= RTE_ETH_RX_OFFLOAD_KEEP_CRC; - if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_CAP_PTP) + if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_CAP_PTP && + vf->ptp_caps & VIRTCHNL_1588_PTP_CAP_RX_TSTAMP) dev_info->rx_offload_capa |= RTE_ETH_RX_OFFLOAD_TIMESTAMP; if (iavf_ipsec_crypto_supported(adapter)) { -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-20 12:44:12.978779670 +0000 +++ 0005-net-iavf-fix-check-for-PF-Rx-timestamp-support.patch 2025-11-20 12:44:12.774087887 +0000 @@ -1 +1 @@ -From d21c2fe6e5a1ef1e7cc9490f54f359db1cfd5283 Mon Sep 17 00:00:00 2001 +From 67011def404022c502846ff358ee35a4e2c85f08 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d21c2fe6e5a1ef1e7cc9490f54f359db1cfd5283 ] + @@ -29 +30,0 @@ -Cc: stable@dpdk.org @@ -33 +34 @@ - drivers/net/intel/iavf/iavf_ethdev.c | 3 ++- + drivers/net/iavf/iavf_ethdev.c | 3 ++- @@ -36,5 +37,5 @@ -diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c -index 15e49fe248..3ef766de47 100644 ---- a/drivers/net/intel/iavf/iavf_ethdev.c -+++ b/drivers/net/intel/iavf/iavf_ethdev.c -@@ -1177,7 +1177,8 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) +diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c +index 7371d2a805..6056ab961b 100644 +--- a/drivers/net/iavf/iavf_ethdev.c ++++ b/drivers/net/iavf/iavf_ethdev.c +@@ -1146,7 +1146,8 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) @@ -49 +50 @@ - if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_VLAN_V2 && + if (iavf_ipsec_crypto_supported(adapter)) {