From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C25F48B69 for ; Fri, 21 Nov 2025 12:22:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54F4B402E6; Fri, 21 Nov 2025 12:22:29 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 29BA2402D7 for ; Fri, 21 Nov 2025 12:22:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NskU4XdC1TBWWOZ+EnhfLWzWJlvu3JpHxh2c+fYMk+g=; b=QXP3/3ZCLZJYkXFFkdoWIkYc645W7+mGSRzYg7Hf7FG05v/OBYeUGsuDOMYAEASKpgOya+ pXgZROJrtClx8tVY/VQaqwRGZ3cAb43tQ5T8SY9HaI4m+y0xVs1EtI+CqP5P10WF157G+s j3D8tqneo7TOfsuduW7//Z7WJ0hF2S4= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-325-dBIzJJxkNgyImwfpUcx23Q-1; Fri, 21 Nov 2025 06:22:23 -0500 X-MC-Unique: dBIzJJxkNgyImwfpUcx23Q-1 X-Mimecast-MFC-AGG-ID: dBIzJJxkNgyImwfpUcx23Q_1763724142 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B1A7E1954231; Fri, 21 Nov 2025 11:22:21 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A58C130044DB; Fri, 21 Nov 2025 11:22:20 +0000 (UTC) From: Kevin Traynor To: Thomas Monjalon Cc: dpdk stable Subject: patch 'common/mlx5: remove useless constants' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:19:58 +0000 Message-ID: <20251121112128.485623-14-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JbKn_LznCYHL29kIFR_4ZlvF-lbpw8h_HN188CkWwTA_1763724142 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/726043eedb348e4cd7ba144a30643a90fece2ae7 Thanks. Kevin --- >From 726043eedb348e4cd7ba144a30643a90fece2ae7 Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Fri, 31 Oct 2025 21:38:10 +0100 Subject: [PATCH] common/mlx5: remove useless constants [ upstream commit 5f961fec22ff6903f2a11ffdc5ffef9c8c50cb5b ] All these constants were unused since their introduction: - MLX5_DRV_PROBE_AGAIN - MLX5_NL_BUF_SIZE - MLX5DV_FLOW_TABLE_TYPE_RDMA_RX - IB_QPT_RAW_PACKET Fixes: ad435d320473 ("common/mlx5: add bus-agnostic layer") Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses") Fixes: 03e1f7f760d8 ("net/mlx5: create flow matcher object on Windows") Fixes: 358fbb018310 ("net/mlx5: support multi-packet Rx queue on Windows") Signed-off-by: Thomas Monjalon --- drivers/common/mlx5/linux/mlx5_nl.c | 2 -- drivers/common/mlx5/mlx5_common.h | 3 --- drivers/common/mlx5/windows/mlx5_win_defs.h | 2 -- 3 files changed, 7 deletions(-) diff --git a/drivers/common/mlx5/linux/mlx5_nl.c b/drivers/common/mlx5/linux/mlx5_nl.c index 6824ea322d..a9a5bc5108 100644 --- a/drivers/common/mlx5/linux/mlx5_nl.c +++ b/drivers/common/mlx5/linux/mlx5_nl.c @@ -28,6 +28,4 @@ -/* Size of the buffer to receive kernel messages */ -#define MLX5_NL_BUF_SIZE (32 * 1024) /* Send buffer size for the Netlink socket */ #define MLX5_SEND_BUF_SIZE 32768 diff --git a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h index 304cabcc7e..22a276e559 100644 --- a/drivers/common/mlx5/mlx5_common.h +++ b/drivers/common/mlx5/mlx5_common.h @@ -559,7 +559,4 @@ typedef int (mlx5_class_driver_probe_t)(struct mlx5_common_device *cdev, typedef int (mlx5_class_driver_remove_t)(struct mlx5_common_device *cdev); -/** Device already probed can be probed again to check for new ports. */ -#define MLX5_DRV_PROBE_AGAIN 0x0004 - /** * A structure describing a mlx5 common class driver. diff --git a/drivers/common/mlx5/windows/mlx5_win_defs.h b/drivers/common/mlx5/windows/mlx5_win_defs.h index d60df6fd37..d98725eea8 100644 --- a/drivers/common/mlx5/windows/mlx5_win_defs.h +++ b/drivers/common/mlx5/windows/mlx5_win_defs.h @@ -185,5 +185,4 @@ enum mlx5dv_flow_table_type { #define MLX5DV_FLOW_TABLE_TYPE_NIC_TX MLX5_IB_UAPI_FLOW_TABLE_TYPE_NIC_TX #define MLX5DV_FLOW_TABLE_TYPE_FDB MLX5_IB_UAPI_FLOW_TABLE_TYPE_FDB -#define MLX5DV_FLOW_TABLE_TYPE_RDMA_RX MLX5_IB_UAPI_FLOW_TABLE_TYPE_RDMA_RX struct mlx5dv_flow_match_parameters { @@ -264,5 +263,4 @@ enum { #define MLX5_MAX_SINGLE_STRIDE_LOG_NUM_BYTES 13 #define MLX5_EXT_MIN_SINGLE_WQE_LOG_NUM_STRIDES 3 -#define IB_QPT_RAW_PACKET 8 #endif /* MLX5_WIN_DEFS_H */ -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:10.066224182 +0000 +++ 0014-common-mlx5-remove-useless-constants.patch 2025-11-21 11:05:09.375200794 +0000 @@ -1 +1 @@ -From 5f961fec22ff6903f2a11ffdc5ffef9c8c50cb5b Mon Sep 17 00:00:00 2001 +From 726043eedb348e4cd7ba144a30643a90fece2ae7 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 5f961fec22ff6903f2a11ffdc5ffef9c8c50cb5b ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index 8753d3127c..d53543a113 100644 +index 6824ea322d..a9a5bc5108 100644 @@ -30 +31 @@ -@@ -29,6 +29,4 @@ +@@ -28,6 +28,4 @@ @@ -38 +39 @@ -index b49f0c850e..214ddcb8b3 100644 +index 304cabcc7e..22a276e559 100644 @@ -41 +42 @@ -@@ -576,7 +576,4 @@ typedef int (mlx5_class_driver_probe_t)(struct mlx5_common_device *cdev, +@@ -559,7 +559,4 @@ typedef int (mlx5_class_driver_probe_t)(struct mlx5_common_device *cdev,