From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E906148B69 for ; Fri, 21 Nov 2025 12:22:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E443F402DB; Fri, 21 Nov 2025 12:22:37 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 70F8E4026F for ; Fri, 21 Nov 2025 12:22:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z/motee+x9iIbjenQxE1OeOB/ZjP6mwqSB6loH4DTUI=; b=FLYVpkB1LKoimPewNbmgqH9w/1Cj0Eccdvpsz6k8/iMjfga5/EhOUHvZLP9Fsr1jZbK8z7 FtzO+Xaf2YeqN/d1GfnkGTFz8A0OgexU9ZrQiasen3lgZolpavtEkQJ+zdKMGmZQZsk1jj gbavFKnEhFXfr0rXj78m5iv185I5ro8= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-425-69d3xUy7OWuRQf6CHLqFdw-1; Fri, 21 Nov 2025 06:22:34 -0500 X-MC-Unique: 69d3xUy7OWuRQf6CHLqFdw-1 X-Mimecast-MFC-AGG-ID: 69d3xUy7OWuRQf6CHLqFdw_1763724154 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 04E3F180120E; Fri, 21 Nov 2025 11:22:34 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D327F30044DB; Fri, 21 Nov 2025 11:22:32 +0000 (UTC) From: Kevin Traynor To: Vanshika Shukla Cc: dpdk stable Subject: patch 'net/dpaa: fix resource leak' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:20:05 +0000 Message-ID: <20251121112128.485623-21-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Bk_IrW3FW6OFMEWBHmU-pdG8T4MhZY4MAJVj8SqrTAk_1763724154 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/3bba147837210cf9ee4125f81076fe6defa61f4b Thanks. Kevin --- >From 3bba147837210cf9ee4125f81076fe6defa61f4b Mon Sep 17 00:00:00 2001 From: Vanshika Shukla Date: Fri, 24 Oct 2025 11:49:06 +0530 Subject: [PATCH] net/dpaa: fix resource leak [ upstream commit e7665de896836e99866ef8016bbaa12223e1cfb7 ] This patch correct the cleanup order of PCD and FMan handles to prevent resource leaks reported by coverity tool. Coverity issue: 362787 Fixes: 4defbc8cbb6d ("net/dpaa: support FMCless mode") Signed-off-by: Vanshika Shukla --- drivers/net/dpaa/dpaa_flow.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dpaa/dpaa_flow.c b/drivers/net/dpaa/dpaa_flow.c index 2a22b23c8f..417b9b6fbb 100644 --- a/drivers/net/dpaa/dpaa_flow.c +++ b/drivers/net/dpaa/dpaa_flow.c @@ -1,4 +1,4 @@ /* SPDX-License-Identifier: BSD-3-Clause - * Copyright 2017-2019,2021-2024 NXP + * Copyright 2017-2019,2021-2025 NXP */ @@ -890,7 +890,7 @@ int dpaa_fm_init(void) ret = fm_pcd_enable(pcd_handle); if (ret) { - fm_close(fman_handle); - fm_pcd_close(pcd_handle); DPAA_PMD_ERR("fm_pcd_enable: Failed"); + fm_pcd_close(pcd_handle); + fm_close(fman_handle); return -1; } -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:10.271687882 +0000 +++ 0021-net-dpaa-fix-resource-leak.patch 2025-11-21 11:05:09.392200866 +0000 @@ -1 +1 @@ -From e7665de896836e99866ef8016bbaa12223e1cfb7 Mon Sep 17 00:00:00 2001 +From 3bba147837210cf9ee4125f81076fe6defa61f4b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit e7665de896836e99866ef8016bbaa12223e1cfb7 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org