From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8838548B69 for ; Fri, 21 Nov 2025 12:22:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 823E74026F; Fri, 21 Nov 2025 12:22:49 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6568F402DB for ; Fri, 21 Nov 2025 12:22:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kVggAOTwBRyBDR+L7V47/Aku4kQBGFwSS7NA2s9/Bao=; b=hC/VUL4ViIT4w5fMnFGGa+lL6877HghI9jdCrAeT+PMY9KmcPjMdU9DX5NuMBGgIPb0P3T 0vFhKureisEgSVMzCAcHaCstZk9cl5I0VF9s1sNokOK+fzncrqV5dVx4ZJnlM8OHJCeiAN Rd6E8E+Fe1Y6emXXd8B8fTR8x5YghhE= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-634-SYMZO0OQMvyr_zmsT_I7LQ-1; Fri, 21 Nov 2025 06:22:42 -0500 X-MC-Unique: SYMZO0OQMvyr_zmsT_I7LQ-1 X-Mimecast-MFC-AGG-ID: SYMZO0OQMvyr_zmsT_I7LQ_1763724161 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8FB2D1956050; Fri, 21 Nov 2025 11:22:41 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6B9F430044DB; Fri, 21 Nov 2025 11:22:40 +0000 (UTC) From: Kevin Traynor To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/ngbe: reduce memory size of ring descriptors' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:20:09 +0000 Message-ID: <20251121112128.485623-25-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: N2SExYIn2aUHh7TWPk0YgNhtjn5sxEvoSK_yqfq9gFU_1763724161 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/899e35e519d9a687d20c00830efb6bc73803d8a7 Thanks. Kevin --- >From 899e35e519d9a687d20c00830efb6bc73803d8a7 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Mon, 27 Oct 2025 11:15:27 +0800 Subject: [PATCH] net/ngbe: reduce memory size of ring descriptors [ upstream commit 22d4fffbbc99ef2a229869e717a12b2e33c68a9c ] The memory of ring descriptors was allocated in size of the maximum ring size. It seems not friendly to our hardware on some domestic platforms. Change it to allocate in size of the real ring size. Fixes: 43b7e5ea60ac ("net/ngbe: support Rx queue setup/release") Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_rxtx.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/net/ngbe/ngbe_rxtx.c b/drivers/net/ngbe/ngbe_rxtx.c index 42cb33dbfe..467f1cc9c8 100644 --- a/drivers/net/ngbe/ngbe_rxtx.c +++ b/drivers/net/ngbe/ngbe_rxtx.c @@ -2059,11 +2059,7 @@ ngbe_dev_tx_queue_setup(struct rte_eth_dev *dev, return -ENOMEM; - /* - * Allocate Tx ring hardware descriptors. A memzone large enough to - * handle the maximum ring size is allocated in order to allow for - * resizing in later calls to the queue setup function. - */ + /* Allocate Tx ring hardware descriptors. */ tz = rte_eth_dma_zone_reserve(dev, "tx_ring", queue_idx, - sizeof(struct ngbe_tx_desc) * NGBE_RING_DESC_MAX, + sizeof(struct ngbe_tx_desc) * nb_desc, NGBE_ALIGN, socket_id); if (tz == NULL) { @@ -2325,4 +2321,5 @@ ngbe_dev_rx_queue_setup(struct rte_eth_dev *dev, struct ngbe_adapter *adapter = ngbe_dev_adapter(dev); uint64_t offloads; + uint32_t size; PMD_INIT_FUNC_TRACE(); @@ -2358,11 +2355,8 @@ ngbe_dev_rx_queue_setup(struct rte_eth_dev *dev, rxq->offloads = offloads; - /* - * Allocate Rx ring hardware descriptors. A memzone large enough to - * handle the maximum ring size is allocated in order to allow for - * resizing in later calls to the queue setup function. - */ + /* Allocate Rx ring hardware descriptors. */ + size = (nb_desc + RTE_PMD_NGBE_RX_MAX_BURST) * sizeof(struct ngbe_rx_desc); rz = rte_eth_dma_zone_reserve(dev, "rx_ring", queue_idx, - RX_RING_SZ, NGBE_ALIGN, socket_id); + size, NGBE_ALIGN, socket_id); if (rz == NULL) { ngbe_rx_queue_release(rxq); @@ -2374,5 +2368,5 @@ ngbe_dev_rx_queue_setup(struct rte_eth_dev *dev, * Zero init all the descriptors in the ring. */ - memset(rz->addr, 0, RX_RING_SZ); + memset(rz->addr, 0, size); rxq->rdt_reg_addr = NGBE_REG_ADDR(hw, NGBE_RXWP(rxq->reg_idx)); -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:10.396695281 +0000 +++ 0025-net-ngbe-reduce-memory-size-of-ring-descriptors.patch 2025-11-21 11:05:09.408200935 +0000 @@ -1 +1 @@ -From 22d4fffbbc99ef2a229869e717a12b2e33c68a9c Mon Sep 17 00:00:00 2001 +From 899e35e519d9a687d20c00830efb6bc73803d8a7 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 22d4fffbbc99ef2a229869e717a12b2e33c68a9c ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index a60421293b..03ada844bf 100644 +index 42cb33dbfe..467f1cc9c8 100644