From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AEE048B69 for ; Fri, 21 Nov 2025 12:22:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1289B402E0; Fri, 21 Nov 2025 12:22:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1A822402E5 for ; Fri, 21 Nov 2025 12:22:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l8CCOx9Y8ZyTJHwI67W1NF/d2N9/Y+Wq1o1fNeInzx8=; b=XjluGecl5EkTjtt4zX9CnfRS99IJ5+5trqT10G8JFnQQBwcvRWt5uxeMavOoWn2K1VzwMp AfY3yfJ1hiqjZvViKpVUVHyiywv7/V0k7nK9vQAk/7dj74/OO39Hd4avBprMT9l/Igt73F 0jxScEN+xoMNwCrrbi/K4OJnw8YTi/I= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-527--bRty9TOP1mLHjMb9o2RBQ-1; Fri, 21 Nov 2025 06:22:51 -0500 X-MC-Unique: -bRty9TOP1mLHjMb9o2RBQ-1 X-Mimecast-MFC-AGG-ID: -bRty9TOP1mLHjMb9o2RBQ_1763724170 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 48A0F1954B14; Fri, 21 Nov 2025 11:22:50 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 23A7230044DB; Fri, 21 Nov 2025 11:22:48 +0000 (UTC) From: Kevin Traynor To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/txgbe: fix FDIR mode clearing' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:20:14 +0000 Message-ID: <20251121112128.485623-30-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Yb0fHbjdqiCLe_NoAG903qHgo8VVUY-a96CqANvcEkY_1763724170 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/0609d9f76299085f3d7a885bf0202a8b58d88647 Thanks. Kevin --- >From 0609d9f76299085f3d7a885bf0202a8b58d88647 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Mon, 27 Oct 2025 11:15:33 +0800 Subject: [PATCH] net/txgbe: fix FDIR mode clearing [ upstream commit 26048c25942f2579a821a99b78db48fdb2c90c77 ] When FDIR flow rules are all cleared, FDIR mode is not cleared. This will cause that creating new FDIR flow rules failed, for their mode are different from the previously deleted ones. Fixes: 6bde42fe7fa5 ("net/txgbe: flush all filters") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_fdir.c | 1 + drivers/net/txgbe/txgbe_flow.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/net/txgbe/txgbe_fdir.c b/drivers/net/txgbe/txgbe_fdir.c index 631dec69e8..77d0cc4c30 100644 --- a/drivers/net/txgbe/txgbe_fdir.c +++ b/drivers/net/txgbe/txgbe_fdir.c @@ -971,4 +971,5 @@ txgbe_clear_all_fdir_filter(struct rte_eth_dev *dev) sizeof(struct txgbe_fdir_filter *) * ((1024 << (fdir_conf->pballoc + 1)) - 2)); + fdir_conf->mode = RTE_FDIR_MODE_NONE; filter_flag = TAILQ_FIRST(&fdir_info->fdir_list); while ((fdir_filter = TAILQ_FIRST(&fdir_info->fdir_list))) { diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c index 7482cbbf63..9b7643c6e2 100644 --- a/drivers/net/txgbe/txgbe_flow.c +++ b/drivers/net/txgbe/txgbe_flow.c @@ -3427,4 +3427,5 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, struct txgbe_flow_mem *txgbe_flow_mem_ptr; struct txgbe_hw_fdir_info *fdir_info = TXGBE_DEV_FDIR(dev); + struct rte_eth_fdir_conf *fdir_conf = TXGBE_DEV_FDIR_CONF(dev); struct txgbe_rss_conf_ele *rss_filter_ptr; @@ -3486,4 +3487,5 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, fdir_info->flex_relative = false; fdir_info->flex_bytes_offset = 0; + fdir_conf->mode = RTE_FDIR_MODE_NONE; } } -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:10.546705384 +0000 +++ 0030-net-txgbe-fix-FDIR-mode-clearing.patch 2025-11-21 11:05:09.420200986 +0000 @@ -1 +1 @@ -From 26048c25942f2579a821a99b78db48fdb2c90c77 Mon Sep 17 00:00:00 2001 +From 0609d9f76299085f3d7a885bf0202a8b58d88647 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 26048c25942f2579a821a99b78db48fdb2c90c77 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -30 +31 @@ -index 31af3593ed..25cf0db316 100644 +index 7482cbbf63..9b7643c6e2 100644 @@ -33 +34 @@ -@@ -3430,4 +3430,5 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, +@@ -3427,4 +3427,5 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, @@ -39 +40 @@ -@@ -3489,4 +3490,5 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, +@@ -3486,4 +3487,5 @@ txgbe_flow_destroy(struct rte_eth_dev *dev,