From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C3D648B69 for ; Fri, 21 Nov 2025 12:23:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4566A402E6; Fri, 21 Nov 2025 12:23:11 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BF28E40395 for ; Fri, 21 Nov 2025 12:23:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mfLwS1TVnSzVzYfhVumCgU1Tvm+Gsf1va+Jfz9uiIs0=; b=NtZDrWFNZtbkvbUGWQy3ggFwM8r2CY2oXVmncOZNXj/YC8mlJvGBEMrHIGy0bonf64dXGP AoF7i2FWz+9Dh9j2y6rfj7wZ33gT4Gw/fyhAZzUHReW5+wgIz9Dzw3g776wlxplx4vGMD4 aMAxHXuo+iTKDBUSqPsa/qwn/IOZFUE= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-548-55QgywcBPoOAN0lZzXFxPg-1; Fri, 21 Nov 2025 06:23:05 -0500 X-MC-Unique: 55QgywcBPoOAN0lZzXFxPg-1 X-Mimecast-MFC-AGG-ID: 55QgywcBPoOAN0lZzXFxPg_1763724185 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0995A1956073; Fri, 21 Nov 2025 11:23:05 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F2AC530044E8; Fri, 21 Nov 2025 11:23:03 +0000 (UTC) From: Kevin Traynor To: Shani Peretz Cc: dpdk stable Subject: patch 'net/bonding: fix MAC address propagation in 802.3ad mode' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:20:23 +0000 Message-ID: <20251121112128.485623-39-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rr6qVo88YODNysXkYGwShDg9VoBLQ2unFmdfKeFHm7w_1763724185 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/0e99c1629e4f6ae1568e40484e571ffbecaf6947 Thanks. Kevin --- >From 0e99c1629e4f6ae1568e40484e571ffbecaf6947 Mon Sep 17 00:00:00 2001 From: Shani Peretz Date: Wed, 5 Nov 2025 20:01:35 +0200 Subject: [PATCH] net/bonding: fix MAC address propagation in 802.3ad mode [ upstream commit 8a2f21630658a7f3ff5c7564b9a2bcb0b681fb55 ] When changing the MAC address of a bonding device in 802.3ad mode, the new MAC was not propagated to the physical member NIC. This caused the physical NIC to drop all data packets sent to the new MAC address, resulting in connectivity loss. It happens because the MAC update function only updated the LACP layer (actor.system) but not the physical NIC hardware MAC addresses. This fix adds a call to rte_eth_dev_default_mac_addr_set() to update the hardware MAC on each member port. Bugzilla ID: 1158 Fixes: 46fb43683679 ("bond: add mode 4") Signed-off-by: Shani Peretz --- drivers/net/bonding/rte_eth_bond_8023ad.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index 7f885ab521..cb71515bff 100644 --- a/drivers/net/bonding/rte_eth_bond_8023ad.c +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c @@ -1186,4 +1186,12 @@ bond_mode_8023ad_mac_address_update(struct rte_eth_dev *bond_dev) rte_ether_addr_copy(&internals->mode4.mac_addr, &member->actor.system); + + /* Update physical NIC hardware MAC address to match bonding device. */ + if (rte_eth_dev_default_mac_addr_set(member_id, &internals->mode4.mac_addr) != 0) { + RTE_BOND_LOG(ERR, + "Failed to update MAC address on member port %u", + member_id); + } + /* Do nothing if this port is not an aggregator. In other case * Set NTT flag on every port that use this aggregator. */ -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:10.807425810 +0000 +++ 0039-net-bonding-fix-MAC-address-propagation-in-802.3ad-m.patch 2025-11-21 11:05:09.435201050 +0000 @@ -1 +1 @@ -From 8a2f21630658a7f3ff5c7564b9a2bcb0b681fb55 Mon Sep 17 00:00:00 2001 +From 0e99c1629e4f6ae1568e40484e571ffbecaf6947 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8a2f21630658a7f3ff5c7564b9a2bcb0b681fb55 ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index 1677615435..ba88f6d261 100644 +index 7f885ab521..cb71515bff 100644 @@ -31 +32 @@ -@@ -1187,4 +1187,12 @@ bond_mode_8023ad_mac_address_update(struct rte_eth_dev *bond_dev) +@@ -1186,4 +1186,12 @@ bond_mode_8023ad_mac_address_update(struct rte_eth_dev *bond_dev)