From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22B3248B69 for ; Fri, 21 Nov 2025 12:22:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D9B94026F; Fri, 21 Nov 2025 12:22:11 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 02680402D4 for ; Fri, 21 Nov 2025 12:22:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2l1UR0Y+By5Qu9O39Fm9nsZ5GGyrzlyyk2OTMRmclas=; b=IHBEUWFuaM8eyHikiZVDPiLPlx5DZ0merd3r5ClabDoUE7ZWZ6rFRegFquWSvYAKzf/ECi d9doJY13xUdsVvsUna8PVpjeyQl35TswL3bbsHIzjBMWVBCgsdNZsAL9kMmT4NsFCBXSno byLnYnQkv2YU7Z8i4z2J8GsBI0NdACo= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-199-8vL2v1EYMUaxeTJyG3H_vQ-1; Fri, 21 Nov 2025 06:22:03 -0500 X-MC-Unique: 8vL2v1EYMUaxeTJyG3H_vQ-1 X-Mimecast-MFC-AGG-ID: 8vL2v1EYMUaxeTJyG3H_vQ_1763724122 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1082619560B7; Fri, 21 Nov 2025 11:22:02 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C709930044DB; Fri, 21 Nov 2025 11:22:00 +0000 (UTC) From: Kevin Traynor To: Anatoly Burakov Cc: Nipun Gupta , dpdk stable Subject: patch 'bus/cdx: fix release in probing for secondary process' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:19:48 +0000 Message-ID: <20251121112128.485623-4-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AoyG2BA_si4PwbA7yBH9vKYWYZ9bw5I0-LrDcFw-g7E_1763724122 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/8bd7087215b9f9a96a9d6c0e0b848668e51a9bf9 Thanks. Kevin --- >From 8bd7087215b9f9a96a9d6c0e0b848668e51a9bf9 Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Fri, 24 Oct 2025 10:53:10 +0100 Subject: [PATCH] bus/cdx: fix release in probing for secondary process [ upstream commit ad13df8e9379c5f17e6548eca1ae829f71795fde ] The variable cdx_addr is a stack-allocated zero-initialized char array, but it is never used anywhere except in an error handler to stand it as a device bus address for a VFIO device release call. This is incorrect, as it should have been actual device address, so fix the code to reflect that. Fixes: 45ef232af515 ("bus/cdx: introduce AMD CDX bus") Signed-off-by: Anatoly Burakov Acked-by: Nipun Gupta --- drivers/bus/cdx/cdx_vfio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/bus/cdx/cdx_vfio.c b/drivers/bus/cdx/cdx_vfio.c index 2c224bfef0..8f594d6391 100644 --- a/drivers/bus/cdx/cdx_vfio.c +++ b/drivers/bus/cdx/cdx_vfio.c @@ -482,5 +482,4 @@ cdx_vfio_map_resource_secondary(struct rte_cdx_device *dev) { struct vfio_device_info device_info = { .argsz = sizeof(device_info) }; - char cdx_addr[PATH_MAX] = {0}; int vfio_dev_fd; int i, ret; @@ -533,5 +532,5 @@ cdx_vfio_map_resource_secondary(struct rte_cdx_device *dev) return 0; err_vfio_dev_fd: - rte_vfio_release_device(RTE_CDX_BUS_DEVICES_PATH, cdx_addr, vfio_dev_fd); + rte_vfio_release_device(RTE_CDX_BUS_DEVICES_PATH, dev_name, vfio_dev_fd); return -1; } -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:09.777895124 +0000 +++ 0004-bus-cdx-fix-release-in-probing-for-secondary-process.patch 2025-11-21 11:05:09.359200726 +0000 @@ -1 +1 @@ -From ad13df8e9379c5f17e6548eca1ae829f71795fde Mon Sep 17 00:00:00 2001 +From 8bd7087215b9f9a96a9d6c0e0b848668e51a9bf9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ad13df8e9379c5f17e6548eca1ae829f71795fde ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index a3cf53b6a6..11fe3265d2 100644 +index 2c224bfef0..8f594d6391 100644 @@ -24 +25 @@ -@@ -486,5 +486,4 @@ cdx_vfio_map_resource_secondary(struct rte_cdx_device *dev) +@@ -482,5 +482,4 @@ cdx_vfio_map_resource_secondary(struct rte_cdx_device *dev) @@ -30 +31 @@ -@@ -537,5 +536,5 @@ cdx_vfio_map_resource_secondary(struct rte_cdx_device *dev) +@@ -533,5 +532,5 @@ cdx_vfio_map_resource_secondary(struct rte_cdx_device *dev)