From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 306F948B69 for ; Fri, 21 Nov 2025 12:23:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2AB8F4026F; Fri, 21 Nov 2025 12:23:11 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 68C72402E6 for ; Fri, 21 Nov 2025 12:23:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lqClKlXNUVcYxjhW6oRh3xqpwYwAhMga7YvCRyOmh/I=; b=DsB8UJbnMRkHNcYGzqYpEvphlzOvydLyRzUcPH9i3fQbNVzJRNQZUC8QirLiKsL0HnB12P NOFnOirfzrAMKM476i6/YMcmXQqeGOeqbns8TN8DugDRaZcR2xyRPKYTbEEk20fS7lItdg UO3cWRrJOHWbEOBDgstxxWlntL2We/w= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-EER6Y5h8MJ-Gqw4ZxaDyLw-1; Fri, 21 Nov 2025 06:23:07 -0500 X-MC-Unique: EER6Y5h8MJ-Gqw4ZxaDyLw-1 X-Mimecast-MFC-AGG-ID: EER6Y5h8MJ-Gqw4ZxaDyLw_1763724187 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8D9AE195608A; Fri, 21 Nov 2025 11:23:06 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9A52C30044DB; Fri, 21 Nov 2025 11:23:05 +0000 (UTC) From: Kevin Traynor To: Chengwen Feng Cc: dpdk stable Subject: patch 'app/testpmd: fix DCB Tx port' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:20:24 +0000 Message-ID: <20251121112128.485623-40-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: oLSIhKVfwkqFv3WiXFPcY9nj-y_fNLtuAUOr1bmH5Dw_1763724187 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/15f169c2c91ef6092650ca62e78e2dfc2c05357e Thanks. Kevin --- >From 15f169c2c91ef6092650ca62e78e2dfc2c05357e Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 6 Nov 2025 08:29:19 +0800 Subject: [PATCH] app/testpmd: fix DCB Tx port [ upstream commit 47012b7cbf78531e99b6ab3faa3a69e941ddbaa0 ] The txp maybe invalid (e.g. start with only one port but set with 1), this commit fix it by get txp from fwd_topology_tx_port_get() function. An added benefit is that the DCB test also supports '--port-topology' parameter. Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic class") Signed-off-by: Chengwen Feng --- app/test-pmd/config.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 4c10047754..a28b589b0a 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -5167,5 +5167,5 @@ dcb_fwd_config_setup(void) init_fwd_streams(); sm_id = 0; - txp = 1; + txp = fwd_topology_tx_port_get(rxp); /* get the dcb info on the first RX and TX ports */ (void)rte_eth_dev_get_dcb_info(fwd_ports_ids[rxp], &rxp_dcb_info); @@ -5215,9 +5215,6 @@ dcb_fwd_config_setup(void) if (rxp >= nb_fwd_ports) return; + txp = fwd_topology_tx_port_get(rxp); /* get the dcb information on next RX and TX ports */ - if ((rxp & 0x1) == 0) - txp = (portid_t) (rxp + 1); - else - txp = (portid_t) (rxp - 1); rte_eth_dev_get_dcb_info(fwd_ports_ids[rxp], &rxp_dcb_info); rte_eth_dev_get_dcb_info(fwd_ports_ids[txp], &txp_dcb_info); -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:10.838308534 +0000 +++ 0040-app-testpmd-fix-DCB-Tx-port.patch 2025-11-21 11:05:09.438201063 +0000 @@ -1 +1 @@ -From 47012b7cbf78531e99b6ab3faa3a69e941ddbaa0 Mon Sep 17 00:00:00 2001 +From 15f169c2c91ef6092650ca62e78e2dfc2c05357e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 47012b7cbf78531e99b6ab3faa3a69e941ddbaa0 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 3ce2a14a1b..0f687018c7 100644 +index 4c10047754..a28b589b0a 100644 @@ -24 +25 @@ -@@ -5188,5 +5188,5 @@ dcb_fwd_config_setup(void) +@@ -5167,5 +5167,5 @@ dcb_fwd_config_setup(void) @@ -31 +32 @@ -@@ -5236,9 +5236,6 @@ dcb_fwd_config_setup(void) +@@ -5215,9 +5215,6 @@ dcb_fwd_config_setup(void)