From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85FB148B69 for ; Fri, 21 Nov 2025 12:23:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7FD42402D7; Fri, 21 Nov 2025 12:23:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 85E8B4026F for ; Fri, 21 Nov 2025 12:23:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oBWwBG1zDUO94EDesxOjG7/2w7Jr65EqbeiskaxN8NY=; b=D6b7e93vsKUt/nGJ7PVYBXeFIXpP55OvwepQly48THRdwkDCzASBIelRV9/fRyHSokFpNz X29ukwox1mRUMEhs8OcgLljiCqpjlcoYm2R8vPkaxhLhAMhQswtVmqEU7xEAGHbVvqO870 UAPb76H9pkza7vwzZ3nWOr2pvSjwzPQ= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-444-i8AN6PZhORezUek5GKxyJg-1; Fri, 21 Nov 2025 06:23:11 -0500 X-MC-Unique: i8AN6PZhORezUek5GKxyJg-1 X-Mimecast-MFC-AGG-ID: i8AN6PZhORezUek5GKxyJg_1763724190 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E7EEE1956053; Fri, 21 Nov 2025 11:23:09 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 92D5030044DB; Fri, 21 Nov 2025 11:23:08 +0000 (UTC) From: Kevin Traynor To: Ciara Loftus Cc: Thierry Herbelot , dpdk stable Subject: patch 'net/e1000/base: fix crash on init with GCC 13' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:20:26 +0000 Message-ID: <20251121112128.485623-42-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LDrvDJid-uANuUH5AZcu9jcU6s84XyKZre-kB-ua9IU_1763724190 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/de5d2c67002923b31b644b801100be07a6444380 Thanks. Kevin --- >From de5d2c67002923b31b644b801100be07a6444380 Mon Sep 17 00:00:00 2001 From: Ciara Loftus Date: Fri, 10 Oct 2025 12:58:48 +0000 Subject: [PATCH] net/e1000/base: fix crash on init with GCC 13 [ upstream commit 4d0b1e252a58f9cee89aa08d6e9742fa4a797e91 ] The e1000 PMD crashes during initialisation in a Ubuntu 24.04 VM when compiled with gcc-13 with -O3 optimisations. This patch introduces a compiler barrier after the register read that was causing the issue. Bugzilla ID: 1691 Fixes: af75078fece3 ("first public release") Signed-off-by: Ciara Loftus Tested-by: Thierry Herbelot --- drivers/net/e1000/base/e1000_mac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_mac.c b/drivers/net/e1000/base/e1000_mac.c index 5bb77d9e09..1ab5db98f2 100644 --- a/drivers/net/e1000/base/e1000_mac.c +++ b/drivers/net/e1000/base/e1000_mac.c @@ -1827,4 +1827,5 @@ s32 e1000_id_led_init_generic(struct e1000_hw *hw) mac->ledctl_default = E1000_READ_REG(hw, E1000_LEDCTL); + rte_compiler_barrier(); mac->ledctl_mode1 = mac->ledctl_default; mac->ledctl_mode2 = mac->ledctl_default; -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:10.897541606 +0000 +++ 0042-net-e1000-base-fix-crash-on-init-with-GCC-13.patch 2025-11-21 11:05:09.442201080 +0000 @@ -1 +1 @@ -From 4d0b1e252a58f9cee89aa08d6e9742fa4a797e91 Mon Sep 17 00:00:00 2001 +From de5d2c67002923b31b644b801100be07a6444380 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4d0b1e252a58f9cee89aa08d6e9742fa4a797e91 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ - drivers/net/intel/e1000/base/e1000_mac.c | 1 + + drivers/net/e1000/base/e1000_mac.c | 1 + @@ -20,5 +21,5 @@ -diff --git a/drivers/net/intel/e1000/base/e1000_mac.c b/drivers/net/intel/e1000/base/e1000_mac.c -index 2fa97d12a9..41aae86ffe 100644 ---- a/drivers/net/intel/e1000/base/e1000_mac.c -+++ b/drivers/net/intel/e1000/base/e1000_mac.c -@@ -1843,4 +1843,5 @@ s32 e1000_id_led_init_generic(struct e1000_hw *hw) +diff --git a/drivers/net/e1000/base/e1000_mac.c b/drivers/net/e1000/base/e1000_mac.c +index 5bb77d9e09..1ab5db98f2 100644 +--- a/drivers/net/e1000/base/e1000_mac.c ++++ b/drivers/net/e1000/base/e1000_mac.c +@@ -1827,4 +1827,5 @@ s32 e1000_id_led_init_generic(struct e1000_hw *hw)