From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BBB348B69 for ; Fri, 21 Nov 2025 12:23:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8206D402E6; Fri, 21 Nov 2025 12:23:30 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D1CA1402E0 for ; Fri, 21 Nov 2025 12:23:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pnJPjLUDVDPNEklbFEdVuKd4nWNRWBKwYRiH0tvIWrU=; b=Br8uxNWZoAtUkSESsN20H0Zxyf6Ay79yjePd1mj6eNH0zEzxNFtA9kqn9PRVNQz6qF9454 /U/jRlm8ySWDJrDozjvu4Dj3WOGWGjkf4wReijlO1g4SqUMZ4we/QQjOHuar+Wj4b51bs0 9cKzoYus9EVtTKjF+I6l7rjgcNS1G1Y= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-ERmBpYMkOcuCEVLk3KB8vw-1; Fri, 21 Nov 2025 06:23:26 -0500 X-MC-Unique: ERmBpYMkOcuCEVLk3KB8vw-1 X-Mimecast-MFC-AGG-ID: ERmBpYMkOcuCEVLk3KB8vw_1763724205 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4DE26195608E; Fri, 21 Nov 2025 11:23:25 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0FC2930044DB; Fri, 21 Nov 2025 11:23:23 +0000 (UTC) From: Kevin Traynor To: Maayan Kashani Cc: Dariusz Sosnowski , dpdk stable Subject: patch 'net/mlx5: fix modify field action restriction' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:20:34 +0000 Message-ID: <20251121112128.485623-50-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6aT5LWt7HCjuIcNptB3Zkl0mjVQ4flnAeZHYdNBpW3U_1763724205 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/b600419bdf0e752f19cd9eac6f123b444d74e299 Thanks. Kevin --- >From b600419bdf0e752f19cd9eac6f123b444d74e299 Mon Sep 17 00:00:00 2001 From: Maayan Kashani Date: Wed, 5 Nov 2025 10:50:49 +0200 Subject: [PATCH] net/mlx5: fix modify field action restriction [ upstream commit 17082f45e93697dcfbe056da7f90af90362cc6b2 ] Update DV flow engine modify field validation: - Reject 'add' and 'sub' operations when source field is not VALUE or POINTER in DV flow engine. Update documentation to clarify operation support: - 'set' operation is supported in all modes - 'add' operation with VALUE/POINTER source fields is supported in DV/HWS mode. - Specify relevant HW supporting packet header as 'src' field. - List supported 'dst' fields. Fixes: 641dbe4fb053 ("net/mlx5: support modify field flow action") Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_dv.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 006684d5bd..f5dbb06cd5 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -5643,4 +5643,11 @@ flow_dv_validate_action_modify_field(struct rte_eth_dev *dev, if (src_data->field != RTE_FLOW_FIELD_VALUE && src_data->field != RTE_FLOW_FIELD_POINTER) { + if (conf->operation != RTE_FLOW_MODIFY_SET) + return rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_ACTION_CONF, + &conf->operation, + "modify field action type add is not" + " supported when src field type is" + " not value/pointer"); if (root) return rte_flow_error_set(error, ENOTSUP, -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:11.173951191 +0000 +++ 0050-net-mlx5-fix-modify-field-action-restriction.patch 2025-11-21 11:05:09.493201297 +0000 @@ -1 +1 @@ -From 17082f45e93697dcfbe056da7f90af90362cc6b2 Mon Sep 17 00:00:00 2001 +From b600419bdf0e752f19cd9eac6f123b444d74e299 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 17082f45e93697dcfbe056da7f90af90362cc6b2 ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org @@ -23,36 +24,3 @@ - doc/guides/nics/mlx5.rst | 23 ++++++++++++++++++++++- - drivers/net/mlx5/mlx5_flow_dv.c | 7 +++++++ - 2 files changed, 29 insertions(+), 1 deletion(-) - -diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst -index 8474ebf601..3eb7817f9a 100644 ---- a/doc/guides/nics/mlx5.rst -+++ b/doc/guides/nics/mlx5.rst -@@ -3087,5 +3087,26 @@ Limitations - ^^^^^^^^^^^ - --#. Supports the 'set' and 'add' operations for ``RTE_FLOW_ACTION_TYPE_MODIFY_FIELD`` action. -+#. Supports the 'set' operation for ``RTE_FLOW_ACTION_TYPE_MODIFY_FIELD`` in all flow engines. -+ -+#. Supports the 'add' operation with 'src' field -+ of type ``RTE_FLOW_FIELD_VALUE`` or ``RTE_FLOW_FIELD_POINTER`` -+ with both :ref:`HW steering ` and DV flow engine (``dv_flow_en=1``). -+ -+ HW steering flow engine, starting with ConnectX-7 and BlueField-3, -+ supports packet header fields in 'src' field. -+ -+ 'dst' field can be any of the following: -+ -+ - ``RTE_FLOW_FIELD_IPV4_TTL`` -+ - ``RTE_FLOW_FIELD_IPV6_HOPLIMIT`` -+ - ``RTE_FLOW_FIELD_TCP_SEQ_NUM`` -+ - ``RTE_FLOW_FIELD_TCP_ACK_NUM`` -+ - ``RTE_FLOW_FIELD_TAG`` -+ - ``RTE_FLOW_FIELD_META`` -+ - ``RTE_FLOW_FIELD_FLEX_ITEM`` -+ - ``RTE_FLOW_FIELD_TCP_DATA_OFFSET`` -+ - ``RTE_FLOW_FIELD_IPV4_IHL`` -+ - ``RTE_FLOW_FIELD_IPV4_TOTAL_LEN`` -+ - ``RTE_FLOW_FIELD_IPV6_PAYLOAD_LEN`` - - #. In template tables of group 0, the modify action must be fully masked. + drivers/net/mlx5/mlx5_flow_dv.c | 7 +++++++ + 1 file changed, 7 insertions(+) + @@ -60 +28 @@ -index f765f94116..95ca57e8c4 100644 +index 006684d5bd..f5dbb06cd5 100644