From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFDDE48B69 for ; Fri, 21 Nov 2025 12:23:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA8024026F; Fri, 21 Nov 2025 12:23:51 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id DA4A2402EF for ; Fri, 21 Nov 2025 12:23:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CS8bv0+jsXLcvOSPekGdOocVlBmurpc1U9fAZP1di+M=; b=idhWcjxSeg4xMwztwdVd27yJlL0VtGa/kPRcwgwJDL9/x5emCgUQJZyBiyGpQdRwYIPMsB 9gCzLCb2JXJ0wXoZKWih5yXZaquHnCXt+uElaLKm1t8pqg4DbMpbJTulENMmGcHYsE2D5T JnlTsb0l6FtlvM9ij1xTPraC2WduvjQ= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-91-RH4XW_f_MTCJ78AB30omHg-1; Fri, 21 Nov 2025 06:23:46 -0500 X-MC-Unique: RH4XW_f_MTCJ78AB30omHg-1 X-Mimecast-MFC-AGG-ID: RH4XW_f_MTCJ78AB30omHg_1763724226 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 335E01954B0D for ; Fri, 21 Nov 2025 11:23:46 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 41C4530044DB; Fri, 21 Nov 2025 11:23:45 +0000 (UTC) From: Kevin Traynor To: Robin Jarry Cc: dpdk stable Subject: patch 'usertools/telemetry: fix exporter default IP binding' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:20:45 +0000 Message-ID: <20251121112128.485623-61-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: h1pH6FQGh_mceQzzilhsIsd3G9g1p-438L9vSx_0Wtk_1763724226 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a5b7b00d9af02c90475bc14f79720e62d359ab33 Thanks. Kevin --- >From a5b7b00d9af02c90475bc14f79720e62d359ab33 Mon Sep 17 00:00:00 2001 From: Robin Jarry Date: Mon, 27 Jan 2025 12:51:44 +0100 Subject: [PATCH] usertools/telemetry: fix exporter default IP binding [ upstream commit 9a8382b0685674d80e4787f8db2885343edaea29 ] Fix the following warning reported by Coverity: Defect type: SIGMA.insecure_network_bind: > dpdk-stable-24.11.1/usertools/dpdk-telemetry-exporter.py:278: > Sigma main event: The HTTP server binds to all network interfaces by > setting the IP address to "", `0.0.0.0`, `::`, or `::0`. > This may expose the server to unintended traffic. Avoid listening to all interfaces by default to avoid exposing private information unwillingly. Unrelated: The Python stdlib TCP server listens on IPv4 only by default. Changing this requires creating a subclass that overrides address_family to socket.AF_INET6. Fixes: d94ebd627a86 ("usertools: add telemetry exporter") Signed-off-by: Robin Jarry --- usertools/dpdk-telemetry-exporter.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/usertools/dpdk-telemetry-exporter.py b/usertools/dpdk-telemetry-exporter.py index 6eca0db2e8..6f66d4ecaa 100755 --- a/usertools/dpdk-telemetry-exporter.py +++ b/usertools/dpdk-telemetry-exporter.py @@ -76,5 +76,5 @@ DEFAULT_LOAD_PATHS += [ "/usr/share/dpdk/telemetry-endpoints", ] -DEFAULT_OUTPUT = "openmetrics://:9876" +DEFAULT_OUTPUT = "openmetrics://127.0.0.1:9876" @@ -276,9 +276,9 @@ def serve_openmetrics( format. """ - listen = (args.output.hostname or "", int(args.output.port or 80)) + listen = (args.output.hostname or "127.0.0.1", int(args.output.port or 80)) with server.HTTPServer(listen, OpenmetricsHandler) as httpd: httpd.dpdk_socket_path = args.socket_path httpd.telemetry_endpoints = endpoints - LOG.info("listening on port %s", httpd.server_port) + LOG.info("listening on %s", httpd.socket.getsockname()) try: httpd.serve_forever() -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:11.504712316 +0000 +++ 0061-usertools-telemetry-fix-exporter-default-IP-binding.patch 2025-11-21 11:05:09.537857508 +0000 @@ -1 +1 @@ -From 9a8382b0685674d80e4787f8db2885343edaea29 Mon Sep 17 00:00:00 2001 +From a5b7b00d9af02c90475bc14f79720e62d359ab33 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9a8382b0685674d80e4787f8db2885343edaea29 ] + @@ -22 +23,0 @@ -Cc: stable@dpdk.org