From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6B0148B69 for ; Fri, 21 Nov 2025 12:24:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C197E402F0; Fri, 21 Nov 2025 12:24:03 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1CC134026F for ; Fri, 21 Nov 2025 12:24:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wTx25ThFHMH+hwvnruyXjbvWWinhD+e833t5XBL3bME=; b=J7+LmIZh2hFyNRdazmBWRxRVGQCKZswHMBa3OGsciSbV8HzOz6rGb3U4GNOJtFTxbF1BGN jpxylscymTo5ERvVu+XWCvsKk4foXGVfNiKppoLLBY75Fmr7b4y2CieEIAjFxGvbodVdk2 kNG40sz92KYnNrt7CuANce2ZdJXZytA= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-8-4uOZVCIVONu7xB9lb5fnQQ-1; Fri, 21 Nov 2025 06:24:00 -0500 X-MC-Unique: 4uOZVCIVONu7xB9lb5fnQQ-1 X-Mimecast-MFC-AGG-ID: 4uOZVCIVONu7xB9lb5fnQQ_1763724239 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 65E2F19560B7; Fri, 21 Nov 2025 11:23:59 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2ABA730044E8; Fri, 21 Nov 2025 11:23:57 +0000 (UTC) From: Kevin Traynor To: Maayan Kashani Cc: dpdk stable Subject: patch 'app/testpmd: fix flex item link parsing' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:20:52 +0000 Message-ID: <20251121112128.485623-68-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7X5Sh1PimWIYLPpQ_VxCethxZVBkTZ7ij0m5xie-5tM_1763724239 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/01961bc399fa0249515b289908b46509c49f0129 Thanks. Kevin --- >From 01961bc399fa0249515b289908b46509c49f0129 Mon Sep 17 00:00:00 2001 From: Maayan Kashani Date: Sun, 16 Nov 2025 14:14:37 +0200 Subject: [PATCH] app/testpmd: fix flex item link parsing [ upstream commit 39454e245b125ae555bc5a3a058cc3c1e1280f82 ] The flex_link_item_parse function was using FLEX_MAX_FLOW_PATTERN_LENGTH for all memcpy operations regardless of the actual flow item type. This could lead to copying incorrect amounts of data. This patch adds a switch statement to determine the correct size based on the actual flow item type (IPv4, IPv6, UDP, TCP) and uses that size for the memcpy operations on spec, mask, and last fields. Also adds validation to reject unsupported item types. Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands") Signed-off-by: Maayan Kashani --- app/test-pmd/cmd_flex_item.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmd_flex_item.c b/app/test-pmd/cmd_flex_item.c index e6e1cefeb3..af6c087feb 100644 --- a/app/test-pmd/cmd_flex_item.c +++ b/app/test-pmd/cmd_flex_item.c @@ -144,19 +144,20 @@ flex_link_item_parse(const char *src, struct rte_flow_item *item) return ret; item->type = pattern->type; - if (pattern->spec) { + ret = rte_flow_conv(RTE_FLOW_CONV_OP_ITEM_MASK, NULL, 0, item, NULL); + if ((ret > 0) && pattern->spec) { ptr = (void *)(uintptr_t)item->spec; - memcpy(ptr, pattern->spec, FLEX_MAX_FLOW_PATTERN_LENGTH); + memcpy(ptr, pattern->spec, ret); } else { item->spec = NULL; } - if (pattern->mask) { + if ((ret > 0) && pattern->mask) { ptr = (void *)(uintptr_t)item->mask; - memcpy(ptr, pattern->mask, FLEX_MAX_FLOW_PATTERN_LENGTH); + memcpy(ptr, pattern->mask, ret); } else { item->mask = NULL; } - if (pattern->last) { + if ((ret > 0) && pattern->last) { ptr = (void *)(uintptr_t)item->last; - memcpy(ptr, pattern->last, FLEX_MAX_FLOW_PATTERN_LENGTH); + memcpy(ptr, pattern->last, ret); } else { item->last = NULL; -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:11.702940903 +0000 +++ 0068-app-testpmd-fix-flex-item-link-parsing.patch 2025-11-21 11:05:09.546173834 +0000 @@ -1 +1 @@ -From 39454e245b125ae555bc5a3a058cc3c1e1280f82 Mon Sep 17 00:00:00 2001 +From 01961bc399fa0249515b289908b46509c49f0129 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 39454e245b125ae555bc5a3a058cc3c1e1280f82 ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org