From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0830548B69 for ; Fri, 21 Nov 2025 12:24:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02BA3402E6; Fri, 21 Nov 2025 12:24:09 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 27057402E5 for ; Fri, 21 Nov 2025 12:24:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AfpoWssS5mX27Q4Q6lSkXOywcJJRiW4e1Y//2YlHM/4=; b=JI2C5GaHQoFZg6cG4UndCLme577HYSLyHahSTOSQ367iw3uf82ycPwMkzUmFpL4C69YT/+ RvdCsIbiWr+p+dax2hUf/ZmbgG1u+fby4vf46aq6RYcFz6xZexg/MDk1l09KRvYxx6bY3V iKRUmzXrSRx1OsfBWOMbUVKceJo9WiI= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-CVrqMTcnOxa3Qyn1nB4Vrg-1; Fri, 21 Nov 2025 06:24:02 -0500 X-MC-Unique: CVrqMTcnOxa3Qyn1nB4Vrg-1 X-Mimecast-MFC-AGG-ID: CVrqMTcnOxa3Qyn1nB4Vrg_1763724241 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8D7171956053; Fri, 21 Nov 2025 11:24:01 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DCB9F30044DB; Fri, 21 Nov 2025 11:23:59 +0000 (UTC) From: Kevin Traynor To: Andrzej Wilczynski Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/ixgbe/base: fix PF link state request size' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:20:53 +0000 Message-ID: <20251121112128.485623-69-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: I7u2cg3LZrSQGzqrfmmflySXwbUwi3r7OJCO2SN-MSY_1763724241 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/47b00e6f6ad34672a136383757d48c09320a73a3 Thanks. Kevin --- >From 47b00e6f6ad34672a136383757d48c09320a73a3 Mon Sep 17 00:00:00 2001 From: Andrzej Wilczynski Date: Mon, 10 Nov 2025 13:55:39 +0000 Subject: [PATCH] net/ixgbe/base: fix PF link state request size [ upstream commit 82ff0aa59735fefa6e9e9daf77ea87da5b68fabd ] Currently, when requesting PF link state over VF mailbox, the buffer sized 3 dwords is allocated. However, the `ixgbevf_write_msg_read_ack` function is actually called with buffer size of 6 dwords. This leaves an admittedly remote possibility of buffer overrun. Fix by adjusting requested size to 3. Bugzilla ID: 1801 Fixes: adbd71030575 ("net/ixgbe/base: fix link status for E610") Signed-off-by: Andrzej Wilczynski Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/ixgbe/base/ixgbe_vf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/ixgbe_vf.c b/drivers/net/ixgbe/base/ixgbe_vf.c index 46a62bb851..eb16fb1942 100644 --- a/drivers/net/ixgbe/base/ixgbe_vf.c +++ b/drivers/net/ixgbe/base/ixgbe_vf.c @@ -483,5 +483,5 @@ int ixgbevf_get_pf_link_state(struct ixgbe_hw *hw, ixgbe_link_speed *speed, msgbuf[0] = IXGBE_VF_GET_PF_LINK_STATE; - err = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, 6); + err = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, 3); if (err || (msgbuf[0] & IXGBE_VT_MSGTYPE_FAILURE)) { err = IXGBE_ERR_MBX; -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:11.731398215 +0000 +++ 0069-net-ixgbe-base-fix-PF-link-state-request-size.patch 2025-11-21 11:05:09.546201523 +0000 @@ -1 +1 @@ -From 82ff0aa59735fefa6e9e9daf77ea87da5b68fabd Mon Sep 17 00:00:00 2001 +From 47b00e6f6ad34672a136383757d48c09320a73a3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 82ff0aa59735fefa6e9e9daf77ea87da5b68fabd ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ - drivers/net/intel/ixgbe/base/ixgbe_vf.c | 2 +- + drivers/net/ixgbe/base/ixgbe_vf.c | 2 +- @@ -22 +23 @@ -diff --git a/drivers/net/intel/ixgbe/base/ixgbe_vf.c b/drivers/net/intel/ixgbe/base/ixgbe_vf.c +diff --git a/drivers/net/ixgbe/base/ixgbe_vf.c b/drivers/net/ixgbe/base/ixgbe_vf.c @@ -24,2 +25,2 @@ ---- a/drivers/net/intel/ixgbe/base/ixgbe_vf.c -+++ b/drivers/net/intel/ixgbe/base/ixgbe_vf.c +--- a/drivers/net/ixgbe/base/ixgbe_vf.c ++++ b/drivers/net/ixgbe/base/ixgbe_vf.c