From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E64648B69 for ; Fri, 21 Nov 2025 12:24:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 194A5402E6; Fri, 21 Nov 2025 12:24:11 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6D1A7402EF for ; Fri, 21 Nov 2025 12:24:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DCCM4QjeqXotSs71Ax98KWisWEJfUWfUiSdD17wS5Tg=; b=POAYwr6NzRoXUcio3CGzFpph4bIFHe/z2beTAwVJKKPKuItHHy6baGAmNrqAIhDdp1jyDw mECd2cQ5nnCE0aoXeP4l6ZlCCkwSZDL/GllOLV5PJjRQgBZVQWCCCEL/JhcWD0kLWCT4a+ RQuRI9j2ddOCf0R0B7XEdY/o006FMlg= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-102-PGx24kKANBK_OLNyiISrPA-1; Fri, 21 Nov 2025 06:24:07 -0500 X-MC-Unique: PGx24kKANBK_OLNyiISrPA-1 X-Mimecast-MFC-AGG-ID: PGx24kKANBK_OLNyiISrPA_1763724247 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D9E57180047F; Fri, 21 Nov 2025 11:24:06 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B3FEB30044DB; Fri, 21 Nov 2025 11:24:05 +0000 (UTC) From: Kevin Traynor To: Ciara Loftus Cc: Praveen Shetty , dpdk stable Subject: patch 'net/idpf: fix queue setup with TSO offload' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:20:56 +0000 Message-ID: <20251121112128.485623-72-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9vEReN1PLoOCtlDsHdy9a_LE-bxwH2U8CHmBmBkDZrw_1763724247 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/7c5bc6304361d65912d521558c7c3689be0d9642 Thanks. Kevin --- >From 7c5bc6304361d65912d521558c7c3689be0d9642 Mon Sep 17 00:00:00 2001 From: Ciara Loftus Date: Thu, 13 Nov 2025 14:50:21 +0000 Subject: [PATCH] net/idpf: fix queue setup with TSO offload [ upstream commit f36df6a25569102afa911b74d8613a5e7267f038 ] The TCP_TSO Tx offload was missing from the conversion function. This was effectively taking the request for that offload out of consideration when selecting the Tx function. As a result a vector path which does not support TSO could be chosen when that offload was requested, when instead the scalar path should be chosen which does support that offload. Fix this by adding the TSO offload to the conversion function. Fixes: c008a5e740bd ("common/idpf: add queue setup/release") Signed-off-by: Ciara Loftus Acked-by: Praveen Shetty --- drivers/net/idpf/idpf_rxtx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c index 858bbefe3b..b53f642902 100644 --- a/drivers/net/idpf/idpf_rxtx.c +++ b/drivers/net/idpf/idpf_rxtx.c @@ -43,4 +43,6 @@ idpf_tx_offload_convert(uint64_t offload) if ((offload & RTE_ETH_TX_OFFLOAD_SCTP_CKSUM) != 0) ol |= IDPF_TX_OFFLOAD_SCTP_CKSUM; + if ((offload & RTE_ETH_TX_OFFLOAD_TCP_TSO) != 0) + ol |= IDPF_TX_OFFLOAD_TCP_TSO; if ((offload & RTE_ETH_TX_OFFLOAD_MULTI_SEGS) != 0) ol |= IDPF_TX_OFFLOAD_MULTI_SEGS; -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:11.817246918 +0000 +++ 0072-net-idpf-fix-queue-setup-with-TSO-offload.patch 2025-11-21 11:05:09.551003309 +0000 @@ -1 +1 @@ -From f36df6a25569102afa911b74d8613a5e7267f038 Mon Sep 17 00:00:00 2001 +From 7c5bc6304361d65912d521558c7c3689be0d9642 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f36df6a25569102afa911b74d8613a5e7267f038 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ - drivers/net/intel/idpf/idpf_rxtx.c | 2 ++ + drivers/net/idpf/idpf_rxtx.c | 2 ++ @@ -22,4 +23,4 @@ -diff --git a/drivers/net/intel/idpf/idpf_rxtx.c b/drivers/net/intel/idpf/idpf_rxtx.c -index 1c725065df..4796d8b862 100644 ---- a/drivers/net/intel/idpf/idpf_rxtx.c -+++ b/drivers/net/intel/idpf/idpf_rxtx.c +diff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c +index 858bbefe3b..b53f642902 100644 +--- a/drivers/net/idpf/idpf_rxtx.c ++++ b/drivers/net/idpf/idpf_rxtx.c