From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5778D48B69 for ; Fri, 21 Nov 2025 12:24:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52D964026F; Fri, 21 Nov 2025 12:24:12 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 035EB4026F for ; Fri, 21 Nov 2025 12:24:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zrzXOiZdj90Ajopq1tr5O8xa4jh+HYe9jmGMWf1CEfA=; b=c3uMVlMBWt5T6R4fdd5yywvuG5FG2HqRdkc6D1JA/oFI5UMDFZBuRgbSayqKfNE0WXq0KL OyqiX62wYQ3htub3eWKMIundYrJsBVyI/r6h/DF/cezWV3vVIHb94wcKqatbqbzP/uRqjs a6yCoClaOOk+RH/i7mnXn8bMUms3vbk= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-3yoEDbX_ORefsjtUar5vkQ-1; Fri, 21 Nov 2025 06:24:09 -0500 X-MC-Unique: 3yoEDbX_ORefsjtUar5vkQ-1 X-Mimecast-MFC-AGG-ID: 3yoEDbX_ORefsjtUar5vkQ_1763724248 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 725C7195605B; Fri, 21 Nov 2025 11:24:08 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5D23530044E7; Fri, 21 Nov 2025 11:24:07 +0000 (UTC) From: Kevin Traynor To: Jacob Keller Cc: dpdk stable Subject: patch 'net/iavf: fix check for PF Rx timestamp support' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:20:57 +0000 Message-ID: <20251121112128.485623-73-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lL55ljCX4EUY0lEbeYHs_CjkPB-R3f4-cOmeu-qMFtE_1763724248 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/1a2e23cdef511133d8d0dd4dc586f9d65758b861 Thanks. Kevin --- >From 1a2e23cdef511133d8d0dd4dc586f9d65758b861 Mon Sep 17 00:00:00 2001 From: Jacob Keller Date: Thu, 13 Nov 2025 13:33:44 -0800 Subject: [PATCH] net/iavf: fix check for PF Rx timestamp support [ upstream commit d21c2fe6e5a1ef1e7cc9490f54f359db1cfd5283 ] The iavf driver has support for hardware Rx timestamps since commit b5cd735132f6 ("net/iavf: enable Rx timestamp on flex descriptor"). To enable this, the VF must first negotiate PTP capabilities with the PF by sending the VIRTCHNL_OP_1588_PTP_GET_CAPS command, with the requested capabilities. The PF will respond with the actually supported subset of capabilities. The PF may not actually enable Rx timestamping, even if it reports the overall PTP capability support. If this happens, the iavf driver logic will incorrectly report that Rx timestamps can be enabled despite being rejected by the PF. This is unlikely in practice, as most PFs which support the VIRTCHNL_VF_CAP_PTP will support Rx timestamping. However, there are some cases where this may not be true. Check that the PF actually reports the Rx timestamping capability instead of assuming it is enabled. Doing so prevents the DPDK application from attempting to enable Rx timestamps when they won't actually be enabled. Fixes: b5cd735132f6 ("net/iavf: enable Rx timestamp on flex descriptor") Signed-off-by: Jacob Keller --- drivers/net/iavf/iavf_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 8dd1f4b103..65bc1efc68 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -1178,5 +1178,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->rx_offload_capa |= RTE_ETH_RX_OFFLOAD_KEEP_CRC; - if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_CAP_PTP) + if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_CAP_PTP && + vf->ptp_caps & VIRTCHNL_1588_PTP_CAP_RX_TSTAMP) dev_info->rx_offload_capa |= RTE_ETH_RX_OFFLOAD_TIMESTAMP; -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:11.845371060 +0000 +++ 0073-net-iavf-fix-check-for-PF-Rx-timestamp-support.patch 2025-11-21 11:05:09.552201549 +0000 @@ -1 +1 @@ -From d21c2fe6e5a1ef1e7cc9490f54f359db1cfd5283 Mon Sep 17 00:00:00 2001 +From 1a2e23cdef511133d8d0dd4dc586f9d65758b861 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d21c2fe6e5a1ef1e7cc9490f54f359db1cfd5283 ] + @@ -29 +30,0 @@ -Cc: stable@dpdk.org @@ -33 +34 @@ - drivers/net/intel/iavf/iavf_ethdev.c | 3 ++- + drivers/net/iavf/iavf_ethdev.c | 3 ++- @@ -36,4 +37,4 @@ -diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c -index 15e49fe248..3ef766de47 100644 ---- a/drivers/net/intel/iavf/iavf_ethdev.c -+++ b/drivers/net/intel/iavf/iavf_ethdev.c +diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c +index 8dd1f4b103..65bc1efc68 100644 +--- a/drivers/net/iavf/iavf_ethdev.c ++++ b/drivers/net/iavf/iavf_ethdev.c