From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F4F148B69 for ; Fri, 21 Nov 2025 12:24:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A021402E5; Fri, 21 Nov 2025 12:24:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CB33F402E5 for ; Fri, 21 Nov 2025 12:24:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jQC6TmZoD1uw0CR9rtZ8iAmRkk9uZQ8ttLHa3vUeEjI=; b=EeKq6aP5QFmt+YUqH7mRs2ysTZPU6ERRv2cv7124rqmPOwCZzimrT4Rwy0xpFZo072bN8W OZSFgB/IIXvKSDnClXD+bbJgcIykyTIfJmVGcxJ+Z1pFiCrc5F6V11VFGeuIi9I9KcQt7F LtSJbLC/5Rg5u0C7KaeuXdScUPZdUR4= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-282-VGkBxucaPQGB2jA86PzbJw-1; Fri, 21 Nov 2025 06:24:13 -0500 X-MC-Unique: VGkBxucaPQGB2jA86PzbJw-1 X-Mimecast-MFC-AGG-ID: VGkBxucaPQGB2jA86PzbJw_1763724252 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 30839195608E; Fri, 21 Nov 2025 11:24:12 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EB3FD30044DC; Fri, 21 Nov 2025 11:24:10 +0000 (UTC) From: Kevin Traynor To: Sunil Kumar Kori Cc: dpdk stable Subject: patch 'common/cnxk: fix max number of SQB buffers in clean up' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:20:59 +0000 Message-ID: <20251121112128.485623-75-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qip6xP90cX9c12xnspzrZwmablZwuMJnNkWdh9sr_nU_1763724252 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/103bd8849273e26acf455f818895adf35fbc1e32 Thanks. Kevin --- >From 103bd8849273e26acf455f818895adf35fbc1e32 Mon Sep 17 00:00:00 2001 From: Sunil Kumar Kori Date: Thu, 13 Nov 2025 10:07:57 +0530 Subject: [PATCH] common/cnxk: fix max number of SQB buffers in clean up [ upstream commit f3c15bb6062475a62451c62ca2c5c9a5e12706c8 ] By default, SQB pool is created with max (512 buffers) + extra threshold buffers and aura limit is set to 512 + thr. But while clean up, aura limit is reset to MAX (512 buffers) only before destroying the pool. Hence while destroying the pool, only 512 buffers are cleaned from aura and extra threshold buffers are left as it is. At later stage if same SQB pool is created then H/W throws error for extra threshold buffers that it is already in pool. Fixes: 780f90e951a5 ("common/cnxk: restore NIX SQB pool limit before destroy") Signed-off-by: Sunil Kumar Kori --- drivers/common/cnxk/roc_nix_queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_nix_queue.c b/drivers/common/cnxk/roc_nix_queue.c index 39bd051c94..ccb685240c 100644 --- a/drivers/common/cnxk/roc_nix_queue.c +++ b/drivers/common/cnxk/roc_nix_queue.c @@ -2032,5 +2032,5 @@ roc_nix_sq_fini(struct roc_nix_sq *sq) * for aura drain to succeed. */ - roc_npa_aura_limit_modify(sq->aura_handle, NIX_MAX_SQB); + roc_npa_aura_limit_modify(sq->aura_handle, sq->aura_sqb_bufs); rc |= roc_npa_pool_destroy(sq->aura_handle); plt_free(sq->fc); -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:11.903598220 +0000 +++ 0075-common-cnxk-fix-max-number-of-SQB-buffers-in-clean-u.patch 2025-11-21 11:05:09.555201562 +0000 @@ -1 +1 @@ -From f3c15bb6062475a62451c62ca2c5c9a5e12706c8 Mon Sep 17 00:00:00 2001 +From 103bd8849273e26acf455f818895adf35fbc1e32 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f3c15bb6062475a62451c62ca2c5c9a5e12706c8 ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index e59cd77538..1de6e51c5e 100644 +index 39bd051c94..ccb685240c 100644 @@ -31 +32 @@ -@@ -2058,5 +2058,5 @@ roc_nix_sq_fini(struct roc_nix_sq *sq) +@@ -2032,5 +2032,5 @@ roc_nix_sq_fini(struct roc_nix_sq *sq)